From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70CA7C004D4 for ; Thu, 19 Jan 2023 11:18:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 124C06B0072; Thu, 19 Jan 2023 06:18:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D5216B0074; Thu, 19 Jan 2023 06:18:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDF346B0075; Thu, 19 Jan 2023 06:18:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DF38D6B0072 for ; Thu, 19 Jan 2023 06:18:46 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B965E1A0156 for ; Thu, 19 Jan 2023 11:18:46 +0000 (UTC) X-FDA: 80371301052.26.ADF1E1B Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf25.hostedemail.com (Postfix) with ESMTP id 2812CA0003 for ; Thu, 19 Jan 2023 11:18:44 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=u6cJoehE; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674127125; a=rsa-sha256; cv=none; b=8FVe2daFwgUZrZlLGLnH3Hk3IjkI2JvA+NAW+A1cCRs/O0fpQLrHy4pXKddunzjDL4VrWU Y846b5e/+PNmk6WgmwRrfZ8c9zggJtuL5new6i13FYDEYdVUbEeCGVy0sCVX6Rg3IA/7jU MDz9HYtphED3VsQQ1xOyXNHb35V11Ok= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=u6cJoehE; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674127125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5anVcR5TZ7Ddwq92TJrFrugq0Wxf7kIB3/1DwsEGkGE=; b=IhgbHa8uFT48TOAEPSHs5pO8HahDTzjqABoV0qLmdqm3gVbHxD6qLyP7pkbp98Qdpz6lBb WNKzL+Ak7TLIoQJ3gSx7DXojg+Y+U0jNfrbf5wqcPbLXGN3Em6+x2ez8oyI4N4cSmZNpb2 B9o1iKMtWtSkK+UJ9ZcfDOzKDXxXCsM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 93F85B821A9; Thu, 19 Jan 2023 11:18:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6B00C433D2; Thu, 19 Jan 2023 11:18:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674127122; bh=vvZecrv0HUHBZBmMBkUVX2/eP+h+y0/Xd+3q+kxApnw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u6cJoehEavsDoTeCZXa0ce6xnTVNysvP/Qb+/Omm7HpAqkG4j1sg8E37iEtooM/gM VkMC7Fkia75+toDLzpVSty3r1f/wWB9xHWhu8xRApTAfbwDLH1153A5oWCMQSt2b5H fBpCcDXEjnL/5NnZy/oTmzGpYExT4vyg7724CF0vvXawJXb61vtzKGjaitVJ3qU+Qq wnxkhYiE6Hw2+EfCJmkKks8yqcadBsJQlFRQSnB5U6V95/tSm9VVtjCrPW3zYFBdip UKs0UR03VJakveclH158EnEmSHHvFWMFFCNAJosQGmVMZPU+5+zClx2iO2f7j6K2P7 YCSXQDYWg2zCQ== Date: Thu, 19 Jan 2023 13:18:30 +0200 From: Mike Rapoport To: Jason Gunthorpe Cc: Alistair Popple , John Hubbard , linux-mm@kvack.org Subject: Re: [PATCH 0/8] Simplify the external interface for GUP Message-ID: References: <0-v1-dd94f8f0d5ad+716-gup_tidy_jgg@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0-v1-dd94f8f0d5ad+716-gup_tidy_jgg@nvidia.com> X-Rspam-User: X-Rspamd-Queue-Id: 2812CA0003 X-Rspamd-Server: rspam01 X-Stat-Signature: aho8rqwymuk9u61p5zh1arofix96wumb X-HE-Tag: 1674127124-900851 X-HE-Meta: U2FsdGVkX18K/NqRdqGYf0NKkaM8WhPu4SFW+RtP/wsKpgrHQ00FA4h58UCOm8SfUMmEJ6WRKe5V+9dkfSv9m/uhCyPeC0C0gtalH87Gu790YcO20DvWmdc329DRJInhNbziotG0ic706Oz7qeSked1Dpcf1ywsRDVefkH6wMRfp3fUbvqprCweg6qFpdgagpbiMVSBfsWeBSTq5N2rjF9zqUs4tMkmw5GGP946cTs3i+olumc5wCxvIIVcVGzhm++g12kGOqFLgWbbb6YEV+lfpR3DW72hfKG8JrfCawvZxnqzsL3606rA4y54ziywcZluX1IRpk2fci5msEFnhJt8GWO4XXb94Yqu6U7VSuzCd9WO5yB+lz1cLQN5GHn48LLV/WWeFBagFAjqdqb0tkH+RjRxnEuhS3/f6tR0PNvnw7tMNkkJOwwmxdzR3p09zT1hOl+KYOWZCOp3Q27yv7Ny3ZunTYuM7L1QxWfqQhIZpF089+tJrywp6DXrJrWbnvgSKwFEtzggxb1YdUEPtt66XasZfBJC6HS3X4DTn0yWJKg2G5YF9CQVVlwVyHw91v5+iUqgOF3t1IggesRtgVU4mmql68MwiQFp1ldFaUP0zwXMFmqyyxma/GT9jAm0UqfAJn78LQT4GrrPmCESf9kpCXpigp2LtzqbPJNayhkTtFiGUAIM3rYfryMyBxzwexrWI6CNIhqp4JAgPuSVDOYU9s/Th0tp179EUhYROTyn4xoud9c7kXUTSiZK5XdvdAHU9waemGJQwnerWQrhpP3Y9v1AdnsjDydIkb1xl4Ca1Vmhpu2M+Vvd3ynisVNDSh4Tk+mkFrRvbUaCVBCY09diauxtdNvlcUQpIudC3/6h87Un3zt7TsWmoAcP36UaHWztnFwmjNz2KZ1qOYZoQqPiid//ky85Y6zpP6aPEoE09cPktvwMqXm+fiD7LSiQTpCZQGSUKxN7KfcJnQfY W/TGDo+I 14+J+kbU+qpFhpSqhBaZSsgc0DkMKlrD7XujU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 17, 2023 at 11:58:31AM -0400, Jason Gunthorpe wrote: > It is quite a maze of EXPORTED symbols leading up to the three actual > worker functions of GUP. Simplify this by reorganizing some of the code so > the EXPORTED symbols directly call the correct internal function with > validated and consistent arguments. > > Consolidate all the assertions into one place at the top of the call > chains. > > Remove some dead code. > Jason Gunthorpe (8): > mm/gup: have internal functions get the mmap_read_lock() > mm/gup: don't call __gup_longterm_locked() if FOLL_LONGTERM cannot be > set > mm/gup: simplify the external interface functions and consolidate > invariants > mm/gup: add an assertion that the mmap lock is locked > mm/gup: add FOLL_UNLOCK > mm/gup: make locked never NULL in the internal GUP functions > mm/gup: remove pin_user_pages_fast_only() > mm/gup: make get_user_pages_fast_only() return the common return value > > include/linux/mm.h | 3 +- > mm/gup.c | 319 +++++++++++++++++++++------------------------ > mm/huge_memory.c | 10 -- > 3 files changed, 150 insertions(+), 182 deletions(-) Acked-by: Mike Rapoport (IBM) > base-commit: 5dc4c995db9eb45f6373a956eb1f69460e69e6d4 > -- > 2.39.0 > > -- Sincerely yours, Mike.