From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC90AC004D4 for ; Thu, 19 Jan 2023 18:46:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 221656B0074; Thu, 19 Jan 2023 13:46:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AAAA6B0075; Thu, 19 Jan 2023 13:46:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04AB26B0078; Thu, 19 Jan 2023 13:46:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E557C6B0074 for ; Thu, 19 Jan 2023 13:46:29 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A74A31603F6 for ; Thu, 19 Jan 2023 18:46:29 +0000 (UTC) X-FDA: 80372429298.17.1678126 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf17.hostedemail.com (Postfix) with ESMTP id E274C40015 for ; Thu, 19 Jan 2023 18:46:27 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="o0wR/Hob"; spf=pass (imf17.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674153988; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o5VvXtGzEijxQ7Vz2IDyDp3w65SP490Xvu4lrxxc3O4=; b=lzOn4E3m2+Ez+yTFt90Ih5T1Nhl5eR3//KVHIEFDJ/ciz2Mj28IaqEZPn6vBj4zQfwWi28 nDbh+2rkOztFoJ+o/QeqIbVF0d5K0fhYP6AdwN5c4xZO7DJufKiSNQ/j9sXTAVhQeOXXJ8 RdaCSR0B50PuMCLLHfZ9KkagwHf+igY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="o0wR/Hob"; spf=pass (imf17.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674153988; a=rsa-sha256; cv=none; b=sWfqvFZtevhrfvxgvEAe8NgCL8xlbmbWpkRs+HqyXXpwNHGLrn+RjalbNWOTFYzeOHYK3x fgarB5CCRqherYavn6H/WdYavHKMcr30MLE4dDQf7Y39C4e/wu0NQrGbt3cSAiP6MRYePO JZCAusSdX8UyTIqYX4hMQ1M1ROZRLo8= Received: by mail-ed1-f41.google.com with SMTP id r15so899112edi.12 for ; Thu, 19 Jan 2023 10:46:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=o5VvXtGzEijxQ7Vz2IDyDp3w65SP490Xvu4lrxxc3O4=; b=o0wR/Hob6pSvZuUpQI3n4uWHCMenWWV5DtsQtwTxNs0avaKSrqhc5z76NL/E9cv5Xi HapD/+1S6Tveefti7PffCmtNmtzZvYv/1nyWvn11I7V6zWO8I7oYYapBSGJNu+UP1lqj wxVGhkgnFChPR8PvPdS9dr3sbgcBsHOAGb5zBNRamDNykubGlxpPvaen4kamUcQvqUFX 4rYrAmZeqQ3JrJLorXIpwqoarYurFXuwFNbJj7Fa6HR5bnsGQWaoCoF3/q24sy0D8a6s 2t5eWTJLvtofAllYswbj8fl/rowjtmrxR5jdXnAB6LW10aa20NKiBozEMa4qk6c7uBF0 t1LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o5VvXtGzEijxQ7Vz2IDyDp3w65SP490Xvu4lrxxc3O4=; b=TPhcPwMh/vi6eEW0+knpcxWAYQ2MiQObAHNo4w3roUwi7/dKLIHrdkpJD22BhkZzpQ TDv0xNnUMthWC2oihDyoRuEIYV/jtcVFlfO6yIYbwaLncEPgwyP3je/qLtqb1qB8dSjH rEHES07PGnwL7LF7QayTbCDnhbEVG+46wv/r1G+zPFtMPEvBpmOMg69T2XBVylmN9dQh yMrfH76/YcPSX1fWnLIIBR6RejdjK+xz1648DavRhaxS0BctkmxOn73QVLQXsd+BdJ4Y Hp1zZPp/GDgQWFxrSXD03WOPoOP0xX2XNn/AX/fR4o4OHUlWblrUYrYfObPtr2wx9c+C Hw0g== X-Gm-Message-State: AFqh2kpG7V5pUQupGMw9mOyFlXkvotbYDLHA2ZIEwMAtaEon/EFTZBPO Dp2E338jy4Hekwc8nLt4rG0= X-Google-Smtp-Source: AMrXdXuJLHYJ7e0OVRdkyIFFx7KJ0Vqa7o9EsTlRvWhOiaZZZuuIfQcIN7X5GiVezg3mvfWfbrJQ1A== X-Received: by 2002:a05:6402:3986:b0:49d:5c6:3e5f with SMTP id fk6-20020a056402398600b0049d05c63e5fmr13925967edb.41.1674153986480; Thu, 19 Jan 2023 10:46:26 -0800 (PST) Received: from pc636 (host-90-235-24-47.mobileonline.telia.com. [90.235.24.47]) by smtp.gmail.com with ESMTPSA id s5-20020a170906c30500b008552bc8399dsm12870217ejz.172.2023.01.19.10.46.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 10:46:26 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 19 Jan 2023 19:46:24 +0100 To: Christoph Hellwig Cc: Andrew Morton , Uladzislau Rezki , linux-mm@kvack.org Subject: Re: [PATCH 01/10] vmalloc: reject vmap with VM_FLUSH_RESET_PERMS Message-ID: References: <20230119100226.789506-1-hch@lst.de> <20230119100226.789506-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230119100226.789506-2-hch@lst.de> X-Stat-Signature: pgthihabtg7y6kw4cmi4k83433mhsswo X-Rspam-User: X-Rspamd-Queue-Id: E274C40015 X-Rspamd-Server: rspam06 X-HE-Tag: 1674153987-418817 X-HE-Meta: U2FsdGVkX1+LUr+BuAFXvMXnNqXylPpuammh9o7WXWk3jH1/7x0bCIPyuXOc18AVKVfFbutfAdq+T8u4XQlF3cV7A31bzHPFzKpx4D4pOXKCwVtESbsPBXYe+24drqlPfJQnLcC9FYHUG04TEYKLtezs5GOfYrMoFRA+qWvdi3FGoeb+YBZFgq6NwDxeKhfST+0fz9EyfnPNxpuWLDEzmbUNQFK849MrZYpBv+9fkCnDLpLaFHfqA7lF11pa+Y5lzKvGiTpu0j3rJq2Q7FijZFcqaKWrVjrAzxSKKwhkGQcWVORCX6Sbk+PdNcbMtK4AQsyk4w+i/jGigZBM/+hUu3xUzFjGEuUcYxXz4L8KquEoBJvzM8BeVMzzeqj6Gqt+IXVtZHEZYxgbxWQWy8vY3L/dxd76UI1UeMGJyQuh56Qor+X7LTj+cfW8vln0+6V0rT+dW/zn+z+OVPc0Rwj7A4JM+eTh4L+5ppMhZM9z2aOvGoM8wx90DR43UJMx99oImCMqSNYvcoVShBxF0LKLaQSaGQGXnE4a4FuPSUiFqBGs16xC6MdTvpvzj4CHwBJoQwLq7fEqUMziDTvsO9Zh+8T3Dxn6mPQDdIvUKxwaN587W9iQlbpI52TIAHZ8oYOUjBsNaCYJ8aYl2G2exXZ5XYr98LhzKX7fLV3GJ21syg9xLoreJEvmyDq318FzT6n9dnr7JyZme046uq+2Bqwsg8xKIiPRhaMDYbcYkBe+MI4oMzr/1TuWWW7anyBlsiSX/h7St6ys9Q3kW0hZ9Na66hrh98GdCo/tvG2Bj561iJWH9ZDzg4E+YQPmSSXwHllXBu7FqAu8VwYL0vHnUSxGK9wThtF5GDDhLXZm/AW45X/kdU9my5V9aKUko8kEIR3KFECThDajOLdt1hlGC14AJ5xuO74rI8GF6Ss5Y6AqwHzVM+N7wY4VJtLqAJat+shFDneh3bG/HYFr6Ws1a4V jUBF84n8 sw5Yzh38JAdgDMc5iPMnr7Dvs4rW5rWEyW1xRH896R5ig6o9usqzlxHacsOPdz+pI+GyDIVGD8hltKb5iMptgKg/BmcZB8vCjswB2yTzLoov1Fqdui/qiZIGi7U2DUJF0TDzIHdqVT9Bqwm0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 19, 2023 at 11:02:17AM +0100, Christoph Hellwig wrote: > VM_FLUSH_RESET_PERMS is just for use with vmalloc as it is tied to freeing > the underlying pages. > > Signed-off-by: Christoph Hellwig > --- > mm/vmalloc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 0781c5a8e0e73d..6957d15d526e46 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2883,6 +2883,9 @@ void *vmap(struct page **pages, unsigned int count, > > might_sleep(); > > + if (WARN_ON_ONCE(flags & VM_FLUSH_RESET_PERMS)) > + return NULL; > + > /* > * Your top guard is someone else's bottom guard. Not having a top > * guard compromises someone else's mappings too. > -- > 2.39.0 > Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki