From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BBE0C6379F for ; Thu, 19 Jan 2023 21:15:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE6126B0082; Thu, 19 Jan 2023 16:15:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B49206B0083; Thu, 19 Jan 2023 16:15:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E92D6B0085; Thu, 19 Jan 2023 16:15:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 808E56B0082 for ; Thu, 19 Jan 2023 16:15:42 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 59C8CA078D for ; Thu, 19 Jan 2023 21:15:42 +0000 (UTC) X-FDA: 80372805324.22.885D577 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by imf30.hostedemail.com (Postfix) with ESMTP id 7449680012 for ; Thu, 19 Jan 2023 21:15:40 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Al9hymxX; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf30.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674162940; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dn0RxgJYP1pitjWvcBOPBfKv5qYbiPXZSo6iw3wnry0=; b=x09z9CTfoZfPF6/9w4sOHEpNHP+nttccb08cu2EWu1KeDw2CpqbnC/ToqM30lk0YxPXPzQ SPqp+0SccxbWXijrHIJHGx/AQNMP74TJJkLFq+8Pg2dea614P55R7yYCv2D2buzaJwer+s uCpfTSVHyT6WTYKvn13B8VKe4zzGTF0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Al9hymxX; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf30.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674162940; a=rsa-sha256; cv=none; b=Y1HxZ3jJRLdqpYfmCF+mg+zT2rTaE7g7xg0vywek/lFj/l+eBqcAjsS3TR9cGqTQYLLL2M nxP0xZJ39k+nQeG/y6RnkiUejo4QDUdonH60zM07yr/vdr7KhdKq3/elCdafdHF0eAmzyH 4ooFHXgwgiPyY2Ld0jwDzhoICRS123c= Received: by mail-pg1-f169.google.com with SMTP id r18so2584816pgr.12 for ; Thu, 19 Jan 2023 13:15:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=dn0RxgJYP1pitjWvcBOPBfKv5qYbiPXZSo6iw3wnry0=; b=Al9hymxXhxF7ur0o9zHC14v0xsnNor6d5ON4fVWgTZLVzNEtoxRSShdRLBC3FKTOce HH0NgP5wRufWSrV3BOXwT3yt0hWiSLHUa6qfWpPzBKjtMR5L/6IqP56KvnTME/DqZsny R1YMRlfP6OPHytgUr9vkhK/4z68D30VpVjn/lwXFSm4565vGF7STbBi2K2hZiMH+MCqc qniJkF+npnPnjO9GuBDlejCeCSk7S5gtt4nhrv/Wy2RyXcOabkTKYJ7B41qSHtg+L+Fg 7PMCv9PJxkzDOM4o+0HfOsLgCmc/aNzTxIBSqdU0ty6o8xTbm8GGUuRglcYR8RuhmhfQ T+Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dn0RxgJYP1pitjWvcBOPBfKv5qYbiPXZSo6iw3wnry0=; b=kXGT3wUT29UZJCoqyXg0Ved1KlCj6TQe3cKb8+MR1JdBWgLrP0FFYfkzTqtqZ6EVGJ sbh5wxp70ap04c6MmwkmoiSlut+f67P4xV5130bj5UKWaQLGY22R9bSE4oo3hS7/EZef YOvwIrPe1TIuE/3Ttx01WGqxw85ERsmSczr91mkKlenoIilUPoxsIjPhdAqS4S5LBp0S 0PoVg1pqZ6Yk1/cjro2quLmtrUcPLdeaPQamhEbl56XV6bK4HgGh9RQ3+ZhRzbZmGVoX WH1WCjQyS21KAIia00ByRVjIQJVmZ5PlECS5Hn145J5dGe0qgFCN/seQ1YfTMvr+PUVO SQ7A== X-Gm-Message-State: AFqh2koMvuLLdrrtoBsfYpIXERpi658jnmPSdZRjQA4ajM7ydAVR5duK o05OF7e1xXeroWIouj2upK0= X-Google-Smtp-Source: AMrXdXt4aSGxahYuSSuEq0wJQiJOWsmN0KqhITVx1Srh/6G99K5C5pnC5Mn7h6YWcXiC2nY1LQnNUQ== X-Received: by 2002:aa7:8084:0:b0:58d:e0ee:ede7 with SMTP id v4-20020aa78084000000b0058de0eeede7mr8269731pff.14.1674162939326; Thu, 19 Jan 2023 13:15:39 -0800 (PST) Received: from google.com ([2620:15c:211:201:3bcd:b3d1:c859:f6e2]) by smtp.gmail.com with ESMTPSA id f127-20020a623885000000b00588cb819473sm20129473pfa.39.2023.01.19.13.15.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 13:15:38 -0800 (PST) Date: Thu, 19 Jan 2023 13:15:36 -0800 From: Minchan Kim To: Michal Hocko Cc: Andrew Morton , Suren Baghdasaryan , Matthew Wilcox , linux-mm , LKML , SeongJae Park Subject: Re: [PATCH 1/3] mm: return the number of pages successfully paged out Message-ID: References: <20230117231632.2734737-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 7449680012 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: x1fcwowm4ds37ujm5zam8jzoi9dmpqxi X-HE-Tag: 1674162940-668338 X-HE-Meta: U2FsdGVkX18U9tTr9xuEAqDa/LnKGB1kEjd68uKE/joR/laV9/cFdS0EfZZM17SbprMiLpoR3gEyjB/Ib8ZndMu7Lhmzdfm1558RkvYu5cvBpkPAMPzTw5kOW/suIAVMz08bBRprhfjbvoJ5IE8HSui83Pm8to3JwChlnSPaG7NhbZ/z3R3IHdjXWsc27JOlZ4MsHIddKgU1XejFjkxSRIG1OE1wP0WZnp7jegftXcIJGbuo/MVMaW3n3Kbf0BvYCWrRG2jrdA2wgcpr2hAFDfCEo/aW9WPtRoi0pZhbe90EZMqI5cPvVHwxrT4Fyd7wfHsxdhvOWPMv2IZY9+zmDc6g+vtGazoAaTvUt/pl3oBJfC0jV0jrPhvff88gwQ60zXRln4+2jbiU0AzwZJ9EUPRfuxvFxV9OJN9ICZXyaDB5Qb0cFqY0YQmD41/NbGxObj7fy8/azhEdtaFvNHMTOklPB3xWcWLREqqujIhy2hnjypt+k8u3qUI23Wnc7wH64WDeYuTGx5vJQwQJMuaRAheFrsMKAr4UsqfJYfAyemh1hMJVALn7/VwFY8iRD7QtgpGAtjvq47Is59DML62bmj9aXBFZso8oV67pHlDtSk2qwisC7ELvtCDbNfN8ByBhBAQD3T4SgSyDwABiUCyX3oJ5YuUHUsDNPKzIjPgeJ9tnSyCm0VpeO6xDBQxA68dkS1WdbvPCKFAI/r2PWrxEdXIAiEdC5TtAabNwwejGn2zy6hdVHwyApRQ6mBXQZXJzXrZHscCLawqwh9EKWn1hobp8wFKiZOBl4Uq9vVTTOiYyj/6kdlXf8PtSgRHoRRNanX47mmqpnnPaeuTluUUstAWrkiTS6J7SQvdtQPMn3fGuw1JL3jnTZ9gUcNJWCwPdKWmkh6xeROF3aurB07LcldXW7OCZhNban+KmAlvIWG/CFDhQ6fJD02qFbvKJULsekD8aO4sap2StPxSgO0l x/M8jjRg BoR9Bg8dJUFYC0BSqy6DG+9ZO+Q2h5QUEY8Xc/bxmWU3nrL4jLiBQUgmXsMKcN2/y0SFYNhbslf2D3IYzmcsndrCqR+NdhbiMny6qQPjhakvME2Zw9R37dYbF7sd1NAMi0Y2ob/Jnx/TE6OWnBizhT1nA0MscB8ahI+0pf+blkC1DNYt+gAwB/lZ/aaxvHbwt1K1miZq63eegTXCRq/igDGHYIfxH3f1GHReHufP9iJrPngYuJgA/lwW1iBeRTcfzHVaW8ua4fREcbJz6B1MQ+Ont2jheQ2XYV42QP9XFXbqSD7wO5fNIKcm6YJVTbxj6Mj/L49eISahJGvcBnMbCi3UgKti6H6HtmdEN08euZl47Ytber2ohnpq9mRG7YZta5CYAVyK2AGd5dgBUu70TbvoX7EgIu3AfmygWgmhJWpfl4wK9kZNGH/9OqyIwIvU5nVy1GcPAUmUA3Glgwm0CnDThx+KDUv+9aIPeLlJvLUajGfuyua/j0R+fhrNy6zUT8K64tGknbwzWdaQQXNkmYY+0TZE9CIUmkTEXgVGJOVcHWyg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 19, 2023 at 10:07:23AM +0100, Michal Hocko wrote: > On Wed 18-01-23 14:27:23, Minchan Kim wrote: > [...] > > Let me know if you have other concern or suggestion. > > I would propose to use a tracepoint to track this on the madvise side. > This way you can both track a per-process effectivity as well a madvise > originator effectivity (if the policy is implemented by a global monitor > then it won't get interfering activity by other users of this > interface). Global counters cannot do neither of that. I don't think the tracepoint is right approach for the purpose. I understand we could get the same result using tracepoint using bpf or something so whenever event happens, a daemon get the result and accumlate the number so totally same result with global stat. Yeah, technically it's doable. With the claim, there is nothing we can do with tracpoint. Checks existing vmstat fields, why do we have them into vmstat instead of tracepoint? TP is much easiler/fleixible but with vmstat, we can get the ballpark under fleet easier to sense what's going on simply, and once we found something weird, we could turn on the trace to know the detail and TP would work for it. With process control using process_madvise in centralized controlled system, I think those two stats are really worth along with other memory reclaim statistics to be captured for memory health. If we have needs per-process level tracking(Actually, not for our case), we could add the tracepoint later.