From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC768C46467 for ; Fri, 20 Jan 2023 05:48:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A1F86B0074; Fri, 20 Jan 2023 00:48:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 052026B0075; Fri, 20 Jan 2023 00:48:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E82B96B0078; Fri, 20 Jan 2023 00:48:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DCF0F6B0074 for ; Fri, 20 Jan 2023 00:48:43 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 98D791A0E5C for ; Fri, 20 Jan 2023 05:48:43 +0000 (UTC) X-FDA: 80374098126.19.744027B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id EB3D2C000A for ; Fri, 20 Jan 2023 05:48:40 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZScI6oZl; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674193721; a=rsa-sha256; cv=none; b=cUNoM2uWRxPdnIp1Yu8n/xucmugRHNvxHfDKzi9dfnKLZhWCvtF780Jk0cwe4U4Ej0Qdsp yMhvIh7LWq9YtyTE7Ve45Myja7yUJV14kDtL7Hw8XHLqq13JxWBUwdlFfgBoGaXPB5mcV7 J9Mgxv8DMgEFMnE5hLAILDSJBTIH6iU= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZScI6oZl; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674193721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HRjwOCVzwM/JW0nRSbGXBKRTYmFcFNAcwf5tRy6Wjq8=; b=1KSapyPK9deXot+rBITJboQlHdNPDedJmSESkCyzC0hKgNNCP+gE8Oy3T4z16qSClqFlJf OSogOBwscALwwt7iqYRtyc3ljsecWFJGlopIrLbmaJ0t9kmtiIcRThuAOcUXfRmWjVGDkI IrBuYt8U80IkR4T7zZq6Fgu2UfzCpvM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HRjwOCVzwM/JW0nRSbGXBKRTYmFcFNAcwf5tRy6Wjq8=; b=ZScI6oZlQ7OMuf2sCUd8I7tW18 LTf13QwNry53D3aVeuvTAMDXP20zG98bna3DYZQKwZhKRBxPGFDj3n5oIMBVqKkqOexJKfedtrfMT RwJ6T3l9A40J7bzI3nh/rkWXqu5QkqJb9jAGPWnOFRvxVWZXfBKMk1QS0AqJchv5WQstfd30k2jSL hQMW2QSwVSC3vHWERzQP2qyIHaccG4KPimx4Qq1R2/dBv4JZdb3LT17Oc3sLFg3EnE0XYx/5Zd3SA QjBZLV76VGJy4VATUcQiun3SY9grv09T50xsz9/zou0N3h6YY2wGcVqRngqHBPD7qGB5fsGBXELzl 3lq72dvA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIkGQ-001hrA-Na; Fri, 20 Jan 2023 05:48:35 +0000 Date: Fri, 20 Jan 2023 05:48:34 +0000 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, songmuchun@bytedance.com, mike.kravetz@oracle.com, jhubbard@nvidia.com Subject: Re: [PATCH 3/9] mm/hugetlb: convert putback_active_hugepage to take in a folio Message-ID: References: <20230119211446.54165-1-sidhartha.kumar@oracle.com> <20230119211446.54165-4-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230119211446.54165-4-sidhartha.kumar@oracle.com> X-Rspam-User: X-Rspamd-Queue-Id: EB3D2C000A X-Rspamd-Server: rspam01 X-Stat-Signature: kkb6741dk8otws115q3gtwtrzw9nx7p5 X-HE-Tag: 1674193720-227307 X-HE-Meta: U2FsdGVkX1+DxclzmKInUGmU8r0j/NqxTxjW3oUm3XUaEYuCkGiJe6YvPk274vi30fmj5AlZo326bpltRF7LilKY1hCA7BVYifGkSuNtx7pjFGycAvRYgJTEy6iLm7t3tL3nOF0fa3bCnEHxXIakvJLXwbXS27YIxtyIBDD8oUY1ChfCeYm77RrmstSn5z5tPcvUx4urAixevHVdZS50cGT0YYqDwJUgbc8CKFP32DCKgP0+rZYjwuYYv5Yxf+t9Y3En1C7vCKxjnLQcGvQ2/vW/qtD7oKTvqMsX0H5wuh9ak7BoaU2+lkaQCO5FhjmtDB8g15wWBQp0y1clKAlBIdi6aKhPOorQ3zQhKEpUDaUahe2N1DbT+rcFZpFI9pNGaeqQhQjGd/2h+KD/xLs18GxioNc5Ye69Q6un+0eJ0Y8YfYz8u+h0hd706LBAO/hP4Gvt9+VEayyP5/PZNqNuCfvvOhHPPtUAJDGo98n58BSHvPahR9g31dcXfBn2hVjpMLEOqNTUHWTB8mGzAusaA0or9+lmiT+ELbBxYQ8M0FAmRKY4bkZj5hrNHryhs9evUyFmbEeh8/kI1M//asDw7KaEv0Ubz+Ix/3KI6S9UUUGOu4UKygwLnPyyDDAuzXIPD3urgMMbcM1QuMJ9csNBa7l8iWUFyOtE4P3lPNJicLIgPuJVb9D/ipvjn+eI98S/iCIKiQ1kjEyQpbDxeKTLayjiDo6dLiMvrzib6HuyOYbMB4Kc2QIXf2t63QqkO6WYNbOQfFi+mSpzN3kIe7xUJ/s9uZV1ExfTMS4YZ+J+wKX2TcRj/GFkgnN32JZgUXoKcbGAeKaKyC419Mx8sjI8yhnK/EtoEPU5FTg+xWySkPK6AxslpZgCh1QaVu6QEzTaeDy1Pj4YMsMYS/iXYxgkjZ6OKpLR4NuSBcd9rSwnNs5ZgAGjVGeD1HrCU/W7nyOfW9UKkWxx36jj8AfzhNM UhldVMMe ezVwsnva3XdVGgYwv6yfDd/3d3Wvy7St9KQKONGuUXCZ2arM9ze6yQs3iNaWa1bSlt8bmTz/mBYOdMcBJF0n7fSQUpS3B1UWFfhWnWG+4CZP9kxoESuC5UK7LRXruag3VFppFLDZBwc0bmxQR2X5qbC+dJb3dOhchrBI3rhLrOxbhcPhWu1BezncisoaVKUx9Dr/NFHRsIoLPqT8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 19, 2023 at 01:14:40PM -0800, Sidhartha Kumar wrote: > -void putback_active_hugepage(struct page *page) > +void putback_active_hugetlb_folio(struct folio *folio) Maybe call this folio_putback_active_hugetlb()? It fits better with folio_putback_lru(). > +++ b/mm/migrate.c > @@ -151,7 +151,7 @@ void putback_movable_pages(struct list_head *l) > > list_for_each_entry_safe(page, page2, l, lru) { > if (unlikely(PageHuge(page))) { > - putback_active_hugepage(page); > + putback_active_hugetlb_folio(page_folio(page)); > continue; > } > list_del(&page->lru); Maybe we need a patch first to convert this loop from an iteration of page->lru to folio->lru to avoid that call to page_folio()?