From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A238EC05027 for ; Fri, 20 Jan 2023 11:33:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2854A6B0073; Fri, 20 Jan 2023 06:33:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 235F46B0074; Fri, 20 Jan 2023 06:33:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FDEC6B0075; Fri, 20 Jan 2023 06:33:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 029146B0073 for ; Fri, 20 Jan 2023 06:33:04 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C265D80D22 for ; Fri, 20 Jan 2023 11:33:03 +0000 (UTC) X-FDA: 80374965846.02.CE9472F Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf10.hostedemail.com (Postfix) with ESMTP id E7438C0014 for ; Fri, 20 Jan 2023 11:33:01 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=n5Ez43U4; spf=pass (imf10.hostedemail.com: domain of urezki@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674214382; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FdohBDhp5Ux+V0+O9kXc9YfPjzKlt/LMwO2xr/IA+o0=; b=Z809ly9Yt5bwTpXdeXvd9u5dxalK1Fpe6Tbd7+8rDyhQqups5Ve4s41NYRkII08pgF9h3l f8PephYVkDJLEAsQuhsGmhlxZL5rb9OosIzEA3CnPduYTBAUPdqzfT76yxtrhfcNv5S8IC iWf035nfwvfyK4hCDAjlpV9wvoW0D1U= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=n5Ez43U4; spf=pass (imf10.hostedemail.com: domain of urezki@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674214382; a=rsa-sha256; cv=none; b=qcUHGK1hqXYb1PvjpRgEH5/0k4MzbwIvwONUtVW4wJzMgDJuP7eRUJyCB4V7Dg+wr5yGUu Mhskhz1Mrgh8fXGvkdqCS2y+GoZFIGXUA2SzDyD3zmfGem2NyR3Kvn72n5g0dFOEpG9qHU sJqEpOsF6eBnqPppyqM8nBuED0gYfD0= Received: by mail-ej1-f52.google.com with SMTP id vw16so13129179ejc.12 for ; Fri, 20 Jan 2023 03:33:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=FdohBDhp5Ux+V0+O9kXc9YfPjzKlt/LMwO2xr/IA+o0=; b=n5Ez43U4X/nEfEY/Ie46QzIAWk34Ttpl1kXtkhHBQxLUzFaTfQdTksNFd68+mfA7jm ZuFbtBoMoBjrYbt0QSxdG6I7PDmWp91ip/CL/doc2t4VN1YM0g8UGv/7v9RR5x/MrvHV iWJ3ilZUiZL+/9K1ghk/eNyyy2EPYpcvlkfVm+iC490z3bJMrTelmjsE6kfgxduRvi53 BiIScgMk7SUbWc/ts8EMrSE/w1x5mq6+NxeEGtaGYFNIfLBnBoeqCJN96Z2l+mw5aI44 JEAu2vWM8pPgJbfbxW8n54kyvdw79uTyFvFBqMC+mNwu/JnYfH6nUMiwAzlXqMHHxiA1 7bjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FdohBDhp5Ux+V0+O9kXc9YfPjzKlt/LMwO2xr/IA+o0=; b=zDUi2hJz8dgkyXBiowNi1FKENCKtMYFEQIhTNDkdFygg/tYINSR0o542N2TpI6vg52 H0GiejGCrn/puOpKYbynCKJCUad1T14OlyrTwpyvZFciOROjPlIR0KB95+O9Wkcg8dp7 UYzFVWsZw3G0w6gt67Rczw636ZsRkNLV7KHvw90Vn3E4aj6ZWqh9aW4UbJ2QyeRaw4bY ovwRUAtPuzDwJx/+6KM6ZH6ZgMYmLOnW2FIYtJFsOLcvkNsZYgw1/gKPQ/xWsGWftk5V U4MuwrE0HAvh4Vxr7kjMkkwa7nXPl9TNjh7IE9pFyzUbcAqYEoqOeo+HiXnCh7Xrzo6i 3VjA== X-Gm-Message-State: AFqh2kqnR49WRyRltg8TAZ4s2dGziB4+0tb0lV8qv9DqcJ4NigAuSP/+ rHG5EVL7K3yO78YN3Zf4X2s= X-Google-Smtp-Source: AMrXdXtiETAEBI30SlvQWJsiop5H/Z2lmECCpSqvbr8eNy13FkLwLma1WdY/2fruPznQXoRhZODLCA== X-Received: by 2002:a17:906:7f18:b0:877:77f5:a8e1 with SMTP id d24-20020a1709067f1800b0087777f5a8e1mr5484255ejr.35.1674214380516; Fri, 20 Jan 2023 03:33:00 -0800 (PST) Received: from pc636 (host-90-235-24-47.mobileonline.telia.com. [90.235.24.47]) by smtp.gmail.com with ESMTPSA id g22-20020a170906595600b0087221268e49sm5938898ejr.186.2023.01.20.03.32.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jan 2023 03:33:00 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 20 Jan 2023 12:32:57 +0100 To: Christoph Hellwig Cc: Uladzislau Rezki , Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH 09/10] mm: split __vunmap Message-ID: References: <20230119100226.789506-1-hch@lst.de> <20230119100226.789506-10-hch@lst.de> <20230120074217.GB26815@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230120074217.GB26815@lst.de> X-Stat-Signature: yebmoqdntm13qwkpjofbdzteiitmogwr X-Rspam-User: X-Rspamd-Queue-Id: E7438C0014 X-Rspamd-Server: rspam06 X-HE-Tag: 1674214381-505018 X-HE-Meta: U2FsdGVkX1+Sy/CQYYqueBzWc49pwgOPa74D+AlWxvnrwuNJXqvavys2iaY0jKAwSzcZ99QTELvMgKO/kicLsqLOABqrL9TLvo88NISuDQzgerybwN3XcetOe9y+f0rARXUT2fkkD2dr3ranTWdgSmVHyngUp/JKD24nTlTMyFKdK8zz7BwI55mWWj/HO/I0rrRwRxRc35mcxLWOSx5+kuJIJ4XhPJ2nNt0ll7go2+5eR1ieqzAfMAqQxJSWkJSBJZs3g1xg7+dFZ74PsIIU17IhCjbuSVbFmUmFdK1qRqg9wm3ZHKea5d9eG7yTtnvpNDjnu/Ekaz6LE5cupEvCXbZchjpNCLiDhm0wfGGNXynXMOi+tVWV+qYmOLzRJu7ZzPScFHGwZglUTZri++BmNzcu2+5OBATrlnV/Uga9TnhbpkRKPYwK1V+wHeCi/RfJnxT3wPvdHcM9QSXuxYQVeBS6QugNy0f5kKFhVA9S3JqmAIK+wJ3JXKSPY3/3eJS4/PCiQo6RsHT0yz+GGCVVOQfbW4euNkMMOxuangYOkILF8l3QVURuI0gjOBi5Nykehpc7tC6YW6fr+UoFfILFq7kawr8yPRVCoWE5JjiX2ud52Zxrhql0pRuR0vhMNMtFowS1NBZVOIz2y8RfgRvLXkXSJ+hMhnhvPx/Nkk6QWBPs6nxC2FMcZcAWNHPc3fdLEaxR70RaIxHYUFngm73x7fpf3UjORbX6IzF29GcqQJHU3ojTO1gx7wRjCRy2JRVlf+bo2kZOfOoR5YtI0xESAiPLchwGl+W0pkib+hS1jyye7WE0W/COz5atrTQ+9iTfOiYYWYpOLetX/pT/Y0QRBYy6wGNsUnzSiKJodcreBDHcqc6vAbKhlvWqY7pucZiDuI2wlOBOdSdUGR//9vPaj3RydaNahID9W58KeghSssAjcSUpk5YGaGR4Rq3bK5+nx5OA6XWKuhgA8Bgg3rK yN7OYpm4 3R+Hv4wWjFpqjrtbvg+6/LakDn5PS3zlGdj2jmxPdMopHFqfGDkCmHKwSDd/kTp+HZdCDxb22jbJZv6vl3UnpytWO+86+PssiF8NEpATDTz9FPwwniLkfs5+z07MOIGo2gCQiIxqTqfD3U5SaxuQQgZ3JYqrskXRQEhACGd8PYWNHZwIMVk45rGwTZ9zXEYh72RnEB6ClTraOAB5+gKan9yMSPyIgY5IYWqtLPQ34kOXt1xmsoONVHfqFu1Av1pSG+7iMsMlpseQEp/N8+IIFIaGPEWs3kiSANH7CefacFq6CRP2ECi5FXAc4ByAbTcrw/9mtgzW7XVdXMkPm21WlMnMIZmTkLmeSNdPDO7rruIHXUgfwQwgtRyiF8aRm4S0yoT8sYwRlJsQjE7EppOjnKAC1A2E+libhFQeHLva+jPwX3hVy/e+V4jFiI+0CkSlaNm4BFld3yz1ng/xoP/BqCnWGIAtCxp7Aq+rTMcr3tbchhes= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 20, 2023 at 08:42:17AM +0100, Christoph Hellwig wrote: > On Thu, Jan 19, 2023 at 07:50:09PM +0100, Uladzislau Rezki wrote: > > After this patch same check in the end of the vunmap() becomes odd > > because we fail a vmap() call on its entry if VM_FLUSH_RESET_PERMS > > flag is set. See the [1] patch in this series. > > > > Is there any reason for such duplication? > > Mostly just documentation for me to explain why no flushing is needed. > But I can drop it. > Thanks. -- Uladzislau Rezki