From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4480CC05027 for ; Fri, 20 Jan 2023 14:29:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD7C46B0071; Fri, 20 Jan 2023 09:29:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C87976B0075; Fri, 20 Jan 2023 09:29:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B285C6B0078; Fri, 20 Jan 2023 09:29:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A335F6B0071 for ; Fri, 20 Jan 2023 09:29:44 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0105CA9104 for ; Fri, 20 Jan 2023 14:29:43 +0000 (UTC) X-FDA: 80375411088.14.2EF50DD Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf04.hostedemail.com (Postfix) with ESMTP id 24CCA4001B for ; Fri, 20 Jan 2023 14:29:41 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=NTHbstKf; dmarc=pass (policy=quarantine) header.from=zx2c4.com; spf=pass (imf04.hostedemail.com: domain of "SRS0=0Vli=5R=zx2c4.com=Jason@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=0Vli=5R=zx2c4.com=Jason@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674224982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F9kOqvxWdJiZ6o7rLV7rek2JVGrJsZXSaK0nvleVzCA=; b=G96ILRwceZnJjVK19Ebqblx3129Bjxo+b6Bb+VQZLVAlx0VLpQiktdSnjYievk1EwACmRq R+lHOPWlfzyJehZMZY1YRErfE+ws51yKT4Q/ixjn6guj7CXDv0+O5CHbOEi/gOKH77O1yn iOZ+Wdq78XpKiIvwvzrldmk0uUyCT1M= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=NTHbstKf; dmarc=pass (policy=quarantine) header.from=zx2c4.com; spf=pass (imf04.hostedemail.com: domain of "SRS0=0Vli=5R=zx2c4.com=Jason@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=0Vli=5R=zx2c4.com=Jason@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674224982; a=rsa-sha256; cv=none; b=VHuQ/lPeBEsEU1LfG18/Eh/neexw04QT+72ii/qqdHbBcuAV+G1Pvr8J6x8fHinr+G6VZ5 +hdPF+MQEfIqVySahtPljQ5b0oOxBJ6yz9Rl19Zvgvx4oiT8NgSnc4KsBHdVoSd7I3Ap4x NQiqTzF/AGUM4pNuhqqLrLO2CYmOBYQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 94904B827E7; Fri, 20 Jan 2023 14:29:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 237E9C4339B; Fri, 20 Jan 2023 14:29:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1674224971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F9kOqvxWdJiZ6o7rLV7rek2JVGrJsZXSaK0nvleVzCA=; b=NTHbstKfPp3u89snVVs+oFRiOmLj7/9+v4hS84e1+clIoPhsJ2kSbFe1y7Ve3fpUvfhDFY RBcamZ38ta96TPzy+pU4lTKfZ8wbvpW/izzz3c6W+tHXCN5ZL8y0SX+AqrocY7EgB2oo7F 1Nc0qLsaQSetYUtiIFFpE6YtUNUcr48= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id c179fd18 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 20 Jan 2023 14:29:31 +0000 (UTC) Date: Fri, 20 Jan 2023 15:29:14 +0100 From: "Jason A. Donenfeld" To: Yann Sionneau Cc: Arnd Bergmann , Jonathan Corbet , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Will Deacon , Peter Zijlstra , Boqun Feng , Mark Rutland , Eric Biederman , Kees Cook , Oleg Nesterov , Ingo Molnar , Waiman Long , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Paul Moore , Eric Paris , Christian Brauner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jules Maselbas , Guillaume Thouvenin , Clement Leger , Vincent Chardon , Marc =?utf-8?B?UG91bGhpw6hz?= , Julian Vetter , Samuel Jones , Ashley Lesdalons , Thomas Costis , Marius Gligor , Jonathan Borne , Julien Villette , Luc Michel , Louis Morhet , Julien Hascoet , Jean-Christophe Pince , Guillaume Missonnier , Alex Michon , Huacai Chen , WANG Xuerui , Shaokun Zhang , John Garry , Guangbin Huang , Bharat Bhushan , Bibo Mao , Atish Patra , Qi Liu , Jiaxun Yang , Catalin Marinas , Mark Brown , Janosch Frank , Alexey Dobriyan , Benjamin Mugnier , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-audit@redhat.com, linux-riscv@lists.infradead.org, bpf@vger.kernel.org Subject: Re: [RFC PATCH v2 12/31] kvx: Add other common headers Message-ID: References: <20230120141002.2442-1-ysionneau@kalray.eu> <20230120141002.2442-13-ysionneau@kalray.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230120141002.2442-13-ysionneau@kalray.eu> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 24CCA4001B X-Stat-Signature: dnbbb6w8ezwwqkra4rdwn897u7h4q5qp X-HE-Tag: 1674224981-856747 X-HE-Meta: U2FsdGVkX1+Vn65krpKsvgnaXgEfIWZ3T3XA9gcXRWgeNLU5+KUlTwIiTTBuX3mR1sog+IOlODRiw3+DDw9ZnTRcxDN5uITAfW3pJ4gwfV2xwD+gyMnHsVcFUufNWmAMoCDn6XV17gxy66vPOpcIy5saHpv31iSpvJI7xBhrzRjLXkhOToQgn01AF5JuR8NDA09ntLAZ16FKy12MmW1UuR0wu/3KELnzIyNQOg+jMRyYO98uAW2CTNjc9brPNTtA9VOwvx5t9OCLA5a9Lspg73jMwc4D16+A1inIwqznFR0UZx2WASMPYD8EnD/oD0S+V6l22m5s9+M4OnpK2owjXKwomUQOUsevLSSdschOIJPmr2Yy/cd/5BondMpo/R9/KFDLZ41FRbQvGq7cefuNWyWTDo9fRVHzXWXmYG+ssAT/j5XBU3ff9RiBkXeo0zya3WQ2C0ozUaME7p0Qx1JDsalRJRnXyNsEmNr2M2N4hE505C5XhK+FxSYhelGQMaHsyCmaj4xm8qM6mkM9uiU8yzf3giMtfMVLnmTTwgjjPyNguMkrKRudIEV8orem6zqp8hsqxkJM87ilPB4yI0gAQuTevNIdMdW5Ci6KOv13lnqHJGyVYK65iaMNAFn4dRYMLVC7y3Gftx7mYFQLnIYbKdmNldgUD1+pBYpQYIfHHExZsF3r4c4yTDNU2fN7xZ/Oz4hZmhS6fokOs9nTlZj54yfaOaIQ9zJ1Ik2TXVAiLpIs7HP/sh2uueFN2OybA1CGV8o7nJnspnkvjRcO3u55VhPqsnlzR69uNXMye/aXNzmtCRfBgZ5R9QFfAHg0d/yjKWGEP12M62VHXzR9CwsFYYT3WCK1iYc4HufWr2GHSgztHh73WCScOLnffLoavTf+eDxPWLMUa0tJ83RvW/1m413Aw+cd29/19sZDEojtVVBixifag57N75sh2qI9Bq67QCIthCafpuHM7J7q1E+ eToI3xLE MN8GzB1B9HFlwKui6W5x0eXiOP3gCWlpSpVB26hwuqH4seVdsmVcQD7KjkvMJ+zZSCLvcPRkQ6XglCL3Kz7gMS3TK4RrHowrz6rU5VjDTeRd5vZ4PEfOy8UUuNvXGxSsznLRAh03EuviWdITmYaqOEaZabZArSLdL7I/MfYmDE8zngrvpLFZNSVdGDhDYzwpPVWE3nL5Gw45cH6VH1jWCnVpp7Wzr+ekU+2/7ckXNzn5MReHxuxY1gqRo1fYjmLxMLY2G1CZVxzwhmk2Xkaedri6TA3xgS5/pJVbSVJNMoX74zUrOsXDRxCitFunbc1E9otOUWV0Tp3baIrxJLKdwJpZqXx8SFL+c8w0Gulg3g5A2Ro485tugnW+cJbIu1kaS4GHHwuWnh7pT7X2WoTqqOLzNcxMxHo0+peIzAbayAiQnEmG5PSbPByVM7HoV74hjVNEptko15DdSKz7VBt0ehV+cC1ggd9EfRU8/nsjxUukHOgvZYvnEr4x0Xx5ad5ACKUBPRld3ldYN1MYSUFnrJptRGvE9+Zjr6gWijZM1zM31bzH91Md09UFHpg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Yann, On Fri, Jan 20, 2023 at 03:09:43PM +0100, Yann Sionneau wrote: > +#include > +#include > + > +extern unsigned long __stack_chk_guard; > + > +/* > + * Initialize the stackprotector canary value. > + * > + * NOTE: this must only be called from functions that never return, > + * and it must always be inlined. > + */ > +static __always_inline void boot_init_stack_canary(void) > +{ > + unsigned long canary; > + > + /* Try to get a semi random initial value. */ > + get_random_bytes(&canary, sizeof(canary)); > + canary ^= LINUX_VERSION_CODE; > + canary &= CANARY_MASK; > + > + current->stack_canary = canary; > + __stack_chk_guard = current->stack_canary; > +} You should rewrite this as: current->stack_canary = get_random_canary(); __stack_chk_guard = current->stack_canary; which is what the other archs all now do. (They didn't used to, and this looks like it's simply based on older code.) > +#define get_cycles get_cycles > + > +#include > +#include > + > +static inline cycles_t get_cycles(void) > +{ > + return kvx_sfr_get(PM0); > +} Glad to see this CPU has a cycle counter. Out of curiosity, what is its resolution? Also, related, does this CPU happen to have a "RDRAND"-like instruction? (I don't know anything about kvx or even what it is.) Jason