From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EE32C05027 for ; Fri, 20 Jan 2023 14:48:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B91596B0075; Fri, 20 Jan 2023 09:48:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B412C6B0078; Fri, 20 Jan 2023 09:48:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E3116B007B; Fri, 20 Jan 2023 09:48:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8F3B66B0075 for ; Fri, 20 Jan 2023 09:48:06 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4E1E71C6039 for ; Fri, 20 Jan 2023 14:48:06 +0000 (UTC) X-FDA: 80375457372.06.E355A03 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by imf20.hostedemail.com (Postfix) with ESMTP id 5D9981C001A for ; Fri, 20 Jan 2023 14:48:03 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=nEtep7XD; spf=pass (imf20.hostedemail.com: domain of jgg@nvidia.com designates 40.107.236.41 as permitted sender) smtp.mailfrom=jgg@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674226083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EWn1/vvyb15ZUj3CalBZU0IyJg5/0rXfcEcUMkNyWjg=; b=5+FHLoJnzqwO5tioy28NP1eYHTagDDLAuNAWsbGeK5hk9kyY4j1Ajm5asl+u4FTq81qzQV AhimpqFeA3l/1L9M3V+eiROXh5C8phkZ1dIVWnZ/D9+//XvyOuGSJhtThOTaP0scA5b/YL epWE/c5aJgaBFTIXeFCilwGqnoHHC8Y= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=nEtep7XD; spf=pass (imf20.hostedemail.com: domain of jgg@nvidia.com designates 40.107.236.41 as permitted sender) smtp.mailfrom=jgg@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1674226083; a=rsa-sha256; cv=pass; b=Q4JIcnFI3g8oR7Xge+OXWQJFVRJFiqeBZOk/vEna+2Fn285eN4+gSNbMEocH2HdTyxNbTP MlS74FlriJ01/bZbhZPGNUJY73ZytWFN9rMXLZvraVKXCcpN1xhHIStEYfMzwe1qHzkf4u eaYKMt/VJ8CATRZ5cLC//nKkB2LgQWQ= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WPl9Co94zO4XfeM7fl2ra1QYeZB7AXxgKA09AuHYf3MuX7M3DGkAdvVhLG6fOpfqm4BlxQv0f8BOukBH9wEfgThY+GNbyoiouC9SESe1lbagQybhuNbTacbzK7+WID7RkX5qI/qSNjRUlKQhgigMMZep9UUvtZ26hZrmO7s/0XjmwRrcDti2Lau1l/DtrNG8Vng/uYpC964hNQ72rcDKsEHZPhU/HyN0KZqji3db7EgQLh75nCaAcnqpSg8Q5IkkwEhHxuRQKrp44g/b/BzutJrhrES+bgeyW1jAQFVo7HC47ivJGR3F74j1wBXzg8OjljyoY63YY/JNBc7PQgr/oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EWn1/vvyb15ZUj3CalBZU0IyJg5/0rXfcEcUMkNyWjg=; b=aWWo0WPpA7qtwee3535M6IaccF6TJoIgfrRrt27dG7qewl3Odl/tLRV9WhwLSDB1UyyUboMpJTfCcwqwxPPHdQLuYm8mN723oJnmFrwORaYoj7kN7EpeDM2tKlnPLg6JcZLVt43otL3pjSYUECW+ZNbdV4/uLTLvpp97M+LLqyAaNYi4+bTihxz1LbltxUR/Tr/wCx+M4QOzd5D1TJtB6wJrtvtuz9I7MaPy+zAt+6+Mn7ntDzRFJ3CV4Mfc/MATlKwQa0hOMzmv+Zcs+8J8U5yLIGBPPAPCT3WDateg80zKH4Ajt9dCk+ZsbRgJ8GpJkZC0pEUlVYjL+DWq0eBMPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EWn1/vvyb15ZUj3CalBZU0IyJg5/0rXfcEcUMkNyWjg=; b=nEtep7XDRkwmB4cftUqJL9JvZ/gi7jDrPo6+75Mtznwx60ecO7UugqeSJmm3NkN4VrrzHMloRfzy5LRWzpS/8vMJBXOzYy853rP1Dzx83oCUv5A9M1Jupb+vxAyX3UDXmGjckqy6jvnc1ShCbh0yLCmwuMVGKdikF/z9X+8qWPa7MFCBILVfseFWzi6V6V/+T15xANQlg3vIIvj4izomQMeU9YC8nkwU87zKGTugnEpw0pWwN/0YM4/MWXRglnP1oh8nEPwhVhY5sFVHQvvUe4t96BZRn9Prvg2UAd2aBeCHegkfvQPCPp2npnwmYdjeSprPV87KnHws93eG0xYbdw== Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by BY5PR12MB4997.namprd12.prod.outlook.com (2603:10b6:a03:1d6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.24; Fri, 20 Jan 2023 14:48:00 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::f8b0:df13:5f8d:12a]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::f8b0:df13:5f8d:12a%9]) with mapi id 15.20.6002.013; Fri, 20 Jan 2023 14:48:00 +0000 Date: Fri, 20 Jan 2023 10:47:59 -0400 From: Jason Gunthorpe To: John Hubbard Cc: Alistair Popple , linux-mm@kvack.org Subject: Re: [PATCH 1/8] mm/gup: have internal functions get the mmap_read_lock() Message-ID: References: <1-v1-dd94f8f0d5ad+716-gup_tidy_jgg@nvidia.com> <6b1f8b54-031f-d0ea-f393-86f5a23aa93d@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b1f8b54-031f-d0ea-f393-86f5a23aa93d@nvidia.com> X-ClientProxiedBy: BL1P222CA0003.NAMP222.PROD.OUTLOOK.COM (2603:10b6:208:2c7::8) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|BY5PR12MB4997:EE_ X-MS-Office365-Filtering-Correlation-Id: 14d50841-e761-4a5e-fc7c-08dafaf553ad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CnnfAZlUBPD3Az9uLogBENYumunFtXdmNzof+92BAdbFII3NBZMoEgrMrXzS51IbZKH9uvbJLC8MwAGMJ2Ub4mQHOaDCRius99PBDN2O1/trVRBNFrEa45JuF78uwiyGFla+R8/lJqcz5mzod7RXK+Sq0mg9lLyA9ApRLpy7nop03NWxo5cWtfSw3xl14psjSHj1yAEew7LNjRakUBdfn4LVraEYL2gKnYCdFsSo4PoOHlX+ecLKh0gnrU6BRnkaR9X+ANfbBOyi7b46bQ3QpczuvhD0Vg/h2xxiHclRdcy7a3D/5jkFfY09erZSBR65cUGa25KclfhxvK7k+cPPtpZc7EHXBVRpWJTNb8RlbT7PdlWKJIK/S/+1ASevJWd5S14sEpJX1Nq44ASRWfs3Q+euKDwSFu8TUAFRdTfZy2G9KgbtZ61HwQiVKxmAIivRaP9PwMyZzRvC7POLqpl++EWiQ5XKXTibkdtzIlvLZvatXCqEoqNnwIPz/Xv/u7/smLLwnUxHMlRoFk4Hhbq/J6Qrp1gdbxwF6YAuJ2ZD6iPM4VOi3mY1vLneJxu/UmTT68DHhiHAeCTyNvF1ZdNXhoIcZPFh9w4IxuCiqI+N6S7wAPZf14hM5oaHI5PproZ8X6/hsU6Wp0Uh5QBfihWHFkqxwBQjJL65cxqbJJo8GvcsS2//oYOnaTo4aW3LzYkCYDZNe8U6ZqwAAZhFsAGwVGC8SOnDZlsfRwnaS/gablY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(136003)(366004)(396003)(451199015)(6506007)(86362001)(66946007)(6862004)(66476007)(5660300002)(2906002)(8936002)(38100700002)(66556008)(316002)(6636002)(37006003)(4326008)(478600001)(6486002)(36756003)(41300700001)(8676002)(26005)(6512007)(186003)(83380400001)(2616005)(15583001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?O/c5TEzezbsjFZBOKDW1IDEb4kTiPnV2Vn41tvLa+osizVwczfySd4EBeEkT?= =?us-ascii?Q?zbQL2mPlTxR01+bpDbtf2ATkZmR4HIfWw7SnhBLicCeIrOz/Ydf3b6q0+rAK?= =?us-ascii?Q?hikA7CxynPGPjk+MiEiO0jtWKY0MxcWQdXkJe3cCEI3Ka7vcEDPmuA87P8lO?= =?us-ascii?Q?i9OkAURPMdKHKihgbmulMf/jQlBwsIgHBRSzxypi429ek2xHjkN/t3RWOTY3?= =?us-ascii?Q?dInYH+MQfm/YLkfwKVPbYqh0C4L/jyhqxgCNGpM5wyO8d9iVP0jOSRZpqeSu?= =?us-ascii?Q?Qv6Xwq/Ye+s8+xOKooi3jU28q7MJsoTVNcO3pc7OnG2DflTLq4ZFmBA3PgCr?= =?us-ascii?Q?0z4CJF2mNj1GRm8TVPKKIRKsJmZdhF3wrLRrTDKehRDzOJjaP1d7JiZbzl9N?= =?us-ascii?Q?moLTVzKWPQ2VmlFufRIYr6yaJQ/baJKDV8hIyaY1YZUmcmgTzMLwx2k6jD5R?= =?us-ascii?Q?scIMxpvqYBspES34M4P+NJQABTdff7tUZ50BH5/CPjUzoRprx8YgbeB5+GaQ?= =?us-ascii?Q?qg8rZihJ50TeOBmChIfkQXEh3QlRh6pyQQgM2CSbdO1pCdmyCe/AzZUxh35G?= =?us-ascii?Q?amhdel+6EWrk2Gke8HtOZVULUtIHc5zBN8SAAxf0zi5EThDxhzDDCLdOEBZ0?= =?us-ascii?Q?IGCDK6U1n9EFNnGTnIyLQCtnJGDGXOXrGce/Ez3RXzoZ7s+awCbQF3fBlKUQ?= =?us-ascii?Q?OBqz5jrnR3aVUF+BSpDMqddiu/G31GhBXi/zMcA0cWCgrIfbgp545VNfYkrS?= =?us-ascii?Q?rFdoWtXVdTQwokXwwBm4WkWE7x0be9VQ+DEuS8ELIQHfAUhvabLwg7Ll4qjP?= =?us-ascii?Q?liBcmrdTMpmSEogkyU8eIHlZYIiiawtv32MKkYK5WeyVuHKvR1KWw0HK6cOt?= =?us-ascii?Q?JaiHTyVwEYdTcKfEhVmwzc49oN1FvdWJQrHlbs663/J0HcbObYBem3zzCJS/?= =?us-ascii?Q?I6Ncolmy1lw5tJTbjenV5719XveheKbvWtJYkCwKLwKMT91jIi2OMwx8JgBT?= =?us-ascii?Q?1QwDk82OwrvlR2wrNlcQhNLlFNLKFLXB7KMogVf7I2+/c4xjQGp9vzBOQXBl?= =?us-ascii?Q?HwcVX3q3cymv6/9zdz5PSR1+Wo37+kd4iczWK5qs6Np39O9/LwmUxoS/hWl5?= =?us-ascii?Q?WLC7MGtXCn3/Te96rIs2JbLyfDRKRP7rm8hBRzpbF91tyV4nn32I27+4bovb?= =?us-ascii?Q?re6iHwdnQBmUlHnkWyM24pdJfQM7WzDRY5milEMRZc9ovGYiuKyhrEqOYEkq?= =?us-ascii?Q?5V3jdx+CyzigOsGsAifIWjY+Ubw4quEKI6UVvDo0MvyylRaMj91Jc8eCpvey?= =?us-ascii?Q?R4xDe4oOKP2J51Ssnb1bDYbawVddK061VZoHxyL8kzra5O9ba5CytodS3AQc?= =?us-ascii?Q?7CwGCYwUi+QTenOtbDsgKUN147zRFBcR5e/37ywYyUUwPWwSK48bwU6vlbU5?= =?us-ascii?Q?93M1bCQQnNk8qrGfO/EyR0qcteauk5rceKroHblZY5xWpwgJjifnOi5M3BFk?= =?us-ascii?Q?MVxGMa0YHk4/m1Xe5l4HJjeTqemuUOFc/nu9Z7tm8BMLcY4T6CbfjUFXe96s?= =?us-ascii?Q?aWJ59RnNAHJuKLzvoi/4jXVGg/86UT88WmZdZI0a?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14d50841-e761-4a5e-fc7c-08dafaf553ad X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2023 14:48:00.5282 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5hLuvMTSJ4Ls8hTcS+mWo555k8MQA2CItZyVfE+xx15BfAxn5YQiUrPCLdZneYrM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4997 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5D9981C001A X-Stat-Signature: 74zkhsr4qer6m4beehh6myusstx5ganq X-HE-Tag: 1674226083-373272 X-HE-Meta: U2FsdGVkX18UKxShzGD2k2AJeWPqPZJhY7FtGL1UeycdgsQJAyi4My6KDEswvdN08fOXj4Px1BayEnQXQqtJ+2CPbMjS482gPDaP2XR377r+QSFZFEV+ronnGASUXX4emKif9EzW5MDcgqofGGaL/WO5lj1h87HmbCKGGaJ0BTiV7JX6NSL7BzdoaMjIadRi/sHxP2e2ZlSvulrz13OsOjc4rBzdJzesC3NOatusm3a16VE6IbVCx0xObERSuWovWlaF/aID9Wl3VrkRq+cfh8CkokSxb3ph+9RKRqJZclq+VrU+8anqUx3iUnw2KZxpZpV5GS7Wh9kuUtERUsDzHiwz12yGBuSkuqoMFCVCju6vZnep/1oQ8p4RRqMXwwcUzQ2iWv8N9OmWdbsdRmPds64mwpAcYzfYiyJhmSXF/PDM6alzGW2p2vLGUZ5LXqhPimBEWF0bWNak7J4DXakQY3oS/ToqdEJJQ3gmCq4OVgui7XuVo0lRz9hUlB96r3izfkdKCn1CiyrNTyNiRFnggAmALSt6bAd8s+mkWsqq4UKGJ0TXv41BBblhwfdYmK/b2M7CH6HVV35lWhWX4u6WCLwX9+ryEj6RUd9SrHfGOjJ7bMAsjnV5PSgbXDp76ZyEfgp+a3NYCLH3Z81i1d5ezNgascbg31HGnR/lwnhuyXnwTI5t1Rt5f3jgXR1dHqd/Vre1yFtTmPuTRCI6zCsweR6J+7ADNuku0nIUDgVR+Ahy3IsQ8VwiHTZFy+Pfj1u7kXg/94CmuHpXgRPV2Sa3S/MXJvHbNQJrTok7j3sE0ifYBBHHyyq3NkjRs8Gyb0Svft6tTu6PGmDWe/Cv7mrHUraSq6QUrmkTxRn/8ddrQ41iHWacDmsyy4tLW8J56sQExrT8dD/feyIxYTnl8EBn7fjYbE3PwU+lYR4bJSEDcroHcSPCk5NLHL2DX6HJ7s7Raap+eUknPOmpGYJO3ek 16cs4SGh fex+NSgAanBfbI8y70m2C6S2yT8yqcCYR5jNH0lPKczP3PjZWxg9+3b31U6q6fA8oDs8hhRly35CrLZ49JFbnnUZ+7REYuZOwKR2KAgtGdtV5pbjZzSh5Tw09BZCaraT8PeWEbNq48BS+B/m35MRUs4eDeuZz63gmUjye+RBqFr5bySIXSCYuVTnvE3cY3LCNwMAiETQ4jKOyRDVeLWWAW1fqk7hU8XoZd64Jc2cxRU1T0hjnhgZpNGcjpmgPtzBgRbyEaufeO96+v5wekUWYcqmphA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 19, 2023 at 01:19:06PM -0800, John Hubbard wrote: > > diff --git a/mm/gup.c b/mm/gup.c > > index f45a3a5be53a48..3a9f764165f50b 100644 > > --- a/mm/gup.c > > +++ b/mm/gup.c > > @@ -1343,13 +1343,22 @@ static __always_inline long __get_user_pages_locked(struct mm_struct *mm, > > unsigned int flags) > > { > > long ret, pages_done; > > - bool lock_dropped; > > + bool lock_dropped = false; > > A small thing, but the naming and the associated comments later are now > inaccurate. Let's add function-level documentation to explain the new > calling convention for __get_user_pages_locked(), change the name of > lock_dropped to must_unlock, add a comment mid-function, and correct the > comment at the end of the function. Like this: Done > > @@ -3180,14 +3183,13 @@ EXPORT_SYMBOL(pin_user_pages); > > long pin_user_pages_unlocked(unsigned long start, unsigned long nr_pages, > > struct page **pages, unsigned int gup_flags) > > { > > - /* FOLL_GET and FOLL_PIN are mutually exclusive. */ > > - if (WARN_ON_ONCE(gup_flags & FOLL_GET)) > > - return -EINVAL; > > Why are we dropping the assertion check for FOLL_GET? Hmm, I think this is a rebase error, it should be in the "consolidate invariants" patch Thanks, Jason