From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1619EC05027 for ; Fri, 20 Jan 2023 22:56:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 960736B0071; Fri, 20 Jan 2023 17:56:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 910E76B0073; Fri, 20 Jan 2023 17:56:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D8696B0074; Fri, 20 Jan 2023 17:56:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6F5006B0071 for ; Fri, 20 Jan 2023 17:56:17 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 379391C44CB for ; Fri, 20 Jan 2023 22:56:17 +0000 (UTC) X-FDA: 80376687594.13.36EFFC6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 8B65240009 for ; Fri, 20 Jan 2023 22:56:15 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NzmNBo5p; spf=pass (imf07.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674255375; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zAMx8EirihwD9UWQqrzL4mgOdBhzYqwua0stwcBAXkA=; b=A/VHehasLvxYTme0pLdAM+qWri1+ualP5K6p7mmGNOs8p9X99jHDHm4U19LCmzgaSRzGXv zERaU2OaGPa/G/a9JMC4Jh5pEhzA5MrTNpTRC1JEo/+luvH6II9ydRQIWJ8ZqYGFNSfmAe G1u1PA4WqbLdOqHt5ASJmIvrrzxsFC4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NzmNBo5p; spf=pass (imf07.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674255375; a=rsa-sha256; cv=none; b=e71foX5OmNheb0mlmVRCUZB6A/JuGkvfeJ8sFETpH8y5NMeWVB7v8z3rnNVih7jQZc6Efh zveirp8bFr6S6Sh6eU/oSGObn1+JwK5RL62PYEVXokinY+DahWa9b7EbJX6xLn8QygPsm5 WK114K+5EnDub6ZumGsvikmEqhyiyR8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6E234620B3; Fri, 20 Jan 2023 22:56:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 546A7C433EF; Fri, 20 Jan 2023 22:56:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674255373; bh=oKkf+3Q00EAO2IQpP2ByrfkTu1TC3Bz2jqgj3PZH6PQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NzmNBo5pWTxCwXoH0a09URQ35CxJllJ7ZLTx0s6tk84iP9ghkbZ456e1RsoYumXPA 0P2LRE6zdU9RuUkniD+0Zoh1jQ3DSIs22QHjfQoP1AYEAaIXuZ7vi/QD1IqciTXUO2 +DIXG29qkSmTWTkgp5r8CVst1DlL4dpWt4Oqv+VQC28qZO/wBBbSZYQnGCWPD1WbAi Y7v9Z6HCAJe2NHI9c1LKhKf8OBK78NBqAltqti0fNVMJAlHI8rKswZysP4WMbtMf8M wO9k9noYac4ACsDgYgd9Jsu1kywyp/7BCtza+cftv2hGULqPXs87IC/zz28HA8VZKa 59bQV8ds2AMbg== Date: Fri, 20 Jan 2023 22:56:11 +0000 From: Jarkko Sakkinen To: "Kalra, Ashish" Cc: Michael Roth , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, harald@profian.com, Brijesh Singh Subject: Re: [PATCH RFC v7 25/64] crypto: ccp: Add support to initialize the AMD-SP for SEV-SNP Message-ID: References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-26-michael.roth@amd.com> <897b503e-48d1-bc4b-1e68-42792d589ddb@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <897b503e-48d1-bc4b-1e68-42792d589ddb@amd.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: bpjmhhij3eqzsiifybq8jyzmefxfmync X-Rspamd-Queue-Id: 8B65240009 X-HE-Tag: 1674255375-485621 X-HE-Meta: U2FsdGVkX1/B/6ytbkdfdMjp40jgGRvUD/Qo/30d27vJJEjaB3TI0JZWsYA0XtC7JV9np6S6LmhePoweIZNEiT0nmox66U/Jyizt+sLjDAcmgNRlkU9zrediBMnW3d9o5yvbw+l59Kurvyhw7HTBXsCB4E2ndZiUVrwAmYo/nCznie34j0a/9Pu+xuVm0mPKpziVJ+O6DY7T0Yl1sUqIzUu2GbahHrgkeQ8xayVARmAxhBgs2vRMLHlJI1d9wGo+JWiKyBCmDYDv/eEzdkcZhPWFQR2PFWQ/1I6SU8ujHGI7jYmcbevBXE07LnOZEpa1QrbmR+EhS4FSPIfsyyhZxqeNr0Mm34gOhbv7ZA+SrzviwPD4xU9Ra3U8BARY1Xjuh+I8KtZF1YYDAT3EqM9yPcERcK19Pk6ggNjfiUa9rQXTFXQ3jLbmaU8H37PXw3dghs7YeUCXdStWYQmn4szhsDEI5LObk+tRUmEalwJVxKJhQxEhkP9jl3AgkZik2n6smLcdmfLRKfjNwWrEldpTArNlsVRDyA6CVx6fvixtZQJt6PtwUihxmHTNnZbm2Vv7V5/SZ0AMmVF/Z++MhAB7NORpJo+llR/HCx6lYyO0gWLOLXy7AF4CmCBeGAyXZvnqbtjMcfCcEp0FmVfPsv8OlUWDg7xBeRkpt5RSz8j35204POW5x6Igjzi3lOKZ88KU2JnN9GqluhJL3/KciY9vdGdK4paZCadM5qvo3FJRNPVrp5kJHovhlPjneizXAk+RNivJOS70aKHeoTYqby5jglHbuQ8SHU7CZ0+pS2r79+WoMP5L4cw2QgCupHAAXLzhs9joONOI/m+5bqffySKf6Lsv1Nogz71u0A8w5EuZS1Xi0rOQLbnScvFnoxcGX77KvtrRujT5zMUsyztp1DcBOSfltO0rJfHwUAghfB+a2YewgiAllmYB/5QHYbZy36aenM/vglgIZ/2mBFDzXvQ vA/YalNj 5tSrjKMYGWBStzaJyDyNNAIOeUOCqIcj5AFa6RQdrkqi1KmQX+MUcQNMFXWe9UL8x4tBUJuKS9KVuSVRc9r2mYfSdtAhmHCUqjLJjaXR1uf8yRqJEcb7fWk5ApdXofgx1Az7qMz/WxDNEm2SRocgvbvBAvzYYGorU0/dKEYOWCiw/9sl0BlvVWi83qAAcdXubuv2cM/4M+OFFiPZqP4xl0DwA35rO56wCZVevLXy7ijkYle3h9bOs4PtGLu3VTSAxaQvw//rF9fprFYwxQXu2j+Zgjo5Joz3zlKU1gHDkOM665a3nDhH8POKNrQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 05, 2023 at 04:54:23PM -0600, Kalra, Ashish wrote: > Hello Jarkko, > > On 1/4/2023 6:12 AM, Jarkko Sakkinen wrote: > > On Wed, Dec 14, 2022 at 01:40:17PM -0600, Michael Roth wrote: > > > + /* > > > + * If boot CPU supports SNP, then first attempt to initialize > > > + * the SNP firmware. > > > + */ > > > + if (cpu_feature_enabled(X86_FEATURE_SEV_SNP)) { > > > + if (!sev_version_greater_or_equal(SNP_MIN_API_MAJOR, SNP_MIN_API_MINOR)) { > > > + dev_err(sev->dev, "SEV-SNP support requires firmware version >= %d:%d\n", > > > + SNP_MIN_API_MAJOR, SNP_MIN_API_MINOR); > > > + } else { > > > + rc = sev_snp_init(&error, true); > > > + if (rc) { > > > + /* > > > + * Don't abort the probe if SNP INIT failed, > > > + * continue to initialize the legacy SEV firmware. > > > + */ > > > + dev_err(sev->dev, "SEV-SNP: failed to INIT error %#x\n", error); > > > + } > > > + } > > > + } > > > > I think this is not right as there is a dep between sev init and this, > > and there is about a dozen of call sites already __sev_platform_init_locked(). > > > > sev_init ? > > As this is invoked during CCP module load/initialization, shouldn't this get > invoked before any other call sites invoking __sev_platform_init_locked() ? Then it should not be exported because this the only working call site. However, the benefit of __sev_platform_init_locked() addressing SNP init is that psp_init_on_probe can also postpone SNP init without possibility to any side effects (other call sites than sev_guest_init()). BR, Jarkko