From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E6EEC636D4 for ; Fri, 3 Feb 2023 13:13:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63CC96B0074; Fri, 3 Feb 2023 08:13:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EA7A6B0078; Fri, 3 Feb 2023 08:13:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BCA26B0074; Fri, 3 Feb 2023 08:13:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3C13B6B0074 for ; Fri, 3 Feb 2023 08:13:36 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0AB2E1606AF for ; Fri, 3 Feb 2023 13:13:36 +0000 (UTC) X-FDA: 80426022432.28.D54DBBA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id DCC8FC0015 for ; Fri, 3 Feb 2023 13:13:32 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ck6+jalh; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675430013; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u4NyDrKdcPWGycGNrQyezKZBDnGdKvTZkI+TqU0X1ac=; b=pQ23vJMDZdRa+DjYg3z9eB6HNwhMQS46qxYyYZ/N2yhkOR0fK3AiqyRzmERNmiksh/m1el PIv2v1CFpASM63BEOKzx19FRGm1oMmgeyY8eRkuPjttJ+Q5LbYFRfj7e5p83D16NyPmiEH uWrkB8b9Z61BO9aHv1PGG9Ax0uvMebc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ck6+jalh; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675430013; a=rsa-sha256; cv=none; b=TNxepSMisnVkL1HEgaGHIVjV+LWTpkM1UZsk+7J5nNO9BCYbNc5bctKor/tC4xXP2fFZT4 SvtOdZKuKTd+eI7aSiO5byJpmPrDyIiUSs+l/xhqYVoQhNMuoX2WH4ePWQWAUcwAjJM/Dh 9oWpZQOa7ndyD6pgETJH2V6rtXyOIic= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=u4NyDrKdcPWGycGNrQyezKZBDnGdKvTZkI+TqU0X1ac=; b=ck6+jalhkqeu7gRjvR0e8xaeJ8 oXfWK7Nh5fXeRq10RS/iZpZIBhK+9ptMxA3fjZgWgpNqwN5exBSr/o2vXHYd6bnE4+B29YVn/zXRh ZWGGZcC9vqr7/hwcqOPvbURUqak8Z2e0txrJuSt6p+SxoAH5j99LEULSl6bB/l23ni3/u92zMO1TI L8RZhDwnQuLoMhhEz06SO5iL6Vmya4ccO4YhA6huKmqaHjAb7DSbUMy6fMpA3u36dznGllslmPvuN CdzUcP88qAoWib56bb7I9CCWTxtqKYpgbQkELrOTMEm93O0SBbqy12RhsLPT/dkPfCAWeJU4XJ1rY rThvcaDQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNvsZ-00EKPM-Uj; Fri, 03 Feb 2023 13:13:23 +0000 Date: Fri, 3 Feb 2023 13:13:23 +0000 From: Matthew Wilcox To: Johannes Thumshirn Cc: "linux-fsdevel@vger.kernel.org" , "linux-afs@lists.infradead.org" , "linux-btrfs@vger.kernel.org" , "linux-ext4@vger.kernel.org" , "linux-mm@kvack.org" , Hugh Dickins , "linux-kernel@vger.kernel.org" , "fstests@vger.kernel.org" Subject: Re: [PATCH 6/5] generic: test ftruncate zeroes bytes after EOF Message-ID: References: <20230202204428.3267832-1-willy@infradead.org> <20230202204428.3267832-7-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: DCC8FC0015 X-Stat-Signature: qfhmk1euxcarouq1a7oqotnbguo19teo X-HE-Tag: 1675430012-593405 X-HE-Meta: U2FsdGVkX19cq6/TILaR9B6TZ0iqQMzqO8111KflxkbIv6tDmxXOgllngVPYqTMMledZZ/NMrFE8Xjvk0LqtpMJH5yqdAanEmPi9mXHjOgEPyT6Z/H+zt+PA9A9H94akcdcbx4Fd3HaAlnORlwcBNilEloy5Eykz/6eDQPWsoy61U9PXTMLDTtmXKP7hiEqwWIeThwmXqRSqg6u3MlXsOGGM46wagDu1yLgzzqATwv9r2a3hPQVScSYFBQxLL1ht0nqpQooOCDhpe+pvCVzClA2qcW0Qr6/rudEyREv+6zsMqSBZXxZ0Q3CW8aXaPrP8u+M9Q0ffweK5xSqgN+DEr17YtbgeulXPpLZg2UWuX25nnNCVhCjBPa21MPOPTi1I4XNMYFMB5zLBeQ54uMXhugUFS/1sinpZIS9MuQJBkgDfPPQdyilkHGwmiGzi7vOBYl1tvMP4lJDuC7PQx4BiVBic3DvA/J3U14fjqKO8hLxmXJEINiCOlFbz6Uc5WaNyA9O5PDu6xI6MauKQdlfspYYNMwu8ykM7HaSIjxNPJ/jW/Dl5V/HobnlfXoCEmmD46lrmGhfARFb70q9gc/sD6oVr2k/i0rqnPYEWI6niB+9NmJ90h4cfdPXp5SY2X2YB60B6PwP6gwfj1WC2b2YPV8pxo5J+L0+tABGHbxyrnqyxeGRC6/ENDjcoTtwAgbYDvibATcgxeuNHUIegA7fDNrliZPhFVIqBQ1PCzv2ef/HpgTcjfGBdxDpd9zamZlm3p33yncrUnqgrSvbRPJSIqak3U4ix77zWPrOL/8Aoh7MyNxpObgwmNvORosWACHE03zGx95ZzbMYEMKrTQnKYSuJqZaMWYcFMGo7BzRvu+ifF+ssK/CPjk6Wr4n9VQwfJmV1NvJGpRVrusY33kpQD0u51klVuwieh4Kt/fvXDBNWzsx+2vjDroBcelBe7pVodzF7r2AXCb5oaRhVOFlY l/ItZTt6 Z1mfyxERadpMYcLnRTROjHlzH6leGrpiuNNADgA4b3aoXvYoCD9QTChMFmdRWFmJgzpH+lnwA3zmqJ8uiAGOluvpMKlXJIlqzPk0g8CEGs0L9TYkuVNDiMNNGDLBCj7u7UY5mK+6i9aoZTbke+01/TenPngslTo+Ofn6+5cJ6aMfnadq3dSHLs5raLjBs8ayQqDx3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 03, 2023 at 11:57:11AM +0000, Johannes Thumshirn wrote: > On 02.02.23 21:45, Matthew Wilcox (Oracle) wrote: > > + fprintf(stderr, "Truncation did not zero new bytes:\n"); > > + for (i = 0; i < 5; i++) > > + fprintf(stderr, "%#x ", buf[i]); > > + fputc('\n', stderr); > > > > [...] > > > + > > +$here/src/truncate-zero $test_file > $seqres.full 2>&1 || > > + _fail "truncate zero failed!" > > + > Is '_fail' really needed here? truncate-zero will spit out an error message > in case the truncation doesn't work. I don't know what I'm doing. I totally cargo-culted 706 to make 707. If someone wants to completely rewrite it, go ahead!