From: Matthew Wilcox <willy@infradead.org>
To: Yin Fengwei <fengwei.yin@intel.com>
Cc: david@redhat.com, linux-mm@kvack.org, dave.hansen@intel.com,
tim.c.chen@intel.com, ying.huang@intel.com
Subject: Re: [RFC PATCH v3 2/4] rmap: add folio_add_file_rmap_range()
Date: Fri, 3 Feb 2023 14:02:51 +0000 [thread overview]
Message-ID: <Y90UC6nbXTujGuPx@casper.infradead.org> (raw)
In-Reply-To: <20230203131636.1648662-3-fengwei.yin@intel.com>
On Fri, Feb 03, 2023 at 09:16:34PM +0800, Yin Fengwei wrote:
> +++ b/mm/rmap.c
> @@ -1303,31 +1303,44 @@ void folio_add_new_anon_rmap(struct folio *folio, struct vm_area_struct *vma,
> }
>
> /**
> - * page_add_file_rmap - add pte mapping to a file page
> - * @page: the page to add the mapping to
> + * flio_add_file_rmap_range - add pte mapping to a sub page range of a folio
Typo -- missing 'o'. And there's that word "sub" still ;-)
> + * @folio: The filio to add the mapping to
s/filio/folio/
> + * @start: The first page index in folio
Better to describe it as the 'first page number' -- index is usually
used as file index, ie offset within the file, rather than offset within
the folio.
> + * @nr_pages: The number of pages for pte mapping adding
Maybe "The number of pages which will be mapped"?
next prev parent reply other threads:[~2023-02-03 14:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 13:16 [RFC PATCH v3 0/4] folio based filemap_map_pages() Yin Fengwei
2023-02-03 13:16 ` [RFC PATCH v3 1/4] filemap: add function filemap_map_folio_range() Yin Fengwei
2023-02-03 13:53 ` Matthew Wilcox
2023-02-04 3:25 ` Yin, Fengwei
2023-02-03 14:17 ` Kirill A. Shutemov
2023-02-04 3:31 ` Yin, Fengwei
2023-02-03 13:16 ` [RFC PATCH v3 2/4] rmap: add folio_add_file_rmap_range() Yin Fengwei
2023-02-03 14:02 ` Matthew Wilcox [this message]
2023-02-04 3:34 ` Yin, Fengwei
2023-02-03 14:19 ` Kirill A. Shutemov
2023-02-04 3:35 ` Yin, Fengwei
2023-02-03 13:16 ` [RFC PATCH v3 3/4] mm: add do_set_pte_range() Yin Fengwei
2023-02-03 13:25 ` David Hildenbrand
2023-02-03 13:30 ` Yin, Fengwei
2023-02-03 13:34 ` David Hildenbrand
2023-02-03 13:39 ` Yin, Fengwei
2023-02-03 13:32 ` Chih-En Lin
2023-02-03 13:38 ` Yin, Fengwei
2023-02-03 14:30 ` Chih-En Lin
2023-02-04 5:47 ` Yin, Fengwei
2023-02-03 13:16 ` [RFC PATCH v3 4/4] filemap: batched update mm counter,rmap when map file folio Yin Fengwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y90UC6nbXTujGuPx@casper.infradead.org \
--to=willy@infradead.org \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=linux-mm@kvack.org \
--cc=tim.c.chen@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox