From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E4C8C61DA4 for ; Fri, 3 Feb 2023 14:18:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7EDC6B0073; Fri, 3 Feb 2023 09:18:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D2F226B0074; Fri, 3 Feb 2023 09:18:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF7386B0075; Fri, 3 Feb 2023 09:18:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B28B56B0073 for ; Fri, 3 Feb 2023 09:18:06 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 80C54408FC for ; Fri, 3 Feb 2023 14:18:06 +0000 (UTC) X-FDA: 80426184972.23.55AE144 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf12.hostedemail.com (Postfix) with ESMTP id 8C6D440029 for ; Fri, 3 Feb 2023 14:18:04 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QzTRUjOX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675433884; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DoiqXd28KMftccNrqTYg7Si65yqoSeoENTzgghs075c=; b=U0velSok8lIF4Juw1ZUY0slVIpTR262/90EneqM/ElCE/l+qkldSXVN4dr0NozHPDH5pIP 0YYaK/KRoU5+fSIOkk6VjvwhRosgxlvxO0/4C/yrHEdIR389cvLb2KkxWY4jK5XnOXtwN/ hcczxR4TsiQMSOSFBrbZtQuuxKVZYzI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QzTRUjOX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675433884; a=rsa-sha256; cv=none; b=xPgBtYIgymR47kCO5r9QJCkcRjjkXz1X6jkiqYUzg9FSJzFlJePaLZB+ZcxXyd9/dQyBjS g7FvaKjX9BLRNwnc0Ctlahxc23ipuVwaN151YWYlGs0yeQtSmImDEifmSNaJ18VdIi8OrT ktUJn33chZ8TPM/HIXw0VKeWPF1dTk8= Received: by mail-pf1-f175.google.com with SMTP id n2so3654409pfo.3 for ; Fri, 03 Feb 2023 06:18:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DoiqXd28KMftccNrqTYg7Si65yqoSeoENTzgghs075c=; b=QzTRUjOXZiSrNl/tp3KA1s1lwssyWxjTCLqvcp7HeT8XQLJ+yZ7uzzsBMWZtqXt/Mb o3VzW3idHk/wMY0rheNoTWuA4D7k7UY7Weqo9UmsAk35Z9K1GHubhCiRbcG2/9ONRZ8E RPXj3vvO/ftwltDFYGBP1UPf4zTAYtmPQ9wAsI7lIi0mUORec+qqVI8pVggVFbVQ+bWV fY0vooIlcj2xo9ZQ6aeD3RCG/1kyi0LEepOjbxAtI905R6Ur+KDpAML/uztYbNR+yFlV gFix8ON2sy/Nxg5w1nEuQOHCVgf62wcPmD0aE62R7DF7Uvd3zi9MeZ9GUk3n23InQi/9 rF0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DoiqXd28KMftccNrqTYg7Si65yqoSeoENTzgghs075c=; b=6H06c+iPo7GhfnRCs7cEnhG3pW3BtupEDcbL2VMZAS2CG9LlHjxf5y8xTTNKnZxYyT kqi56tN/tw3GGvB/s43ss54p/yWM/NiWad2qFMIozScNjKnK5pPDePh1uMr1+oJlh5dc Z0N3FB6i75fAXltZf3VsYJgtNLiMDr/LwGkjpIQk7nbkvrO6/+TCpJIe4IuGZe5G5dGB 9RkCrgpDsgoDi3BZ4UhEbnUf6bMid402Cxo4csy6e0oA+1mzb1BtWN9TBmO75cqLBWo0 pnJY2uSaqKWkZdvuMDlOQ8cpaAX5HFROpRVE+JFDy0mYJlU1Yy/8QZ0n9QlI3h4MixUZ Py8Q== X-Gm-Message-State: AO0yUKVQzN5fTT08NrkNyNbM4MWPKkf43J8G7o5Nllslp1zxoiYWp660 pS6xNsTz0BJi9JHPDBjYYQrM/cXTC/zB7KSI X-Google-Smtp-Source: AK7set8x6l6tBccak5cZcB3IHZCJCoOHOQp00sOaem1EgPURq5ow6yUDTiVoRd+5YjBXSSKdqILxOw== X-Received: by 2002:a62:f80b:0:b0:592:557f:9f63 with SMTP id d11-20020a62f80b000000b00592557f9f63mr8179172pfh.11.1675433883278; Fri, 03 Feb 2023 06:18:03 -0800 (PST) Received: from localhost ([2400:8902::f03c:93ff:fe27:642a]) by smtp.gmail.com with ESMTPSA id p28-20020a056a0026dc00b005941bb37ffdsm1763791pfw.165.2023.02.03.06.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 06:18:02 -0800 (PST) Date: Fri, 3 Feb 2023 14:17:56 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: "Huang, Ying" Cc: linux-mm@kvack.org, akpm@linux-foundation.org, Zi Yan , Yang Shi , Baolin Wang , Oscar Salvador , Matthew Wilcox , Bharata B Rao , Alistair Popple , haoxin , Minchan Kim Subject: Re: [BISECTED] first bad commit is c203c6d5b3f0597 ("migrate_pages: batch _unmap and _move") Message-ID: References: <87h6w5othj.fsf@yhuang6-desk2.ccr.corp.intel.com> <87wn4zmzd1.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wn4zmzd1.fsf@yhuang6-desk2.ccr.corp.intel.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8C6D440029 X-Stat-Signature: h8t3a63m1fonsm4ouewecnusxojr5gox X-HE-Tag: 1675433884-57602 X-HE-Meta: U2FsdGVkX19pj6IQH2Z6EyDDgThUMVNk2irmgzLzvTC6ymB4jdxcZ/gWeTcyLvI+Cv04844OTnszLe91XTqCNBHlLfj4Vq/7XKmE7tTd+CRHD0iSsTFOyVQMN3in3d/IFxSOHqvnNcUXttHZscq/t4OGmVSvVD0H1Nsu2pS8GkBxDIOlt625mBpRVNd0uZe4+vhADIgrDaUptxdu+i+9Hm1Drp0E3fjkI0WyEleihpCo1wUGMsrOSTZE4bmr0N10HRyiwlDZVGlKZmqF007dklFmkKB4/cyfwFnJRK5DvzdtoQxGZod9PCPqNIV3CHLUAtZxJztUpz18ZMIpIxEWkDCfEe8Op46ASX8hte3kZzzCkZpR7OVxgkaViHZbzQweMmITE/65NuKPq0wxY/jjtt/IaSKIL4APGqw8TM1+P7qwnadPZKLigoExYXbsIbTor7NQ9yWod5QRyj0W6cnlepZsibnDYiZyjJaIO/MCA8dbt9XG10LYSQ6YzSZFUuAEyEbLZulhCR182AxI7JP2a5mYtPHjh5mKC0PURDuJ/niOsCofVKXHfmCQKzGQFXwSVmI2VmGfwbjY07xCIGzCMvdo4l8bJYUD56cN4NglLjvRFZjoflK/aChPQomsHYmoUl4gvxDcriMpCDxWk9LVGB1QnOboDEHSsKckmhCIHYzqSuM9QJu0pFalQJHe7FLwGZTOxrjlWM7YZenTZNBG+NW73cdvTP29inzxKAF7mjhaRFliE/leeyrH2tjpgGe/PFwPY1E5H2qxzP7R66ne5TAbISWo10POIFOpwQMQfgV5HK3EJi/lrqr/JRHsiWINMJSQHcFnfdav0X7g/tWtU+EpjvO4m3tXGcGr+X746T3YlrfKDxQ/yfpN3wxCHgJ3O7/tTY9ttH6QSyrGSXFU+XI+XSnAmOq04TVLIa59s7Bv8OMDYGWmu0BYY1/YYRYW80UZ/wjnl2m0QxF2eYf /eEye6Jv WuwvW1O1CV5Hhj4uAKB0NZ4IulwVZvxCzAyYTEU7cH0wOVN0S49l5cQosGFKzFBCcOwJ47CPRIfyX87NpUzlLSmCFmiMQPV+AtdH056D2A2f6Ay0GDQzarXzr9wKt5TgtPtvhT5XguvyMhmyMEeEZa3+MiE4pLT+mhA3YbiukdzqEJ8DJ1QqIm09UN9DgF71WO2d1NNza1nrgeHToX+iiwbyukHTpIay0IoIMXajWk8dd5Wpctpn6KvFv6FdK/qcD2ws0YYDZSPwiai+l3+R2lojGauE4wRGmq0Ym5mGUI1pLXH2BVf8utc6zHF/86hlYgB4I1DsPH/e9gxR2OetcCifo4Kbi5j0Mwgf/8SM5stnJwBGHksfGIs/RKjS6JjLZOBqTyFLzW0v1gNeERw5g6OWKli/v8FCt5s7pTpb1CR2UEnjZSdFDmWqZx7DYAac16Ha76cMtv8wlDJJrv/KmfHvCfXJ7etOKG5CxQVTWkhT/marsgWa+liWEGtSZD9KFITC2WYJFQ/ZYOBjdc+ghKvJgNwN4FYnDV0N6NWAtcWqaFING/BUS4S5Be85oUJuLdV9pWrh2LJj483prt1iauZvOzmTKJUJNcbPUeBMIn35+WJc6T8gxv3XG0pMhxnn5PavZIJFHoabs7bhrkkDxP3468Gm1kZHiO7aRh0tkPbSZfI4lQQZN7KoBtakygEhJQGVmwo9GjL0l7Xs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 03, 2023 at 07:17:14AM +0800, Huang, Ying wrote: > "Huang, Ying" writes: > > > Hi, Hyeonggon, > > > > Hyeonggon Yoo <42.hyeyoo@gmail.com> writes: > > > >> On Wed, Feb 01, 2023 at 01:09:10AM +0900, Hyeonggon Yoo wrote: > >>> I've observed random list_del corruption on mm-unstable, > >>> where HEAD is commit d69862e693c069f4 > >>> ("mm/migrate: convert putback_movable_pages() to use folios"). > >>> > >>> The issue can be easily reproduced by stressing MM multiple times: > >>> stress-ng --bigheap 0 --timeout 300 > >>> > >>> The compiler is gcc 12.2.1 and config, dmesg are included as attachment. > >>> I will try to bisect but can't promise quick resolution :) > >> > >> > >> The first bad commits appears to be: > >> c203c6d5b3f0597 ("migrate_pages: batch _unmap and _move") > >> > >> the first bad commit _probably_ be earlier, but this is quite > >> easy to reproduce so at this point I think above is the real bad commit. > > > > Thank you very much for reporting the bug. I'm in travel now but I will > > try to find some time to reproduce and debug it. > > Still haven't reproduced the issue. But after reviewing the code, I > found a bug in the code, which may cause list corruption. Can you try > the debug patch below? Unfortunately my home server seems to be broken again :( That means I only have access to VMs and not a real machine now. FYI it was not reproduced on KVM but reproduced on real machine. Could you try checking on your machine with the config I attached? [1] Sorry to bother your travel! [1] https://marc.info/?l=linux-mm&m=167518135116956 Thanks, Hyeonggon > Best Regards, > Huang, Ying > > -------------------------------8<------------------------------------- > From a4eef847fe4f6e50b6c3f69651c1dfdeb4b23bc4 Mon Sep 17 00:00:00 2001 > From: Huang Ying > Date: Fri, 3 Feb 2023 07:12:24 +0800 > Subject: [PATCH] dbg: fix list corruption for -EAGAIN > > --- > mm/migrate.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 143d96775b4d..4205a0297ef8 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1230,11 +1230,11 @@ static int __migrate_folio_move(struct folio *src, struct folio *dst, > > rc = move_to_new_folio(dst, src, mode); > > - if (rc != -EAGAIN) > + if (rc != -EAGAIN) { > list_del(&dst->lru); > - > - if (unlikely(!is_lru)) > - goto out_unlock_both; > + if (unlikely(!is_lru)) > + goto out_unlock_both; > + } > > /* > * When successful, push dst to LRU immediately: so that if it > -- > 2.35.1 >