From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21311C05027 for ; Thu, 26 Jan 2023 17:51:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 826F66B0074; Thu, 26 Jan 2023 12:51:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D6C56B0075; Thu, 26 Jan 2023 12:51:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 628B08E0001; Thu, 26 Jan 2023 12:51:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 51C736B0074 for ; Thu, 26 Jan 2023 12:51:45 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0DC6F120125 for ; Thu, 26 Jan 2023 17:51:45 +0000 (UTC) X-FDA: 80397692970.24.BB8276E Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf27.hostedemail.com (Postfix) with ESMTP id BC86E4000F for ; Thu, 26 Jan 2023 17:51:41 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=e44X3G7L; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Gtpi1YvR; spf=pass (imf27.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1674755501; a=rsa-sha256; cv=pass; b=IjQasXE6dgFYYqv/meigsOkn+adSV4PbXd3Hozi4xKg3+3LpPp2WJdYzwul1mFEfmQmiiI 0B24c916yO7o99RvaxEMzmmXG9KhPU4WNdVvk1LeCNfZ0O1htfhF4ZLq5TB4lxhEeB4JKY 46H4TNjQWMgtVmicLJHcODOR392KmV0= ARC-Authentication-Results: i=2; imf27.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=e44X3G7L; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Gtpi1YvR; spf=pass (imf27.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674755501; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zE4QMJjWzCBikJS1xVOD5PLj2xP9d9/932jxNin8skQ=; b=DtXrBpVj7BokCzNNhVqikTwpRVHUSdJJPkMSe66IHcBhdv2BFbaeLTJc+xHjKO3dbiVnOx ntxjCBE697wE4ToISRoL/9fRS+KmXHDGfXBxdDVFPlz4lCavZhm7ZEx/Ggc+SkstwfADAq XcqTRWJmA62N43SGvgHMblhqiI88BTs= Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30QGwcea004710; Thu, 26 Jan 2023 17:51:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2022-7-12; bh=zE4QMJjWzCBikJS1xVOD5PLj2xP9d9/932jxNin8skQ=; b=e44X3G7LTNHOuft87vrThVdFdXR0H0ZLbnQvQ7rusmwW3W1SfEa2qYtCQRkWTIaKWHyF 37An4auYTpFRdmkhQQm6xqKdyMVpxuCc/f76iNfFsCkWQJoxBiqoL2Lnh0HNHfoWXUJ1 fU/ySqe/WO6ygNT8vaGIQ4pyDPlSVW4arByQMBJvDXugivz58PBfMQGuAljnTAxdkPGA RNzRbZcIDP/gdDgtzOgxk5qzWvtmpPlyGa39Aux3m6tBFDVTtbA3UEWCeZQZ6VPmxLaf wxb9QpVdIbOjtf0xWaAaSEJBZz0+uSM31MeAe8ljl50u15NeHBsZfvCb1+n7LjoYKEm/ UQ== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3n86u3311d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Jan 2023 17:51:20 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 30QH80BK037505; Thu, 26 Jan 2023 17:51:19 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2046.outbound.protection.outlook.com [104.47.73.46]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3n86g7pkyr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Jan 2023 17:51:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dkCDuefvDLIdMNgUEHqsSvpsi6P9P0dVg1L6m27kvxpqvqwmuO2/TmAtHj4IxnUoQ+xGMh6nfCS2wxk2C6hGfIYjqQynvoQtjcH1qAWcoMlpBhg7BBuammvut1F5W05M5dMsXqDoJsrOdhthlMSbXDdcim433yvjINt5R2yXC1wRtAX4ULPxSbkBr++Bg7Fq8YCi7Pe1Sc9ZUk4HvxsmXl+iJZ3hZYUtZXfwlHqZCJaDbX+lS6bmTQe7No7e2PprdmHsHIMqXjFFPRoKta9LLF0afBLUmp87a7yDjhhV95wBAq8rSe6d2ZjD5KGfbwsiHvD7xLNXdf7qgxakxdXqFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zE4QMJjWzCBikJS1xVOD5PLj2xP9d9/932jxNin8skQ=; b=aZNLydziQKcv9UK6LsR/aOhB4QRzdxT0UPs9c8CIvj4dai5DWa9ROAqdmvpjXwtjxdHzYeC1qoF/BTmj80rcqKEhpZ0qsQSuSG5l3xQ8wpSxeEDjtT5BZLVtv74nZxi119/LcOl7vqlCljIqbGsdTDIeHSL4jYq6Ftm+778+OyWyfL8P9sOYojFxoTO1Yc+OMvmwkcyBUq2tXqR+ppLJUOS+n400blLOFe7cKPYDCcPGpSfNiAq33SMVcHXchO8MjE6iLPcxMRgXgUFfcQ+ktuIDBe7b+OZ5JcymGrAdSvEWSoOk/8pwiSKmNIPjC3uAn0oxb5VvaNF2JMy55asHTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zE4QMJjWzCBikJS1xVOD5PLj2xP9d9/932jxNin8skQ=; b=Gtpi1YvRa2swVL/EOZIeAHKJkrQOkIiXKyKWH4e1SaXZSy9lsva3Mq8JEf/53vYxNebiF9P5nX8pbjYmkwOn65trlkMC66uZynbk9CERyDQKlmyToQvPZGczSaCX7C4refst/6S8LYBpoGTklY1mz3BrT33oWJfbPiCMnVKskuE= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by CH2PR10MB4151.namprd10.prod.outlook.com (2603:10b6:610:aa::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.17; Thu, 26 Jan 2023 17:51:15 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::3a1:b634:7903:9d14]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::3a1:b634:7903:9d14%9]) with mapi id 15.20.6043.022; Thu, 26 Jan 2023 17:51:15 +0000 Date: Thu, 26 Jan 2023 09:51:12 -0800 From: Mike Kravetz To: Michal Hocko Cc: linux-mm@kvack.org, Naoya Horiguchi , David Rientjes , Matthew Wilcox , David Hildenbrand , Peter Xu , James Houghton , Muchun Song Subject: Re: A mapcount riddle Message-ID: References: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MW2PR16CA0046.namprd16.prod.outlook.com (2603:10b6:907:1::23) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB4196:EE_|CH2PR10MB4151:EE_ X-MS-Office365-Filtering-Correlation-Id: 547b7b90-a1e0-4e6b-0121-08daffc5eb8f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FzhxwMgix/2chXekSrIhLgL4V4NHAAoDD9Y+M2sMECci7z/wyFHJ99ThFay6bsBxaMFTdhgONn/hqXxMYRbmTBYBZ/BrMik8/HzezxRZCc/LDPsBvVVJGLJ5Q/HfWobDynNgpFV0PHpVu/rc/JWm3SQZ5JaG8vX6yzFTHLd4u+K8GKqF2jLNPOBNoy+jmxhGq4HLpY5h3rW339CFozWNEO3928r6RqqflG4N+NCni+LCxVeoAEvmnO6Svyn1rBPZDicNZMzxJXUxiG+L51iJznO+NKbRypcXnM8BPNnhCyn5ntPdFpoJftAn9XE37QrXLyZNYebWp8+L2oPvqi5WHnvBYDYW/UlKMa8Yj7GA0L5EO9F3ly3BAt2H+gDGUsIWOW5wK6imeJxJworFAwPhlUxMhE2RIKiZWYS50mFUQKBlgGIXW9ZfAEurtCYDsW4SGzffqBg3fTPrpaL6vRGWMqdkdiDJbGyELyGjV5nWBBXu5fy+fMsoAvfQcG3RIUmB1Qw7UtPzvy2Ct6lEbi+C0+TW3grc2y1PLlhwzW6qELgipoR/UqG3yrxg+94bPZsLRicjwtX6w11Kl0cyUOUXz1u7O0x58jpGh3XtoKDLrXQPL/uj9C1npb418P76G7DBhIC9fUVEpR7lMARTlE/vZQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(7916004)(39860400002)(396003)(346002)(376002)(136003)(366004)(451199018)(66899018)(66946007)(316002)(86362001)(9686003)(33716001)(54906003)(8936002)(5660300002)(2906002)(6486002)(44832011)(66476007)(66556008)(3480700007)(6916009)(41300700001)(83380400001)(7116003)(4326008)(8676002)(6512007)(186003)(478600001)(6506007)(38100700002)(6666004)(53546011)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gieZ4BG7cmrLN/x379rbqz24iFcnfQPETIVZDPr3t/qMBZbpEaHgUWNCzwg4?= =?us-ascii?Q?m9eoVcdkp32OAhnFLjxU+gICuiKjgxdgHf3EYKVNVFPUgSrVIxhmVYkLnx0S?= =?us-ascii?Q?7FM8/Z+21TVmkdq0ZhV9VYaP5RLYwLyu+eZJBGCV0ANEbsNcXG90nhr2lB8s?= =?us-ascii?Q?pheFVKoWGH5Q2mtZi1mtM1V5KPemLeLNS1/v6cqAX8rafjozpAl5IaFcHV5t?= =?us-ascii?Q?amSEodnjO3RNId0IERIik0E2xKJ8vwRSRo2TtnYDzx6xc8cPyNYvx1sYA5+N?= =?us-ascii?Q?5SpFtd0u9KHKnNLiqhdlmqGyOnTKpkfjmm57lpMRFXtAQ0L5y5+FtOsEY5QV?= =?us-ascii?Q?sP9Mva0qSpwT5m3MTWH3w5rc2Vs/Ekhya2Nn7R1/06u+5u1O90tf0bUhO1WF?= =?us-ascii?Q?OueJQFFt/9a/+w6lPTe6cScUKylkm1YcSBamLpK3JFD/zo7XV4o6QtEGGBV+?= =?us-ascii?Q?UtEiq+W3XwEwH60v8gpL/HnJ8KmxBsN9dYS8v7PAgZQSgxa0l2MY7N9UwjiC?= =?us-ascii?Q?vfJapFLGy/YIFUowpAT9P9FHeGsHNI123rTYXW82lzqSHTgZjXFOYjxJ4HeS?= =?us-ascii?Q?cHlUxRPPiszKUXO1xOhpwU6057zCt1bCyzJdewJLqBeAnbCcrzkzjw+GvZ2z?= =?us-ascii?Q?iLnpB2NJn4MhQQfejQsc1yniU+3wP/2w0ewERGrLkddZ0HmPCH8rPfuK5yf8?= =?us-ascii?Q?1Uc4jykx2ZqF2yfV5KBkehVOiTvfljKTLROUJGbiMZK0r4OzkyVD99qQc7GJ?= =?us-ascii?Q?AtUFL2Xzzf0C//R2wZnh+7wcb5SIHmHsA3s6DQ4D+SYzHYNak5AWI0VzSK1E?= =?us-ascii?Q?8E7FCJF2reE4QM7mJtsapepzS+cFLDGeP715JcMNKWezrYzoVGimWO6sOPY9?= =?us-ascii?Q?pEggr9nc3SFLRAyse70zQYw64XRqSmqfYFP/GaqIiyFAbszVRYcSXX3KqdA3?= =?us-ascii?Q?vsK0qa3C2OSDHH2tOB4c++NChgZxUUxNCCQg8mbOk6DIlqxxdG+wBR2LmHqr?= =?us-ascii?Q?S2dAZv60Bai+m161WX28w3yCxfK+lo5qvqi5YJLCFKMxffI8dMAw2aCRZVx1?= =?us-ascii?Q?4DSrz5P3OMrLewg1foHH6T7Zkj9FGVbE7kOnB4wxrvh0KC9H38/Fp71m/Sot?= =?us-ascii?Q?WbADOdXg5EiSvXL6WuDTNe9E/5ycAQSx3hHCiJmjn/CTltNjrDJhA6sjShym?= =?us-ascii?Q?1hhU3a+yPSZH9jqi7g/9sjFRc6Mxf0r2V4eNDvH/idCyWj+MHGjt+F2t0yKc?= =?us-ascii?Q?cZ8NZVSvXhTid4VI9H8Dk1CHM8UdUYBdkg+n6QC5wmxi20Gg45rZ9xqGodem?= =?us-ascii?Q?vcIXetF/JQtqMGZeOaOQ2EDHtmNaI1iC3tlo/QGNKlJFE8YxVw87XYRtS4UF?= =?us-ascii?Q?HwEKFQ+aTuXXwqQAe/tFxKvsOnhjsYAuEgofuhXXIirr43wWGN5bw/NoWRan?= =?us-ascii?Q?3Oi6nb6e0lUQVdhixGuS06/WWPErd/lf/a40AU1Yzp0UYmW0y2xJcdvtZCfZ?= =?us-ascii?Q?ckKMt8bXyWAG7lqGL2jK/vcVK7oN2y+g/Ox4fthJ4YpYZvQeZqQczwJb4bZH?= =?us-ascii?Q?hxnb7xGQW7dCJ2HCwShaEXpSnyEvcfHcgghH/K20kcdpF7zPOk2JfYGY6KfY?= =?us-ascii?Q?EA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 8lPxhcpp7Fbbu0dO/U+o14FyUW7i45XR8OLMizdaG7t7SYE1RV9GQkyQ5y4CRzEiQ0/vjtJs7T2P1roHI2tb6SX6+Ura+cO7hSesdSDZwQkys9bwB7KJNLnWcZrbfWeRvygkRtllfPxrv5BA6W9EnLeAwAoDUsueP3CcD63FBa+8aubdLNhpUzpY9xXR5wgQT99XMT+a/tSA3e2hQvZEsZXSQBFZZWOv7QH5UOjwPQYMQ3olxla+TsVxqJYSvDvCLp5Y/roelEfKXxkcnFwWM/3m83hRlmsevh+fQ4xmB05hMoLI/r3ErQxO+ys+/TtYZ32/VK8aidjjNSlARkMIDtPv6vEC67c5430KV5aTgrV1oJF4w+noxvcpQo2LSv5ojUaGRMChP65mIGHCi51Gomp3SubNWjgJP3IMKMRf8hp2bNj5YoqTitPsVrfCxZOGU39Oni631LFMfzY8+AfprGsXY+baleAS9yor5peOBYfH0S11QHloMa0BKxuzC1GM5eou69wx6JHJlebzx6qjWn0hWRGF2Yj2OgaPROhUmEkFNzI2f5bBk78dVLX+D46mNEew3G+frw5AD+EVkvO9NCFUW/XwAQ2VVSzQUbtiV3rGhfLLFCtG1Sw5a0/ow1lAG4jI1kFS04+WQe5oZJ2AFFWMBu36Idt63A7uX56YNGiaQ4k57vL0zWvdw/5RAtUKTgrm4CfvhAr2M9i9TvzA8QzsoeMzZ3TF4HZuu04xnE7v+4Pkh7IBOcCE6zQygBD66Kq52H8N90n4JhXRrHtaLS6EU5r+RHfc0kctL/mz+LR9srdJHCztEbwG4kXAPHxHOrIBFuL0gwgJcTai76RBD2AZZMCRElrbtEXhWqEhIkGtoWasNXYKAd1LH8dsTPSFwbfauEs0jceHV1ZsdVXwkZkySZDNHv+OU4mQ1D4oQ/Y= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 547b7b90-a1e0-4e6b-0121-08daffc5eb8f X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 17:51:15.6378 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BRxtFIz5zmNoVveWVkkS22h2E4L0xq4tbfC6Olx5yhrAPoVe6MRBBR3QX9IxzTh6/G7ltihLWVqFkKJ7ljxiWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4151 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-26_08,2023-01-26_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=983 malwarescore=0 mlxscore=0 bulkscore=0 adultscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301260172 X-Proofpoint-GUID: qYBV2ZCl-8L22dEWUeaAAQejyfTHLAmE X-Proofpoint-ORIG-GUID: qYBV2ZCl-8L22dEWUeaAAQejyfTHLAmE X-Rspam-User: X-Rspamd-Queue-Id: BC86E4000F X-Rspamd-Server: rspam01 X-Stat-Signature: pw6aowaede8zf5xhxkcg3s8njfgizgko X-HE-Tag: 1674755501-409268 X-HE-Meta: U2FsdGVkX1/vz235IzEBWOCtRswUHkTDYlBBayoXu/G4URJbxm8yG+3sRWIhJ5b0C0ApjPa3C18pd9yhsB8iHDcGuDePyndoDfNUyLMTfZ8B57sTn9iSEOl+fJ1oxp5Lq/pnrGLzkigfX3yPqjXOH99YDhWZtm/GOTvH1osIsT2pvF1uo4DjCP3tBnJ1uKu7FXy3I9Az/g5D1e7BrJNTV/HkTznQH1JyZ5uFvW60EwqUHvCxO3eOtKsCsI4XK23c9f9cLjI1/non2N5CS8E4cA70czg3fOzOdS9DGMJDF/6bXw5FACFSpLnDd8muGanFyB3gdBo0J9MbcDYqt3gUL0MSxberZW6TU6nfNFMGfV4VNUqdEn8h65x3flfpi+P2dNFUqnzVgYWKFjFUBvq46nEM0rdetjBgwkqZEaMXkQf0S93sSowjjWG6f2N4sO10OFPYifE+wKcU9mXXFS9E6cqRpQM3LpXcaLhYYeMI+6IG4rltA8TWLAH6pEyMB5qUBPVvUD7MsmVBhAXsof5rC6My4haRZLbBo02V0XmSGeYMeXKzT0hivPOQiKaR9hjAxSTPPmeSRXBw16l+WIFaV2TpxSbYoIyXwi2dFEodL+DiZHSaMJckKtukmnNunEU0nSNmhhenDzFWqzvOnNtR3IvPxois9YTqcuq/bb/LGs/+MrUbEJ5sybomY0BWnVcKu+Q7GHanle707QC/kIbc5uNzto6C1+LvBdQqzYYnqCeCs9lxFemzJ8uFqwqvds+yApyHrDGvR5b6M9pgOXfHvVc1Sih6Kp3pkL3hNIGT2CRDDKeiex1iYtI/DxTBO1lbFpEmwZ+38aQfDjZcrOe3lU7gLd3b8VAB3+KffA1x5VRl6DFdD0g9rCgrvAk11kPsslMZCv7YLnOuyAAHVqx8jCyvkxVA+Gb62JFY3YzTpDxzxn56bnwJB57NlV0ktFbaxznDiB2ZB5prm7yCOYf 2pgnW/f0 9NaEAaob0Ka1TKr6GIknS39NghJKHCrtmG7+KA0sxM7EJoryU/A9j3Gt4ZNqQ8d3I5LeCz1239Mv4DJqld8jPGIT9Ze9+J9EsWYYmQ1R62105SFQTWKOnLli3Fjz10ZewuOcu/GG4IvT41m3tDk2fkFMIX1OmnwTmPTTJTfvRm/qf7+mnWufDCCmbf6L4UUXswaPa365ma6q9/SMvEMn87whuqHxpCuOsRLvh8Fy/pohjnV9xSSr2kCHkmYJazFAZ9E3GhXiRbvmYfGKG/FisBLO9BasB8A+TaVRHl5K7Wveo9otNOQoJ8BC3G71f9Sb053hsSArScAzdaBvjM4kC99xYGe430suXskSYgDk4k4+Lm4Qj/VcVp2th7Z5D+S90XSZo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01/26/23 10:16, Michal Hocko wrote: > On Wed 25-01-23 09:59:15, Mike Kravetz wrote: > > On 01/25/23 09:24, Michal Hocko wrote: > > > On Tue 24-01-23 12:56:24, Mike Kravetz wrote: > > > > At first thought this seems bad. However, I believe this has been the > > > > behavior since hugetlb PMD sharing was introduced in 2006 and I am > > > > unaware of any reported issues. I did a audit of code looking at > > > > mapcount. In addition to the above issue with smaps, there appears > > > > to be an issue with 'migrate_pages' where shared pages could be migrated > > > > without appropriate privilege. > > > > > > > > /* With MPOL_MF_MOVE, we migrate only unshared hugepage. */ > > > > if (flags & (MPOL_MF_MOVE_ALL) || > > > > (flags & MPOL_MF_MOVE && page_mapcount(page) == 1)) { > > > > if (isolate_hugetlb(page, qp->pagelist) && > > > > (flags & MPOL_MF_STRICT)) > > > > /* > > > > * Failed to isolate page but allow migrating pages > > > > * which have been queued. > > > > */ > > > > ret = 1; > > > > } > > > > > > Could you elaborate what is problematic about that? The whole pmd > > > sharing is a cooperative thing. So if some of the processes decides to > > > migrate the page then why that should be a problem for others sharing > > > that page via page table? Am I missing something obvious? > > > > Nothing obvious. It is just that the semantics seem to be that you can > > only move shared pages if you have CAP_SYS_NICE. > > Correct > > > Certainly cooperation > > is implied for shared PMDs, but I would guess that most applications are > > not even aware they are sharing PMDs. > > How come? They have to explicitly map those hugetlb pages to the same > address. Or is it common that the mapping just lands there by accident? Mapping to the same address is not required for PMD sharing. What is required is that the alignment of PUD_SIZE offsets within the mapped object (file) are mapped to PUD_SIZE aligned virtual addresses. That may not be clear as it is difficult to describe. Bottom like is that addresses do not need to match. However, I am aware of one DB that maps large hugetlb shared areas at the same virtual address in many processes for application convenience. PMD sharing was not the reason for mapping at the same virtual address, and people developing that DB were not necessarily aware that PMDs were being shared. I also worked on a performance issue with another application making use of large hugetlb mappings that was unaware PMD sharing was happening in their environment. Since PMD sharing is not documented anywhere (except source code), I suspect applications are not aware if they happen make use of shared PMDs. That is the reason for my statement above. > > Consider a group of processes sharing a hugetlb mapping. If the mapping > > is PUD_SIZE - huge_page_size, there is no sharing of PMDs and a process > > without CAP_SYS_NICE can not migrate the shared pages. However, if nothing > > else changes and the mapping size is PUD_SIZE (and appropriately aligned) > > the PMDs are shared. Should we allow a process to migrate shared pages > > without CAP_SYS_NICE in this case? > > I am not sure I follow. I have likely got lost in the above. So the > move_pages interface requires CAP_SYS_NICE to allow moving shared pages. > pmd shared hugetlb pages fail the "I am shared" detection so even > processes without CAP_SYS_NICE are allowed to migrate those. This is not > ideal because somebody unpriviledged (with an access to the address > space) could impose additional latencies. Correct. That is one of the things I will/want to fix. > The question is whether this really matters for workloads that opt-in for > pmd sharing. It is my understanding that those are in cooperative mode > so an adversary player is not a threat model. Or am I wrong in that > assumption? Yes, the argument can be made that processes sharing a large hugetlb object are cooperative and should trust each other. My plan is to simply make the code follow the documented behavior. I would rather not have different user visible behavior for mappings using shared PMDs. And, code changes are rather trivial. > I haven't checked very closely but wouldn't be mprotect a > bigger problem? I do not remember any special casing for hugetlb pmd > sharing there. It is not an issue for mprotect. Any change in protection disables PMD sharing. -- Mike Kravetz