From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB4F7C38142 for ; Fri, 27 Jan 2023 18:04:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F5AC6B0072; Fri, 27 Jan 2023 13:04:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A5F26B0073; Fri, 27 Jan 2023 13:04:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36CF96B0074; Fri, 27 Jan 2023 13:04:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 246AC6B0072 for ; Fri, 27 Jan 2023 13:04:24 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BAB0CAB7CE for ; Fri, 27 Jan 2023 18:04:23 +0000 (UTC) X-FDA: 80401353606.17.38A3F7C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 1858D180016 for ; Fri, 27 Jan 2023 18:04:19 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="FW/URsj5"; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674842662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i0d/AHnGAZVOoNC1mrYJHLs0fJVxQCxbSeSlNV+00YU=; b=vIjvHTXCowwH0Tb4XvuspGKk90TPZvTq8dfeSak1jaofuvoPIC97V5VIMiYoRPIGP8v84E KxhtA6yr1kIU3QkkMkQTaALMVlt8TaWtHoveLqKGNdkEBATnM6djEEuOu1KlDZBt1Sj5mv ZXRWKa2epg09Z+24ntguiW27dVDaVPE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="FW/URsj5"; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674842662; a=rsa-sha256; cv=none; b=4PQNXYz/F6XQvFZ/auANF8iFG7fHBWLxrYfnLbld7kbWcdCUxKnsW5dlW9vYWNcLd5XrD5 s2cwhvoOJPALNfoVzRt55dYXxJFR1lpNGoJPEg5YzuOjPkfVyc63KZWmrLbqab8FWGHop2 ay4E/9hJXeNrmJSwCbHl7MpNN8AWMAw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=i0d/AHnGAZVOoNC1mrYJHLs0fJVxQCxbSeSlNV+00YU=; b=FW/URsj5aCPLSd0Fca58A0zfgv 2u80XboKatxu/hsKTqxNhuBQsXerU36oaLy32OLWbwnueAI6u8XIMshWxZIhG119o+jE/0q2t8X/B Jvj3v/eAzGgr+5WWjfjqlgSR3NWAMBa6cpHs+9NPwDZcbGXvpSgC+e2wBYmj/UMhZyR6p6VwNftYB HanRO+LSvbL3BTE4T3S86cDjiB6yobAASOVTDDgVA9lhHqJIEVzFY3DbM/lsy6a2U+7wNoQFcjaVW IojaQ+N3awDu7PgOy5zJB/VPZVx4rFD2mXf637HJj7sj3FvRWeK9TDnLw2Mw+w5QbGhZasCPd97KH mf9y8VOg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLT4r-007vKQ-Uv; Fri, 27 Jan 2023 18:03:53 +0000 Date: Fri, 27 Jan 2023 18:03:53 +0000 From: Matthew Wilcox To: "Fabio M. De Francesco" Cc: Andrew Morton , Ira Weiny , Sebastian Andrzej Siewior , Alexander Potapenko , Andrey Konovalov , Tony Luck , Bagas Sanjaya , David Sterba , Kees Cook , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Thomas Gleixner , Al Viro , Helge Deller Subject: Re: [PATCH] mm/highmem: Align-down to page the address for kunmap_flush_on_unmap() Message-ID: References: <20230126143346.12086-1-fmdefrancesco@gmail.com> <1920277.PYKUYFuaPT@suse> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1920277.PYKUYFuaPT@suse> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1858D180016 X-Stat-Signature: dmizjoey9zygoxojawoz1nnspmtd5t38 X-HE-Tag: 1674842659-640147 X-HE-Meta: U2FsdGVkX1/pl2RsLSdbNFUZIQLb+Y9IiewAoGlVIy0kOq94KRWiQ1rkUh5t1TXCOGkU0Sv2dy4c+2pKKReXBi6prgt8a9NL4LaJ69oa3tofeiNrRYCx3LQpI37GfvHzyn89KM0Tb5xhK0Es+fMHcNZeGIdOYIcY308ldhBRxMH4NgTR6arPzF/KxMhDaI8sxk2BX96hrR28KJCq2mOqzLJFTUImscC4KE3A9YhVvLDyj5+gP7lc2j5o9QFBXhS6y0uhfapET6jKhsvCIQwnvYGFShoo/rGVAdgDoq9JBPDVuTqk1FIVwlVvPw5sgoWB66peMvvLl/g2oEObWbbfYaY298HkbvFnNwXW9NybY3ha66bPzwFB+4xxgI+3kIiFjFzxd2Q4M5M5tWxLivhCxllCeCWuw6eKLgJbCDLJzQsluzd6wMkNx9LunzjskkF//oS66mhfZkk36pX6JI5bqYldZmC/4xFLe1Sl7IVy4sMCGVd7Eow+BsWF3QEmcYygXkwwFL51LhDQJKzCkhmFrvmAe4Yovd53RnlOflAN9Kbv2uGyy8L6CVv+yBkghwdoh56v7Qkva0cULV/VB16C1l4mxQlsfS8eYwoFl4MGhqUUPDDIFNDukP9xsRAvvqcPvNqdY6Pjxx1+hZuUDOhs2PmWkN24OwFKI/1u906pU0669X9vRfjD2KaEP5KPvx679Guhk2SMETaHqYBseUlPLCMAaeTM55/GHklhbkXBc1L3Gbn1nbFSB+ct2dLZap8UGUAXo7dphe9YKtgoxK+c1xvur3Ayu/wq6ssBkhyvKZSpVggDoqCarPNQiyVbTiymguApFiXFXmtJCkipjz7cbmCS6/LEQIdCLp4p8ZOomdmnybZ3HBqhYjq4cdz7lUhGXtTPSBpSMfMQde1oC6GJAop4VdT7WFNNVzHO+J9OQyUB5lw15jXJbdLVWK1MhmKSxB/Lczig9y2/8fBp0Vx brPs6Qc4 LOUVPFTZO8e0IT09d1D77kn43MtJJaFojy068MTYB153K9t1S0Ec1NdzeSIw9GpYJjZ1NLFS7ludbXXAUickFVIVCGokxXc4jr4w1alnfblDS9F3BKyIDEwYYZTggoeijyn3/AHNRxQSvZTh9NbjxkWQyxu1nnN4xKsw0M/badueDymldi9er0ylMMhzAklRbk2Uq2RT8SeTDtq7PWAHkNWiyq6qCYrc57u64Yy4jf1YxzM+okkkvdF1NkM2oBfHs6JC5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 27, 2023 at 06:58:55PM +0100, Fabio M. De Francesco wrote: > On giovedì 26 gennaio 2023 21:07:53 CET Matthew Wilcox wrote: > > On Thu, Jan 26, 2023 at 03:33:46PM +0100, Fabio M. De Francesco wrote: > > > If ARCH_HAS_FLUSH_ON_KUNMAP is defined (PA-RISC case), __kunmap_local() > > > calls kunmap_flush_on_unmap(). The latter currently flushes the wrong > > > address (as confirmed by Matthew Wilcox and Helge Deller). Al Viro > > > proposed to call kunmap_flush_on_unmap() on an aligned-down to page > > > address in order to fix this issue. Consensus has been reached on this > > > solution. > > > > > > Therefore, if ARCH_HAS_FLUSH_ON_KUNMAP is defined, call > > > kunmap_flush_on_unmap() on an aligned-down to page address computed with > > > the PTR_ALIGN_DOWN() macro. > > > > You missed a spot. Sent the version I've had in my tree for a few days. > > I'm sorry for missing the other call site. > Furthermore, your patch has a better commit message. > > However, I'm also sorry because I would have expected a different kind of > support from you. My patch could have been improved with v2. > > Anyway, I assume that you missed that I had asked you and Al if anybody were > interested in doing these changes and probably you missed also that Ira > encouraged me to send a patch, whereas you did not show any interest... > https://lore.kernel.org/lkml/3146373.5fSG56mABF@suse/ Sorry; I get too much email and I missed the last six emails in that thread (just went back and read them). According to git, I committed this patch to my tree on Jan 20th, so if I'd read your email, I would have told you to not bother.