linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Hyeonggon Yoo <42.hyeyoo@gmail.com>
To: linux-mm@kvack.org
Cc: akpm@linux-foundation.org, Huang Ying <ying.huang@intel.com>,
	Zi Yan <ziy@nvidia.com>, Yang Shi <shy828301@gmail.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Oscar Salvador <osalvador@suse.de>,
	Matthew Wilcox <willy@infradead.org>,
	Bharata B Rao <bharata@amd.com>,
	Alistair Popple <apopple@nvidia.com>,
	haoxin <xhao@linux.alibaba.com>, Minchan Kim <minchan@kernel.org>
Subject: [BISECTED] first bad commit is c203c6d5b3f0597 ("migrate_pages: batch _unmap and _move")
Date: Wed, 1 Feb 2023 02:35:55 +0900	[thread overview]
Message-ID: <Y9lRezBFOtLuQF0O@hyeyoo> (raw)
In-Reply-To: <Y9k9Jl9wIaUFZS30@hyeyoo>

On Wed, Feb 01, 2023 at 01:09:10AM +0900, Hyeonggon Yoo wrote:
> I've observed random list_del corruption on mm-unstable,
> where HEAD is commit d69862e693c069f4
> ("mm/migrate: convert putback_movable_pages() to use folios").
> 
> The issue can be easily reproduced by stressing MM multiple times:
> 	stress-ng --bigheap 0 --timeout 300
> 
> The compiler is gcc 12.2.1 and config, dmesg are included as attachment.
> I will try to bisect but can't promise quick resolution :)


The first bad commits appears to be:
c203c6d5b3f0597 ("migrate_pages: batch _unmap and _move")

the first bad commit _probably_ be earlier, but this is quite
easy to reproduce so at this point I think above is the real bad commit.

Here's bisect log:

[hyeyoo@hyeyoo linux]$ git bisect log
git bisect start
# status: waiting for both good and bad commits
# bad: [d69862e693c069f4f67fc55c159ce5f6c6def42f] mm/migrate: convert putback_movable_pages() to use folios
git bisect bad d69862e693c069f4f67fc55c159ce5f6c6def42f
# status: waiting for good commit(s), bad commit known
# good: [5dc4c995db9eb45f6373a956eb1f69460e69e6d4] Linux 6.2-rc4
git bisect good 5dc4c995db9eb45f6373a956eb1f69460e69e6d4
# good: [b81cc59c6835bb84e72f1ce516121f25780a42cb] shmem: convert shmem_write_end() to use a folio
git bisect good b81cc59c6835bb84e72f1ce516121f25780a42cb
# bad: [1e2a127908bdbc11065bc08200d0add096d96245] mm: multi-gen LRU: improve walk_pmd_range()
git bisect bad 1e2a127908bdbc11065bc08200d0add096d96245c203c6d5b3f0597
# good: [4d2eba3fd7c0b3ada6b474e4f13dc1238670ea91] ceph: convert ceph_writepages_start() to use filemap_get_folios_tag()
git bisect good 4d2eba3fd7c0b3ada6b474e4f13dc1238670ea91
# good: [b22d808ef6c68b6fa2b5a97f5d02e83ab8fb732d] migrate_pages: separate hugetlb folios migration
git bisect good b22d808ef6c68b6fa2b5a97f5d02e83ab8fb732d
# bad: [6d8b6b69ee6a24a89f2552a12e43b7c9b3a7635d] mm/hugetlb: fix get_hwpoison_hugetlb_folio() stub
git bisect bad 6d8b6b69ee6a24a89f2552a12e43b7c9b3a7635d
# bad: [71d4be767f5fde1ac5df2ade1f654f19c24a0a3e] mm/damon/core: skip apply schemes if empty
git bisect bad 71d4be767f5fde1ac5df2ade1f654f19c24a0a3e
# bad: [68611caff673fc59c17f00dcd0cab2704987828d] migrate_pages: move migrate_folio_unmap()
git bisect bad 68611caff673fc59c17f00dcd0cab2704987828d
# good: [7199465b2be061f1b2bd6b5a1a5a96a822f658b9] migrate_pages: split unmap_and_move() to _unmap() and _move()
git bisect good 7199465b2be061f1b2bd6b5a1a5a96a822f658b9
# bad: [c203c6d5b3f0597a15137b6394fa715542df78c8] migrate_pages: batch _unmap and _move
git bisect bad c203c6d5b3f0597a15137b6394fa715542df78c8
# first bad commit: [c203c6d5b3f0597a15137b6394fa715542df78c8] migrate_pages: batch _unmap and _move


       reply	other threads:[~2023-01-31 17:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Y9k9Jl9wIaUFZS30@hyeyoo>
2023-01-31 17:35 ` Hyeonggon Yoo [this message]
2023-01-31 22:45   ` [BISECTED] first bad commit is c203c6d5b3f0597 ("migrate_pages: batch _unmap and _move") Andrew Morton
2023-02-01 23:28   ` Huang, Ying
2023-02-02 23:17     ` Huang, Ying
2023-02-03 14:17       ` Hyeonggon Yoo
2023-02-03 15:02         ` Huang, Ying
2023-02-05 14:38           ` Hyeonggon Yoo
2023-02-06  6:25             ` Huang, Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9lRezBFOtLuQF0O@hyeyoo \
    --to=42.hyeyoo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=bharata@amd.com \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=osalvador@suse.de \
    --cc=shy828301@gmail.com \
    --cc=willy@infradead.org \
    --cc=xhao@linux.alibaba.com \
    --cc=ying.huang@intel.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).