From: Lorenzo Stoakes <lstoakes@gmail.com>
To: Baoquan He <bhe@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, stephen.s.brennan@oracle.com,
urezki@gmail.com, willy@infradead.org, hch@infradead.org,
error27@gmail.com
Subject: Re: [PATCH v4 4/7] mm/vmalloc: explicitly identify vm_map_ram area when shown in /proc/vmcoreinfo
Date: Wed, 1 Feb 2023 20:17:43 +0000 [thread overview]
Message-ID: <Y9rI5zuZIX3WvzSY@lucifer> (raw)
In-Reply-To: <20230201091339.61761-5-bhe@redhat.com>
On Wed, Feb 01, 2023 at 05:13:36PM +0800, Baoquan He wrote:
> Now, by marking VMAP_RAM in vmap_area->flags for vm_map_ram area, we can
> clearly differentiate it with other vmalloc areas. So identify
> vm_map_area area by checking VMAP_RAM of vmap_area->flags when shown
> in /proc/vmcoreinfo.
>
> Meanwhile, the code comment above vm_map_ram area checking in s_show()
> is not needed any more, remove it here.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> ---
> mm/vmalloc.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 5a3ea6cb7ec2..e515dbacb0cb 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -4232,14 +4232,11 @@ static int s_show(struct seq_file *m, void *p)
>
> va = list_entry(p, struct vmap_area, list);
>
> - /*
> - * s_show can encounter race with remove_vm_area, !vm on behalf
> - * of vmap area is being tear down or vm_map_ram allocation.
> - */
> if (!va->vm) {
> - seq_printf(m, "0x%pK-0x%pK %7ld vm_map_ram\n",
> - (void *)va->va_start, (void *)va->va_end,
> - va->va_end - va->va_start);
> + if (va->flags & VMAP_RAM)
> + seq_printf(m, "0x%pK-0x%pK %7ld vm_map_ram\n",
> + (void *)va->va_start, (void *)va->va_end,
> + va->va_end - va->va_start);
>
> goto final;
> }
> --
> 2.34.1
>
Reviewed-by: Lorenzo Stoakes <lstoakes@gmail.com>
next prev parent reply other threads:[~2023-02-01 20:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 9:13 [PATCH v4 0/7] mm/vmalloc.c: allow vread() to read out vm_map_ram areas Baoquan He
2023-02-01 9:13 ` [PATCH v4 1/7] mm/vmalloc.c: add used_map into vmap_block to track space of vmap_block Baoquan He
2023-02-01 9:13 ` [PATCH v4 2/7] mm/vmalloc.c: add flags to mark vm_map_ram area Baoquan He
2023-02-01 9:13 ` [PATCH v4 3/7] mm/vmalloc.c: allow vread() to read out vm_map_ram areas Baoquan He
2023-02-01 20:16 ` Lorenzo Stoakes
2023-02-02 3:20 ` Baoquan He
2023-02-02 7:17 ` Lorenzo Stoakes
2023-02-02 13:18 ` Baoquan He
2023-02-01 9:13 ` [PATCH v4 4/7] mm/vmalloc: explicitly identify vm_map_ram area when shown in /proc/vmcoreinfo Baoquan He
2023-02-01 20:17 ` Lorenzo Stoakes [this message]
2023-02-01 9:13 ` [PATCH v4 5/7] mm/vmalloc: skip the uninitilized vmalloc areas Baoquan He
2023-02-01 9:13 ` [PATCH v4 6/7] powerpc: mm: add VM_IOREMAP flag to the vmalloc area Baoquan He
2023-02-01 9:13 ` [PATCH v4 7/7] sh: mm: set " Baoquan He
2023-02-02 17:47 ` [PATCH v4 0/7] mm/vmalloc.c: allow vread() to read out vm_map_ram areas Stephen Brennan
2023-02-04 4:12 ` Baoquan He
2023-02-04 23:13 ` Andrew Morton
2023-02-06 8:43 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9rI5zuZIX3WvzSY@lucifer \
--to=lstoakes@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=error27@gmail.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stephen.s.brennan@oracle.com \
--cc=urezki@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).