From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9796CC43381 for ; Mon, 8 Feb 2021 11:06:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 319BE64E3F for ; Mon, 8 Feb 2021 11:06:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 319BE64E3F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 985A86B0073; Mon, 8 Feb 2021 06:06:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 90EB26B0074; Mon, 8 Feb 2021 06:06:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D6D46B0078; Mon, 8 Feb 2021 06:06:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id 6219E6B0073 for ; Mon, 8 Feb 2021 06:06:50 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 297F4180AD802 for ; Mon, 8 Feb 2021 11:06:50 +0000 (UTC) X-FDA: 77794822980.03.pipe60_0d05f18275fe Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 0B1CE28A4E9 for ; Mon, 8 Feb 2021 11:06:50 +0000 (UTC) X-HE-Tag: pipe60_0d05f18275fe X-Filterd-Recvd-Size: 6145 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Mon, 8 Feb 2021 11:06:49 +0000 (UTC) Received: by mail-wm1-f41.google.com with SMTP id w4so12193860wmi.4 for ; Mon, 08 Feb 2021 03:06:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YCKQyJ5X4pSKK2TbNsb8boRdw0GR7LFT4BRguWXjjyI=; b=NG8H9UUSvX43gPqT7atIFiGW1Hf53RneCc9N82ovlTQDtkdhQjLF8xI+K74EFIihsg 0hgVdQ/g29wTbAtYid5lHzGLlbCzDYlJL6GyhxueutxhN+/5WNFvx5HCs0dTlhw71siV uuIDAMP0uwNGhGygPzSU9wnnEx69GfK/+J1RTqLjPrimI9+07hU43gHJsbYkOx1AQcZ2 QurDBUSrVL80e3UI0evOOFZeGalicP4M7F8d5q8T6TohLso4uyBzQokgCwFoNhWqLHYB vt99Fiavcx0CnqAJBspQ8tdIsUQD+5UKuzyp8SXKkv/HRvDcmoJ28ZTuC0+3G+Cnu9g8 FCvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YCKQyJ5X4pSKK2TbNsb8boRdw0GR7LFT4BRguWXjjyI=; b=cG+FnMEWKCcFOZJyacSJtoaaCsav29QEjdTPOR4WOyOO9TUdR6PN56tR6jl/xqFsHk s5mDUvMqkH6txOUpBZ5vz0Gw6Wu/tVtZsR/tifW+fvlaFNVKReVtOiIXdYWpGkGXVKfO sEZf2WPf5ISy08R6YjIqhW84Q+rNr9EorfohbbkE5U9Y3QbewTamMb0w0CRoQ2wt/M6w I2vc7MXvBh55CmQKDH8azupXPjm8ZzuI+NRBZfsPeupVo/DWA/lcdTusQpkAK1B9fIWc V3jrLCMsuWpMTC8Mim+zG5jAfSGA0SMQAqI1HYutSHEWMxEkdtoObmtHlSUpbVvQ1XZa QqTQ== X-Gm-Message-State: AOAM533mrtTDH3YPRlK4lOfmx1/l6o/tkM/X0Lazl94YsRAsmsXKwump D+nzF2FPCJyIqGvvj2fII6d4ag== X-Google-Smtp-Source: ABdhPJycTndKfO4Hva6eoih56akIcC3ZddjnlFN+i/+r1mkgFIHQuNb7jnV4Lpigvq1x76HTJHnLOg== X-Received: by 2002:a05:600c:4f4d:: with SMTP id m13mr14358030wmq.118.1612782408117; Mon, 08 Feb 2021 03:06:48 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:497f:76ef:2e62:d028]) by smtp.gmail.com with ESMTPSA id g16sm19401367wmi.30.2021.02.08.03.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 03:06:47 -0800 (PST) Date: Mon, 8 Feb 2021 12:06:41 +0100 From: Marco Elver To: Andrey Konovalov Cc: Andrew Morton , Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 mm 13/13] kasan: clarify that only first bug is reported in HW_TAGS Message-ID: References: <00383ba88a47c3f8342d12263c24bdf95527b07d.1612546384.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00383ba88a47c3f8342d12263c24bdf95527b07d.1612546384.git.andreyknvl@google.com> User-Agent: Mutt/2.0.2 (2020-11-20) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 05, 2021 at 06:34PM +0100, Andrey Konovalov wrote: > Hwardware tag-based KASAN only reports the first found bug. After that MTE > tag checking gets disabled. Clarify this in comments and documentation. > > Signed-off-by: Andrey Konovalov Reviewed-by: Marco Elver > --- > Documentation/dev-tools/kasan.rst | 8 ++++++-- > mm/kasan/hw_tags.c | 2 +- > 2 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/Documentation/dev-tools/kasan.rst b/Documentation/dev-tools/kasan.rst > index e022b7506e37..1faabbe23e09 100644 > --- a/Documentation/dev-tools/kasan.rst > +++ b/Documentation/dev-tools/kasan.rst > @@ -155,7 +155,7 @@ Boot parameters > ~~~~~~~~~~~~~~~ > > Hardware tag-based KASAN mode (see the section about various modes below) is > -intended for use in production as a security mitigation. Therefore it supports > +intended for use in production as a security mitigation. Therefore, it supports > boot parameters that allow to disable KASAN competely or otherwise control > particular KASAN features. > > @@ -166,7 +166,8 @@ particular KASAN features. > ``off``). > > - ``kasan.fault=report`` or ``=panic`` controls whether to only print a KASAN > - report or also panic the kernel (default: ``report``). > + report or also panic the kernel (default: ``report``). Note, that tag > + checking gets disabled after the first reported bug. > > For developers > ~~~~~~~~~~~~~~ > @@ -296,6 +297,9 @@ Note, that enabling CONFIG_KASAN_HW_TAGS always results in in-kernel TBI being > enabled. Even when kasan.mode=off is provided, or when the hardware doesn't > support MTE (but supports TBI). > > +Hardware tag-based KASAN only reports the first found bug. After that MTE tag > +checking gets disabled. > + > What memory accesses are sanitised by KASAN? > -------------------------------------------- > > diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c > index e529428e7a11..6c9285c906b8 100644 > --- a/mm/kasan/hw_tags.c > +++ b/mm/kasan/hw_tags.c > @@ -48,7 +48,7 @@ EXPORT_SYMBOL(kasan_flag_enabled); > /* Whether to collect alloc/free stack traces. */ > DEFINE_STATIC_KEY_FALSE(kasan_flag_stacktrace); > > -/* Whether panic or disable tag checking on fault. */ > +/* Whether to panic or print a report and disable tag checking on fault. */ > bool kasan_flag_panic __ro_after_init; > > /* kasan=off/on */ > -- > 2.30.0.365.g02bc693789-goog >