From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96AEAC43460 for ; Wed, 7 Apr 2021 23:05:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 28CC161181 for ; Wed, 7 Apr 2021 23:05:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28CC161181 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gentoo.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 87EB36B007D; Wed, 7 Apr 2021 19:05:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82ED06B007E; Wed, 7 Apr 2021 19:05:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F7F06B0080; Wed, 7 Apr 2021 19:05:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id 54E356B007D for ; Wed, 7 Apr 2021 19:05:44 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0B4A92C68 for ; Wed, 7 Apr 2021 23:05:44 +0000 (UTC) X-FDA: 78007105008.29.BBE665F Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by imf13.hostedemail.com (Postfix) with ESMTP id 87972E000114 for ; Wed, 7 Apr 2021 23:05:41 +0000 (UTC) Received: by sf.home (Postfix, from userid 1000) id 5ABD95A22061; Thu, 8 Apr 2021 00:05:37 +0100 (BST) Date: Thu, 8 Apr 2021 00:05:37 +0100 From: Sergei Trofimovich To: Vlastimil Babka Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: page_poison: print page owner info when corruption is caught Message-ID: References: <20210404141735.2152984-1-slyfox@gentoo.org> <2f0d1127-8868-f8a3-203f-2c3d473bd496@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f0d1127-8868-f8a3-203f-2c3d473bd496@suse.cz> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 87972E000114 X-Stat-Signature: 3faj1hqi7efu96r74shc9y7sbzwfpmai Received-SPF: none (gentoo.org>: No applicable sender policy available) receiver=imf13; identity=mailfrom; envelope-from=""; helo=smtp.gentoo.org; client-ip=140.211.166.183 X-HE-DKIM-Result: none/none X-HE-Tag: 1617836741-815182 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 07, 2021 at 02:15:50PM +0200, Vlastimil Babka wrote: > On 4/4/21 4:17 PM, Sergei Trofimovich wrote: > > When page_poison detects page corruption it's useful to see who > > freed a page recently to have a guess where write-after-free > > corruption happens. > > > > After this change corruption report has extra page_owner data. > > Example report from real corruption: > > > > pagealloc: memory corruption > > e00000014cd61d10: 11 00 00 00 00 00 00 00 30 1d d2 ff ff 0f 00 60 > > e00000014cd61d20: b0 1d d2 ff ff 0f 00 60 90 fe 1c 00 08 00 00 20 > > ... > > CPU: 1 PID: 220402 Comm: cc1plus Not tainted 5.12.0-rc5-00107-g9720c6f59ecf #245 > > Hardware name: hp server rx3600, BIOS 04.03 04/08/2008 > > ... > > Call Trace: > > [] show_stack+0x90/0xc0 > > [] dump_stack+0x150/0x1c0 > > [] __kernel_unpoison_pages+0x410/0x440 > > [] get_page_from_freelist+0x1460/0x2ca0 > > [] __alloc_pages_nodemask+0x3c0/0x660 > > [] alloc_pages_vma+0xb0/0x500 > > [] __handle_mm_fault+0x1230/0x1fe0 > > [] handle_mm_fault+0x310/0x4e0 > > [] ia64_do_page_fault+0x1f0/0xb80 > > [] ia64_leave_kernel+0x0/0x270 > > page_owner tracks the page as freed > > page allocated via order 0, migratetype Movable, > > gfp_mask 0x100dca(GFP_HIGHUSER_MOVABLE|__GFP_ZERO), pid 37, ts 8173444098740 > > __reset_page_owner+0x40/0x200 > > free_pcp_prepare+0x4d0/0x600 > > free_unref_page+0x20/0x1c0 > > __put_page+0x110/0x1a0 > > migrate_pages+0x16d0/0x1dc0 > > compact_zone+0xfc0/0x1aa0 > > proactive_compact_node+0xd0/0x1e0 > > kcompactd+0x550/0x600 > > kthread+0x2c0/0x2e0 > > call_payload+0x50/0x80 > > > > Here we can see that page was freed by page migration but something > > managed to write to it afterwards. > > > > CC: Andrew Morton > > CC: linux-mm@kvack.org > > Signed-off-by: Sergei Trofimovich > > --- > > mm/page_poison.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/mm/page_poison.c b/mm/page_poison.c > > index 65cdf844c8ad..ef2a1eab13d7 100644 > > --- a/mm/page_poison.c > > +++ b/mm/page_poison.c > > @@ -4,6 +4,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -45,7 +46,7 @@ static bool single_bit_flip(unsigned char a, unsigned char b) > > return error && !(error & (error - 1)); > > } > > > > -static void check_poison_mem(unsigned char *mem, size_t bytes) > > +static void check_poison_mem(struct page *page, unsigned char *mem, size_t bytes) > > { > > static DEFINE_RATELIMIT_STATE(ratelimit, 5 * HZ, 10); > > unsigned char *start; > > @@ -70,6 +71,7 @@ static void check_poison_mem(unsigned char *mem, size_t bytes) > > print_hex_dump(KERN_ERR, "", DUMP_PREFIX_ADDRESS, 16, 1, start, > > end - start + 1, 1); > > dump_stack(); > > + dump_page_owner(page); > > OK but why not a full dump_page()? Oh, I did not know it existed! Looks even better. Will send a v2 with dump_page(). > > } > > > > static void unpoison_page(struct page *page) > > @@ -82,7 +84,7 @@ static void unpoison_page(struct page *page) > > * that is freed to buddy. Thus no extra check is done to > > * see if a page was poisoned. > > */ > > - check_poison_mem(addr, PAGE_SIZE); > > + check_poison_mem(page, addr, PAGE_SIZE); > > kunmap_atomic(addr); > > } > > > > > -- Sergei