From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 778F2C43462 for ; Thu, 8 Apr 2021 09:56:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EE42861166 for ; Thu, 8 Apr 2021 09:56:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE42861166 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 63A126B0078; Thu, 8 Apr 2021 05:56:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E9F66B007E; Thu, 8 Apr 2021 05:56:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48C206B0080; Thu, 8 Apr 2021 05:56:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id 2B7626B0078 for ; Thu, 8 Apr 2021 05:56:16 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CF3E712F7 for ; Thu, 8 Apr 2021 09:56:15 +0000 (UTC) X-FDA: 78008744310.37.B767BB7 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf09.hostedemail.com (Postfix) with ESMTP id 8CA806000102 for ; Thu, 8 Apr 2021 09:56:13 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id BF61761157; Thu, 8 Apr 2021 09:56:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617875774; bh=qJxRS7vx1sXE6xcXQMcJdpuIhDNb8doWc5nvVib8CKg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KZ/oVYIMYnAgYH6QJVktZeIA6/aSYiWme3mBgwnkCxayRdrH5xziAm66YyvKrRth7 7v9gmEr4vet9wOPetc8R4/QVlcGIuJddziUeRsFMPVcGZa22P9mvPmv43q1B6aD+Js Z0e/fme4iIuOE27WCM3w3jK+/81p4DNorwJ+lgUEckK3vbax8fc4dOwWS9QFQ50bHB QomrNySbhnrnJqtGC3+M/ApvRrBBJ3ceKHuJulDCYWyiIvtQy3nj4mRUzMnqnyL+hH vDqGLXtnBvDVuKNFVaO2Flj0rH/To18bMy5Xeu6DijPGj4p0ZU4/aKk0Y4ceO01yyY OTrdegR9Enwbw== Date: Thu, 8 Apr 2021 12:56:02 +0300 From: Mike Rapoport To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joel Stanley , David Airlie , Daniel Vetter , Andrew Jeffery , Lucas Stach , Russell King , Christian Gmeiner , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Linus Walleij , Michal Simek , Masahiro Yamada , Randy Dunlap , Peter Collingbourne , linux-aspeed@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v1 1/2] drivers/video/fbdev: don't select DMA_CMA Message-ID: References: <20210408092011.52763-1-david@redhat.com> <20210408092011.52763-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210408092011.52763-2-david@redhat.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8CA806000102 X-Stat-Signature: f1k1bjim6yw336zw7ifbc7sk45zdf873 Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf09; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617875773-196667 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 08, 2021 at 11:20:10AM +0200, David Hildenbrand wrote: > Random drivers should not override a user configuration of core knobs > (e.g., CONFIG_DMA_CMA=n). Use "imply" instead, to still respect > dependencies and manual overrides. > > "This is similar to "select" as it enforces a lower limit on another > symbol except that the "implied" symbol's value may still be set to n > from a direct dependency or with a visible prompt." > > Implying DRM_CMA should be sufficient, as that depends on CMA. ^ DMA_CMA ? > Note: If this is a real dependency, we should use "depends on DMA_CMA" > instead - but I assume the driver can work without CMA just fine -- > esp. when we wouldn't have HAVE_DMA_CONTIGUOUS or CMA right now. > > Signed-off-by: David Hildenbrand > --- > drivers/video/fbdev/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index 4f02db65dede..d37cd5341e1b 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -2186,7 +2186,7 @@ config FB_HYPERV > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > select FB_DEFERRED_IO > - select DMA_CMA if HAVE_DMA_CONTIGUOUS && CMA > + imply DMA_CMA > help > This framebuffer driver supports Microsoft Hyper-V Synthetic Video. > > -- > 2.30.2 > -- Sincerely yours, Mike.