From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10D23C43461 for ; Thu, 8 Apr 2021 09:57:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AE4E66115B for ; Thu, 8 Apr 2021 09:57:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE4E66115B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2DDAD6B007E; Thu, 8 Apr 2021 05:57:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B6846B0080; Thu, 8 Apr 2021 05:57:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17EB86B0081; Thu, 8 Apr 2021 05:57:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id F2D2C6B007E for ; Thu, 8 Apr 2021 05:57:06 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id AA2B88248047 for ; Thu, 8 Apr 2021 09:57:06 +0000 (UTC) X-FDA: 78008746452.18.45AA0E9 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf30.hostedemail.com (Postfix) with ESMTP id 005F5E00010C for ; Thu, 8 Apr 2021 09:56:59 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4033D61157; Thu, 8 Apr 2021 09:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617875825; bh=B9VmDawrhjCMWY2yGvON7ogRQ50zM9AwDtPYvXCem5k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FTkpQBgo9w1COX/6jC/2u6P6RPCFA3tl6nGA5eG1RXJ+BaGjbmejJvvhO2Wn4ubvY rectMFGrHL2U66R4DbeV9l+9RMlorb8xZTWUEO7XYTlIoG78fJ/zcvyr6GoIcFgUzV 1RI22L8vsHQobVRIPzTSH9jw6UreGs04bFWxoADonEXJATx0A5LVon+uNz1KpcI+GC CeThnXDwU1DqxG8dcatSuycQeCk91qekdglfyahw14UVVPYSYkvt43sh40htngiecU O4BYaHTbk5u+7OXjoV+cnzy0Jb49t3KY9TppRDBLCZXL6YC1s5Z9Nzwrnc69D0FS9k IU18T2Ns6ybSQ== Date: Thu, 8 Apr 2021 12:56:53 +0300 From: Mike Rapoport To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joel Stanley , David Airlie , Daniel Vetter , Andrew Jeffery , Lucas Stach , Russell King , Christian Gmeiner , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Linus Walleij , Michal Simek , Masahiro Yamada , Randy Dunlap , Peter Collingbourne , linux-aspeed@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv Message-ID: References: <20210408092011.52763-1-david@redhat.com> <20210408092011.52763-3-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210408092011.52763-3-david@redhat.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 005F5E00010C X-Stat-Signature: i67a7fbksgtqdwfpzifb4ebd6ssotkr6 Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf30; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617875819-888259 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 08, 2021 at 11:20:11AM +0200, David Hildenbrand wrote: > Random drivers should not override a user configuration of core knobs > (e.g., CONFIG_DMA_CMA=n). Use "imply" instead, to still respect > dependencies and manual overrides. > > "This is similar to "select" as it enforces a lower limit on another > symbol except that the "implied" symbol's value may still be set to n > from a direct dependency or with a visible prompt." > > Implying DRM_CMA should be sufficient, as that depends on CMA. ^ DMA_CMA > > Note: If this is a real dependency, we should use "depends on DMA_CMA" > instead - but I assume the driver can work without CMA just fine -- > esp. when we wouldn't have HAVE_DMA_CONTIGUOUS right now. > > Signed-off-by: David Hildenbrand > --- > drivers/gpu/drm/aspeed/Kconfig | 3 +-- > drivers/gpu/drm/etnaviv/Kconfig | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/aspeed/Kconfig b/drivers/gpu/drm/aspeed/Kconfig > index 5e95bcea43e9..a055f763d230 100644 > --- a/drivers/gpu/drm/aspeed/Kconfig > +++ b/drivers/gpu/drm/aspeed/Kconfig > @@ -6,9 +6,8 @@ config DRM_ASPEED_GFX > depends on MMU > select DRM_KMS_HELPER > select DRM_KMS_CMA_HELPER > - select DMA_CMA if HAVE_DMA_CONTIGUOUS > - select CMA if HAVE_DMA_CONTIGUOUS > select MFD_SYSCON > + imply DRM_CMA Ditto > help > Chose this option if you have an ASPEED AST2500 SOC Display > Controller (aka GFX). > diff --git a/drivers/gpu/drm/etnaviv/Kconfig b/drivers/gpu/drm/etnaviv/Kconfig > index faa7fc68b009..5f5576b7221a 100644 > --- a/drivers/gpu/drm/etnaviv/Kconfig > +++ b/drivers/gpu/drm/etnaviv/Kconfig > @@ -9,9 +9,8 @@ config DRM_ETNAVIV > select THERMAL if DRM_ETNAVIV_THERMAL > select TMPFS > select WANT_DEV_COREDUMP > - select CMA if HAVE_DMA_CONTIGUOUS > - select DMA_CMA if HAVE_DMA_CONTIGUOUS > select DRM_SCHED > + imply DMA_CMA > help > DRM driver for Vivante GPUs. > > -- > 2.30.2 > -- Sincerely yours, Mike.