From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A660C433DB for ; Mon, 29 Mar 2021 09:01:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 67DBD61581 for ; Mon, 29 Mar 2021 09:01:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67DBD61581 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AD4356B007D; Mon, 29 Mar 2021 05:01:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AAAF26B007E; Mon, 29 Mar 2021 05:01:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 924626B0080; Mon, 29 Mar 2021 05:01:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id 75B226B007D for ; Mon, 29 Mar 2021 05:01:42 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 33D7B181AEF32 for ; Mon, 29 Mar 2021 09:01:42 +0000 (UTC) X-FDA: 77972318844.16.F5EC776 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf05.hostedemail.com (Postfix) with ESMTP id 3C5EAE037D9B for ; Mon, 29 Mar 2021 09:00:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C6365B3C1; Mon, 29 Mar 2021 09:00:38 +0000 (UTC) Received: from localhost (brahms [local]) by brahms (OpenSMTPD) with ESMTPA id 637eba85; Mon, 29 Mar 2021 09:01:59 +0000 (UTC) Date: Mon, 29 Mar 2021 10:01:58 +0100 From: Luis Henriques To: Matthew Wilcox Cc: "Kirill A. Shutemov" , Miklos Szeredi , Vlastimil Babka , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm Subject: Re: fuse: kernel BUG at mm/truncate.c:763! Message-ID: References: <20210312131123.GZ3479805@casper.infradead.org> <20210315110659.GT2577561@casper.infradead.org> <20210318110302.nxddmrhmgmlw4adq@black.fi.intel.com> <20210318115543.GM3420@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: X-Stat-Signature: prc4yzb1azy5anfo4fo56noq557ugzfj X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3C5EAE037D9B Received-SPF: none (suse.de>: No applicable sender policy available) receiver=imf05; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1617008441-397192 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 19, 2021 at 09:02:33AM +0000, Luis Henriques wrote: > On Thu, Mar 18, 2021 at 11:55:43AM +0000, Matthew Wilcox wrote: > > On Thu, Mar 18, 2021 at 11:29:28AM +0000, Luis Henriques wrote: > > > On Thu, Mar 18, 2021 at 02:03:02PM +0300, Kirill A. Shutemov wrote: > > > > On Thu, Mar 18, 2021 at 11:59:59AM +0100, Miklos Szeredi wrote: > > > > > > [16247.536348] page:00000000dfe36ab1 refcount:673 mapcount:0 = mapping:00000000f982a7f8 index:0x1400 pfn:0x4c65e00 > > > > > > [16247.536359] head:00000000dfe36ab1 order:9 compound_mapcoun= t:0 compound_pincount:0 > > > > >=20 > > > > > This is a compound page alright. Have no idea how it got into= fuse's > > > > > pagecache. > > > >=20 > > > >=20 > > > > Luis, do you have CONFIG_READ_ONLY_THP_FOR_FS enabled? > > >=20 > > > Yes, it looks like Tumbleweed kernels have that config option enabl= ed by > > > default. And it this feature was introduced in 5.4 (the bug doesn'= t seem > > > to be reproducible in 5.3). > >=20 > > Can you try adding this patch? > >=20 > > https://git.infradead.org/users/willy/pagecache.git/commitdiff/369a4f= cd78369b7a026bdef465af9669bde98ef4 >=20 > Good news, looks like this patch fixes the issue[1]. Thanks a lot > everyone. Is this already queued somewhere for 5.12? Also, it would b= e > nice to have it Cc'ed for stable kernels >=3D 5.4. Ping. Are you planning to push this for 5.12, or is that queued for the 5.13 merged window? Or "none of the above"? :) Cheers, -- Lu=EDs