From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9335C433B4 for ; Fri, 9 Apr 2021 18:31:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 521F06115B for ; Fri, 9 Apr 2021 18:31:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 521F06115B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A70A36B006C; Fri, 9 Apr 2021 14:31:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A46CB6B006E; Fri, 9 Apr 2021 14:31:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E7AE6B0070; Fri, 9 Apr 2021 14:31:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id 733B26B006C for ; Fri, 9 Apr 2021 14:31:45 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1F184AF84 for ; Fri, 9 Apr 2021 18:31:45 +0000 (UTC) X-FDA: 78013672170.27.C870399 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) by imf26.hostedemail.com (Postfix) with ESMTP id 682F94080F54 for ; Fri, 9 Apr 2021 18:31:41 +0000 (UTC) Received: by mail-qk1-f176.google.com with SMTP id c123so1966181qke.1 for ; Fri, 09 Apr 2021 11:31:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EKQ+PAGgShMzePeTUtIKBivxK+r/dnGaqdyGytm2oWo=; b=fCEschyGAMMn6VF4XHS2XGgUN9Ekoe7/0ZKT+fdRYNG7iwqBjCt2ZG5MVCQm2UpImR pfQNJorBT9ui+crcKlywulA7fWeM4vq4q+AO/ZjSi27KoqxrN5PnfUypmrs9SV9ZHDHX jcpSE8p93+s/UfWmuKIb/sQceslqTjla1XbJLG8Wvfzx1TvgnO8ZI2imcWGp3TOZTjra FSrmmjhLDszTkpV71RNqsEaptogyES14WFo/IJ40KpsNYFItGKyuxbbC1Ib2CiKGgOqn I1jZRD8UpUPNlquDvJ5it8pNSInv3pLslaHtP7fWLkvpnicHWZsagsIXQXRaK87JU+8N UYaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EKQ+PAGgShMzePeTUtIKBivxK+r/dnGaqdyGytm2oWo=; b=TEclqQ83uTrWX5JyeXU0nFgLu4o8mWwBAINBxZV08zX60fwoDWVJDJ9vFKD7vzgERR LbljyFwu4z5rBcpTXu49NQ68BIuYgahyp2CIFbhUGC05q+pOUa86Wz9vJ5uik1NA0auJ trmQBEvg6Umg9h1cNm+KONv9qhi1ouuxcciKQGl0wK/HN5s0b/4NdKFtVL6ZrrC2K2dm HtOycDiDKFgNGbm+a3eOR0buxWWpyYRAiWESHycFESnzrZ13+ildzPRX4tlzakGJQtIs CcmAAEpqVVJdLWiM+TLnCEXtHcAPIXw1CRT403A/bPCGu+gLRyzlfP9FPyZj1Z9nKM5T aJDA== X-Gm-Message-State: AOAM530RMStNF4jC3auo8dmG9EnPToQIK8Pl5myNDE5MOPPnSW92Ik43 2ViHL3sWKeD2DgGs0DrURpTyzQ== X-Google-Smtp-Source: ABdhPJxMTMAOXo89w9z138HDZgi/fLJzWSprm2eXuSdZMKg1xOZTvnQCJpE9XfEYswibLPl3BEUsLg== X-Received: by 2002:a05:620a:10ba:: with SMTP id h26mr2158205qkk.155.1617993103749; Fri, 09 Apr 2021 11:31:43 -0700 (PDT) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id 79sm2411128qki.37.2021.04.09.11.31.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 11:31:43 -0700 (PDT) Date: Fri, 9 Apr 2021 14:31:42 -0400 From: Johannes Weiner To: Muchun Song Cc: guro@fb.com, mhocko@kernel.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, fam.zheng@bytedance.com, bsingharora@gmail.com, shy828301@gmail.com, alex.shi@linux.alibaba.com Subject: Re: [RFC PATCH v2 09/18] mm: vmscan: remove noinline_for_stack Message-ID: References: <20210409122959.82264-1-songmuchun@bytedance.com> <20210409122959.82264-10-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210409122959.82264-10-songmuchun@bytedance.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 682F94080F54 X-Stat-Signature: hnenb3muh9gk7pnjy3y111gw74qeyrhs Received-SPF: none (cmpxchg.org>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=mail-qk1-f176.google.com; client-ip=209.85.222.176 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617993101-133463 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 09, 2021 at 08:29:50PM +0800, Muchun Song wrote: > The noinline_for_stack is introduced by commit 666356297ec4 ("vmscan: > set up pagevec as late as possible in shrink_inactive_list()"), its > purpose is to delay the allocation of pagevec as late as possible to > save stack memory. But the commit 2bcf88796381 ("mm: take pagevecs off > reclaim stack") replace pagevecs by lists of pages_to_free. So we do > not need noinline_for_stack, just remove it (let the compiler decide > whether to inline). > > Signed-off-by: Muchun Song Good catch. Acked-by: Johannes Weiner Since this patch is somewhat independent of the rest of the series, you may want to put it in the very beginning, or even submit it separately, to keep the main series as compact as possible. Reviewers can be more hesitant to get involved with larger series ;)