From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FD4EC433B4 for ; Sat, 10 Apr 2021 15:52:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F162A611C9 for ; Sat, 10 Apr 2021 15:52:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F162A611C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 856066B006C; Sat, 10 Apr 2021 11:52:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 804E66B006E; Sat, 10 Apr 2021 11:52:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A7088D0001; Sat, 10 Apr 2021 11:52:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0232.hostedemail.com [216.40.44.232]) by kanga.kvack.org (Postfix) with ESMTP id 4BC076B006C for ; Sat, 10 Apr 2021 11:52:07 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0F211BA05 for ; Sat, 10 Apr 2021 15:52:07 +0000 (UTC) X-FDA: 78016898694.03.57040E5 Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by imf06.hostedemail.com (Postfix) with ESMTP id 33AA1C0007C1 for ; Sat, 10 Apr 2021 15:52:08 +0000 (UTC) Received: by mail-il1-f179.google.com with SMTP id w2so7221758ilj.12 for ; Sat, 10 Apr 2021 08:52:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=23EKbp9zlt1ctsp4N80b48v3urJ7l3pIXgbyxpzzJPI=; b=USqXUTE4hJNJ8gMhuF6rwjhnG7mNRz+45BwjBpRc4dpGJBXoQ8p4LVHaO8jhCrgGrC SWIYiBIFlpopaPIO8zzMc7EnNdXpVuED1V5EHriyCUCu/cHQMzSccLvVqDTTN70Hql02 RemcVehYVmkjFkrqF568S0/tGQaHoUc6Qr+CHmF/QNk+f+h/RYyEsjIuwWJgDOkpZ2wL cCoAXYoCSmoKLHPl/0M38uLPJbbFLRpqSRbKSKvHSjHEQXoElrOBx7sFky0S009mbZU4 ugbgOzxV1Et/ENfa83/+vns2lgpzuSNmm6ytLqS+dU6hPg+X+QYQwNmgxgf96cAWrona cUXA== X-Gm-Message-State: AOAM531GZj7wBGuo4Vx6Ffr/wXrEksevhECb6uv5xCTJdhJeAT3SqMjh Bbs1aBKpS71EjmZpEpVT/9Q= X-Google-Smtp-Source: ABdhPJw50EzdVLLwIiFxzTTRlIHrnxiymhe1mgKYZtbKmNTsSU2uurcksf/dkRoaWpOA49PEjwdtrw== X-Received: by 2002:a05:6e02:1d99:: with SMTP id h25mr15224232ila.114.1618069926054; Sat, 10 Apr 2021 08:52:06 -0700 (PDT) Received: from google.com (243.199.238.35.bc.googleusercontent.com. [35.238.199.243]) by smtp.gmail.com with ESMTPSA id b4sm2846685iog.15.2021.04.10.08.52.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Apr 2021 08:52:05 -0700 (PDT) Date: Sat, 10 Apr 2021 15:52:04 +0000 From: Dennis Zhou To: Wang Yugui Cc: Vlastimil Babka , linux-mm@kvack.org, linux-btrfs@vger.kernel.org Subject: Re: unexpected -ENOMEM from percpu_counter_init() Message-ID: References: <20210409153636.C53D.409509F4@e16-tech.com> <20210410232913.6F82.409509F4@e16-tech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210410232913.6F82.409509F4@e16-tech.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 33AA1C0007C1 X-Stat-Signature: nnu964eby86dab5joswree4at33zoe6p Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf06; identity=mailfrom; envelope-from=""; helo=mail-il1-f179.google.com; client-ip=209.85.166.179 X-HE-DKIM-Result: none/none X-HE-Tag: 1618069928-610711 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 10, 2021 at 11:29:17PM +0800, Wang Yugui wrote: > Hi, Dennis Zhou > > Thanks for your ncie answer. > but still a few questions. > > > Percpu is not really cheap memory to allocate because it has a > > amplification factor of NR_CPUS. As a result, percpu on the critical > > path is really not something that is expected to be high throughput. > > > Ideally things like btrfs snapshots should preallocate a number of these > > and not try to do atomic allocations because that in theory could fail > > because even after we go to the page allocator in the future we can't > > get enough pages due to needing to go into reclaim. > > pre-allocate in module such as mempool_t is just used in a few place in > linux/fs. so most people like system wide pre-allocate, because it is > more easy to use? > > can we add more chance to management the system wide pre-alloc > just like this? > > diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h > index dc1f4dc..eb3f592 100644 > --- a/include/linux/sched/mm.h > +++ b/include/linux/sched/mm.h > @@ -226,6 +226,11 @@ static inline void memalloc_noio_restore(unsigned int flags) > static inline unsigned int memalloc_nofs_save(void) > { > unsigned int flags = current->flags & PF_MEMALLOC_NOFS; > + > + // just like slab_pre_alloc_hook > + fs_reclaim_acquire(current->flags & gfp_allowed_mask); > + fs_reclaim_release(current->flags & gfp_allowed_mask); > + > current->flags |= PF_MEMALLOC_NOFS; > return flags; > } > > > > The workqueue approach has been good enough so far. Technically there is > > a higher priority workqueue that this work could be scheduled on, but > > save for this miss on my part, the system workqueue has worked out fine. > > > In the future as I mentioned above. It would be good to support actually > > getting pages, but it's work that needs to be tackled with a bit of > > care. I might target the work for v5.14. > > > > > this is our application pipeline. > > > file_pre_process | > > > bwa.nipt xx | > > > samtools.nipt sort xx | > > > file_post_process > > > > > > file_pre_process/file_post_process is fast, so often are blocked by > > > pipe input/output. > > > > > > 'bwa.nipt xx' is a high-cpu-load, almost all of CPU cores. > > > > > > 'samtools.nipt sort xx' is a high-mem-load, it keep the input in memory. > > > if the memory is not enough, it will save all the buffer to temp file, > > > so it is sometimes high-IO-load too(write 60G or more to file). > > > > > > > > > xfstests(generic/476) is just high-IO-load, cpu/memory load is NOT high. > > > so xfstests(generic/476) maybe easy than our application pipeline. > > > > > > Although there is yet not a simple reproducer for another problem > > > happend here, but there is a little high chance that something is wrong > > > in btrfs/mm/fs-buffer. > > > > but another problem(os freezed without call trace, PANIC without OOPS?, > > > > the reason is yet unkown) still happen. > > > > I do not have an answer for this. I would recommend looking into kdump. > > percpu ENOMEM problem blocked many heavy load test a little long time? > I still guess this problem of system freeze is a mm/btrfs problem. > OOM not work, OOPS not work too. > I don't follow. Is this still a problem after the patch? > I try to reproduce it with some simple script. I noticed the value of > 'free' is a little low, although 'available' is big. > > # free -h > total used free shared buff/cache available > Mem: 188Gi 1.4Gi 5.5Gi 17Mi 181Gi 175Gi > Swap: 0B 0B 0B > > vm.min_free_kbytes is auto configed to 4Gi(4194304) > > # write files with the size >= memory size *3 > #for((i=0;i<10;++i));do dd if=/dev/zero bs=1M count=64K of=/nodetmp/${i}.txt; free -h; done > > any advice or patch to let the value of 'free' a little bigger? > > > Best Regards > Wang Yugui (wangyugui@e16-tech.com) > 2021/04/10 > > >