From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96E51C433ED for ; Sun, 2 May 2021 06:32:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2EC6061490 for ; Sun, 2 May 2021 06:32:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EC6061490 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B7A168D0002; Sun, 2 May 2021 02:32:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B51596B0070; Sun, 2 May 2021 02:32:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A42098D0002; Sun, 2 May 2021 02:32:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id 888FB6B006E for ; Sun, 2 May 2021 02:32:06 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3501F8249980 for ; Sun, 2 May 2021 06:32:06 +0000 (UTC) X-FDA: 78095321052.21.7F93A71 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf05.hostedemail.com (Postfix) with ESMTP id 6DAD8E000105 for ; Sun, 2 May 2021 06:32:02 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 99E0761057; Sun, 2 May 2021 06:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619937124; bh=qL1B1QT4PpYn1h9YGj03tGeQZLDs+ChkBvvTAwTmFBc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TgIeVS0ngZ+Uig3csISk5AB6RZ07CQ3YfksmsyKupiBZXIUwJYBS2eBdaRZvkSjcX WIrV6ut42Yj5gR1+UdA/NnKAE3yUqRPVma6wwzMelniHeh4csUjFXQ6lhjhT7meFTH 5fxUM4a+tXZJOChTH8nFx4i71BqQe0QG2ObXpWPiv2UJTXApHo3+1mgNmdgjv4PmMT Ayf+NSTkA8A5TXNOkfapVPaDtzUcXZXOngTVM9y9L6O/b6Ht5czAV7Dl5B0HQNJv/X yhXdpBxZ/QwOG42gYF63XGRRC72Ae1izFm1A5V6AJCFKr2w64Gfa7DPAjIUgwfPu1f x/30S+CYcAPbQ== Date: Sun, 2 May 2021 09:31:52 +0300 From: Mike Rapoport To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Michael S. Tsirkin" , Jason Wang , Alexey Dobriyan , "Matthew Wilcox (Oracle)" , Oscar Salvador , Michal Hocko , Roman Gushchin , Alex Shi , Steven Price , Mike Kravetz , Aili Yao , Jiri Bohac , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Naoya Horiguchi , linux-hyperv@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v1 1/7] fs/proc/kcore: drop KCORE_REMAP and KCORE_OTHER Message-ID: References: <20210429122519.15183-1-david@redhat.com> <20210429122519.15183-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210429122519.15183-2-david@redhat.com> Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TgIeVS0n; spf=pass (imf05.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6DAD8E000105 X-Stat-Signature: og5g7x39cxw8iaknr3nddgsb4kkbudu3 Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf05; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619937122-931055 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 29, 2021 at 02:25:13PM +0200, David Hildenbrand wrote: > Commit db779ef67ffe ("proc/kcore: Remove unused kclist_add_remap()") > removed the last user of KCORE_REMAP. > > Commit 595dd46ebfc1 ("vfs/proc/kcore, x86/mm/kcore: Fix SMAP fault when > dumping vsyscall user page") removed the last user of KCORE_OTHER. > > Let's drop both types. While at it, also drop vaddr in "struct > kcore_list", used by KCORE_REMAP only. > > Signed-off-by: David Hildenbrand Reviewed-by: Mike Rapoport > --- > fs/proc/kcore.c | 7 ++----- > include/linux/kcore.h | 3 --- > 2 files changed, 2 insertions(+), 8 deletions(-) > > diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c > index 4d2e64e9016c..09f77d3c6e15 100644 > --- a/fs/proc/kcore.c > +++ b/fs/proc/kcore.c > @@ -380,11 +380,8 @@ read_kcore(struct file *file, char __user *buffer, size_t buflen, loff_t *fpos) > phdr->p_type = PT_LOAD; > phdr->p_flags = PF_R | PF_W | PF_X; > phdr->p_offset = kc_vaddr_to_offset(m->addr) + data_offset; > - if (m->type == KCORE_REMAP) > - phdr->p_vaddr = (size_t)m->vaddr; > - else > - phdr->p_vaddr = (size_t)m->addr; > - if (m->type == KCORE_RAM || m->type == KCORE_REMAP) > + phdr->p_vaddr = (size_t)m->addr; > + if (m->type == KCORE_RAM) > phdr->p_paddr = __pa(m->addr); > else if (m->type == KCORE_TEXT) > phdr->p_paddr = __pa_symbol(m->addr); > diff --git a/include/linux/kcore.h b/include/linux/kcore.h > index da676cdbd727..86c0f1d18998 100644 > --- a/include/linux/kcore.h > +++ b/include/linux/kcore.h > @@ -11,14 +11,11 @@ enum kcore_type { > KCORE_RAM, > KCORE_VMEMMAP, > KCORE_USER, > - KCORE_OTHER, > - KCORE_REMAP, > }; > > struct kcore_list { > struct list_head list; > unsigned long addr; > - unsigned long vaddr; > size_t size; > int type; > }; > -- > 2.30.2 > -- Sincerely yours, Mike.