From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A375C433ED for ; Thu, 22 Apr 2021 12:20:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A6B17600CD for ; Thu, 22 Apr 2021 12:20:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6B17600CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 29A8A6B006E; Thu, 22 Apr 2021 08:20:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 271206B0070; Thu, 22 Apr 2021 08:20:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 110E96B0071; Thu, 22 Apr 2021 08:20:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id DE84F6B006E for ; Thu, 22 Apr 2021 08:20:01 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9F1DF34A3 for ; Thu, 22 Apr 2021 12:20:01 +0000 (UTC) X-FDA: 78059909802.03.DE53D58 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf25.hostedemail.com (Postfix) with ESMTP id AF717600011F for ; Thu, 22 Apr 2021 12:19:57 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id A09E861458; Thu, 22 Apr 2021 12:19:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619094000; bh=Wr0OhYhDfMPeG2IHpq9JA+nWcwCtRYKEEDdMNXqNT9s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LlaLFhYwpL5KwHSeR+kWjYsDL/tsJ53z++3kDhDn76NrrSsP7VizhfXGQyIbXDoqb LJZ8mRtqqeFGV1Q8FDHsud8Q17LECv/AEoLpPNly3nyWYZtcAhFZdQm75qDzi5K+CU 0FqxfTjCfYUtjkBT56BenF/rsDnUW62chd9fKHL8CYa3tPqiehAIWZaa30RoU9mGl6 V59vWyrsISfh6puiMCNpZBbUjywKOXpSeNu+H0oCQEB5l5hNk6uAJFu7ybD+AkaS2C RRBa4F2UAmwnAb9qcAuFRpEbVSRLTjZYn3bSC9Tuad642ys+HkqBTTOCK45NDMDPIS dw8AordqXki3g== Date: Thu, 22 Apr 2021 15:19:53 +0300 From: Mike Rapoport To: Anshuman Khandual Cc: linux-mm@kvack.org, david@redhat.com, akpm@linux-foundation.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC V2] mm: Enable generic pfn_valid() to handle early sections with memmap holes Message-ID: References: <20210422061902.21614-1-rppt@kernel.org> <1619077823-3819-1-git-send-email-anshuman.khandual@arm.com> <6096b004-aaeb-d814-87e4-92ec1b180f1d@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6096b004-aaeb-d814-87e4-92ec1b180f1d@arm.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: AF717600011F X-Stat-Signature: 9ncxgmkk3u8iqdm1nmddz53348h3575d Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf25; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619093997-442843 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 22, 2021 at 04:53:36PM +0530, Anshuman Khandual wrote: > On 4/22/21 1:57 PM, Mike Rapoport wrote: ... > >> diff --git a/mm/memblock.c b/mm/memblock.c > >> index 3abf2c3fea7f..93f8a9c8428d 100644 > >> --- a/mm/memblock.c > >> +++ b/mm/memblock.c > >> @@ -1740,6 +1740,7 @@ bool __init_memblock memblock_is_memory(phys_addr_t addr) > >> { > >> return memblock_search(&memblock.memory, addr) != -1; > >> } > >> +EXPORT_SYMBOL(memblock_is_memory); > > > > Please make it inside #ifdef CONFIG_ARCH_MEMBLOCK > CONFIG_ARCH_KEEP_MEMBLOCK ? Yeah, _KEEP went away somehow :) > Wrap it around the EXPORT_SYMBOL() or the entire function > memblock_is_memory(). EXPORT_SYMBOL(). Otherwise we'll have exported __init function. -- Sincerely yours, Mike.