From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDCB6C433ED for ; Thu, 29 Apr 2021 19:45:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 686EC60E0B for ; Thu, 29 Apr 2021 19:45:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 686EC60E0B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C56A96B006C; Thu, 29 Apr 2021 15:45:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C06196B006E; Thu, 29 Apr 2021 15:45:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA6C06B0070; Thu, 29 Apr 2021 15:45:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0100.hostedemail.com [216.40.44.100]) by kanga.kvack.org (Postfix) with ESMTP id 8D8576B006C for ; Thu, 29 Apr 2021 15:45:51 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 479DA181AF5C6 for ; Thu, 29 Apr 2021 19:45:51 +0000 (UTC) X-FDA: 78086434902.02.D0CC74C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id E9EE9801A80D for ; Thu, 29 Apr 2021 19:45:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619725550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=46vr6MOxvMx7EcNeLrQPCFzx6v2cxfIGSgLQQ+snNgQ=; b=dEvGNPfHCVP1XUi6b0tgVv5pCcMSMGAYn2O78d7MpfX4RzlrvEBayEStQQHtUknsy33Jb/ 6HDcQIj7wnYWComQFwrimoxfhi1zHILt13FOUt7u/0g0dBfc+Aqe8IWuD3K3dN59WJFkaB hm1//v1AoeYLBatp6cMt2vok7K49Xyg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-366-2E-ZcLmyNSmk8WkXdFT6MA-1; Thu, 29 Apr 2021 15:45:48 -0400 X-MC-Unique: 2E-ZcLmyNSmk8WkXdFT6MA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 349D5818411; Thu, 29 Apr 2021 19:45:44 +0000 (UTC) Received: from optiplex-fbsd (unknown [10.3.128.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7DA6110016FC; Thu, 29 Apr 2021 19:45:40 +0000 (UTC) Date: Thu, 29 Apr 2021 15:45:37 -0400 From: Rafael Aquini To: "Chu,Kaiping" Cc: "mcgrof@kernel.org" , "keescook@chromium.org" , "yzaikin@google.com" , "akpm@linux-foundation.org" , "vbabka@suse.cz" , "nigupta@nvidia.com" , "bhe@redhat.com" , "khalid.aziz@oracle.com" , "iamjoonsoo.kim@lge.com" , "mateusznosek0@gmail.com" , "sh_def@163.com" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: =?utf-8?B?562U5aSNOiBbUEFUQw==?= =?utf-8?Q?H?= v3] mm/compaction:let proactive compaction order configurable Message-ID: References: <1619313662-30356-1-git-send-email-chukaiping@baidu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Stat-Signature: qqatgnux9zmjcwyph9mrdmyrdmomoso6 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E9EE9801A80D Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf27; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=170.10.133.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619725526-319951 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 28, 2021 at 01:17:40AM +0000, Chu,Kaiping wrote: > Please see my answer inline. >=20 > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Rafael Aquini =20 > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B44=E6=9C=8826=E6=97=A5= 9:31 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Chu,Kaiping > =E6=8A=84=E9=80=81: mcgrof@kernel.org; keescook@chromium.org; yzaikin@g= oogle.com; akpm@linux-foundation.org; vbabka@suse.cz; nigupta@nvidia.com;= bhe@redhat.com; khalid.aziz@oracle.com; iamjoonsoo.kim@lge.com; mateuszn= osek0@gmail.com; sh_def@163.com; linux-kernel@vger.kernel.org; linux-fsde= vel@vger.kernel.org; linux-mm@kvack.org > =E4=B8=BB=E9=A2=98: Re: [PATCH v3] mm/compaction:let proactive compacti= on order configurable >=20 > On Sun, Apr 25, 2021 at 09:21:02AM +0800, chukaiping wrote: > > Currently the proactive compaction order is fixed to=20 > > COMPACTION_HPAGE_ORDER(9), it's OK in most machines with lots of=20 > > normal 4KB memory, but it's too high for the machines with small=20 > > normal memory, for example the machines with most memory configured a= s=20 > > 1GB hugetlbfs huge pages. In these machines the max order of free=20 > > pages is often below 9, and it's always below 9 even with hard=20 > > compaction. This will lead to proactive compaction be triggered very=20 > > frequently. In these machines we only care about order of 3 or 4. > > This patch export the oder to proc and let it configurable by user,=20 > > and the default value is still COMPACTION_HPAGE_ORDER. > >=20 > > Signed-off-by: chukaiping > > Reported-by: kernel test robot >=20 > Two minor nits on the commit log message:=20 > * there seems to be a whitespage missing in your short log:=20 > "... mm/compaction:let ..." > --> I will fix it in next patch. >=20 > * has the path really been reported by a test robot? > --> Yes. There is a compile error in v1, I fixed it in v2. > So, no... the test robot should not be listed as Reported-by.=20