From: Christoph Hellwig <hch@infradead.org>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: yuzhao@google.com, akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/lru: Add folio LRU functions
Date: Thu, 27 May 2021 09:36:18 +0100 [thread overview]
Message-ID: <YK9aAhuP3J3suyey@infradead.org> (raw)
In-Reply-To: <20210513122702.2245882-1-willy@infradead.org>
On Thu, May 13, 2021 at 01:27:02PM +0100, Matthew Wilcox (Oracle) wrote:
> +static inline int folio_is_file_lru(struct folio *folio)
> +{
> + return !folio_swapbacked(folio);
> +}
This should probably be changed to return a bool.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2021-05-27 8:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 12:27 [PATCH] mm/lru: Add folio LRU functions Matthew Wilcox (Oracle)
2021-05-13 17:52 ` Yu Zhao
2021-05-27 8:36 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK9aAhuP3J3suyey@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).