From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A279AC4707F for ; Thu, 27 May 2021 08:36:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 43F196054E for ; Thu, 27 May 2021 08:36:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43F196054E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AAF4D6B0070; Thu, 27 May 2021 04:36:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A5DF16B0072; Thu, 27 May 2021 04:36:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D8386B0073; Thu, 27 May 2021 04:36:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5A0D36B0070 for ; Thu, 27 May 2021 04:36:44 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EAEA4180ACEEB for ; Thu, 27 May 2021 08:36:43 +0000 (UTC) X-FDA: 78186355086.29.0F599F6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 2F8CBC0042DF for ; Thu, 27 May 2021 08:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UETU0rF+/V4eGzVvUWF5qqlBxErskRLjFERYxkJsWxc=; b=otx23+nCtYm+IRhWHeq9Wxuyik lgTrYCKeThgKEKdMsRy0hZPwBqIHI68z2DI81lbP81VAPF0R2/Jy+orGtBO00aY++3FFBco/VPcPE xqRFPQ/LDh1nHQEvDmoAwsQf63TFmkn8xFlO+EcYkmuScPskTP5XNq8yCpAZ/7SHEcDJpn4nlcclC QI1TZc5a9x9bkJmNr82dbx5AY3r9WmVY9YJYYVXds4BPk2uvoKdq43TK66J2ng0a/FJm5lkOPa3gN FnR0rGs0t2XhCVwIKNJzE+7d2YOt9bO2uTP1oE79GmSHvjRMgeomyhGjXg06MFHQ7nmUCWAPZNw1U r+5lUFAw==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lmBV4-005L56-5J; Thu, 27 May 2021 08:36:22 +0000 Date: Thu, 27 May 2021 09:36:18 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: yuzhao@google.com, akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/lru: Add folio LRU functions Message-ID: References: <20210513122702.2245882-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210513122702.2245882-1-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 2F8CBC0042DF Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=otx23+nC; dmarc=none; spf=none (imf06.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org X-Rspamd-Server: rspam03 X-Stat-Signature: fdmamx8cx7thi5piqtgsow74wuc6s95r X-HE-Tag: 1622104596-164278 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 13, 2021 at 01:27:02PM +0100, Matthew Wilcox (Oracle) wrote: > +static inline int folio_is_file_lru(struct folio *folio) > +{ > + return !folio_swapbacked(folio); > +} This should probably be changed to return a bool. Otherwise looks good: Reviewed-by: Christoph Hellwig