From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8830FC433ED for ; Tue, 18 May 2021 14:38:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4E0A4600D4 for ; Tue, 18 May 2021 14:38:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E0A4600D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D19BE8E003A; Tue, 18 May 2021 10:38:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC8D28E002F; Tue, 18 May 2021 10:38:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B907F8E003A; Tue, 18 May 2021 10:38:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id 845018E002F for ; Tue, 18 May 2021 10:38:17 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 200F9181AEF1A for ; Tue, 18 May 2021 14:38:17 +0000 (UTC) X-FDA: 78154607034.08.1217B71 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 3C8D390009E9 for ; Tue, 18 May 2021 14:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CcpTl6ahcoWKTT9zvVzM5pO89ICfycVf67IsEN9gVHg=; b=cWObSjC1R2ayoD9cjWuik10Ftw JSaHdd4jdcbwIz7NG7TGRbBUhZzKfCSZGloSjbOkEKpwTsdW81UYLr1mno73udaCCu40bPsaQZMmw zB26D1D4BSh6BhqCHMNfAVZrpyazuhMrtvzSNr2yXGPT7Gfl1tovFNOeaSlCKDLnprc8dGPQ03JZh B4phq1acfQalXJ9KMyLbhIjZgvLUbAEZXQrVtDh6fiyMXVmCz9MAk9MBwXBFeL86mYEBOHfb+koLt Tzo0BZvzDzryE0j3ZQ65mmAv+CnFXiBQs9+HFvLovpB5hSrpLuzH5onLtEAQYtoV1jJzJxeUVjJZb eFgmfWmQ==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lj0qI-00E3xA-KH; Tue, 18 May 2021 14:37:17 +0000 Date: Tue, 18 May 2021 15:37:06 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/5] mm/swap: remove unused local variable nr_shadows Message-ID: References: <20210518135352.3705306-1-linmiaohe@huawei.com> <20210518135352.3705306-3-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210518135352.3705306-3-linmiaohe@huawei.com> Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cWObSjC1; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3C8D390009E9 X-Stat-Signature: hgbdqswc86de5tqb3fa584dz6jstahhf X-HE-Tag: 1621348695-237766 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 18, 2021 at 09:53:49PM +0800, Miaohe Lin wrote: > Since commit 55c653b71e8c ("mm: stop accounting shadow entries"), > nr_shadows is not used anymore. > > Signed-off-by: Miaohe Lin Reviewed-by: Matthew Wilcox (Oracle) > +++ b/mm/swap_state.c > @@ -114,7 +114,6 @@ int add_to_swap_cache(struct page *page, swp_entry_t entry, > SetPageSwapCache(page); > > do { > - unsigned long nr_shadows = 0; > Perhaps delete the blank line as well?