From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68EECC433B4 for ; Tue, 18 May 2021 16:09:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DCADB611EE for ; Tue, 18 May 2021 16:09:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCADB611EE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5876A6B00E8; Tue, 18 May 2021 12:09:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 536A36B00EA; Tue, 18 May 2021 12:09:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AFF16B00EB; Tue, 18 May 2021 12:09:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id 09F436B00E8 for ; Tue, 18 May 2021 12:09:51 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 980548249980 for ; Tue, 18 May 2021 16:09:51 +0000 (UTC) X-FDA: 78154837782.31.5541C43 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf12.hostedemail.com (Postfix) with ESMTP id 9583078E for ; Tue, 18 May 2021 16:09:48 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 7AC69611AC; Tue, 18 May 2021 16:09:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621354190; bh=qryFGREqLRRZQLKFaOIFkrGz8b/QRKaiyNq9FU8d52c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JWnj8jadWyIY4heJ96ftgfCxeqYRP1dxLHGsj+AKkdngR4J/hfRID4LcsnZnrInsc VBsZHqLtuCUsBfeWBVCKk+ZOzpYHGOs8Bo5PZJtNKD4wS5mtVc2WuaMG1H09wq7jhu ftkGYdCYyfkTR1MBoP23I7wO6cMr5OLGY0HtqDwSr0wtkQ+fD1jPH01Kyrf8C+TPqM at/V25Qc/l4SvBw/IpbDy/Z3kdPfmg0Fchfj/3jEO4BUZEOfOoDjSvodwwhwfsNeBa ju5N9xRKj2F6WqKrwGPQJoGOQ7iLP7LagH5pil0byD8Ah5CyF2y85mvWvCQNMJJ1LC aLrECFmDGe/fA== Date: Tue, 18 May 2021 19:09:40 +0300 From: Mike Rapoport To: Miles Chen Cc: Dave Young , Baoquan He , Vivek Goyal , Jonathan Corbet , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Andrew Morton , kexec@lists.infradead.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 0/2] mm: unify the allocation of pglist_data instances Message-ID: References: <20210518092446.16382-1-miles.chen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210518092446.16382-1-miles.chen@mediatek.com> X-Rspamd-Queue-Id: 9583078E Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JWnj8jad; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Rspamd-Server: rspam03 X-Stat-Signature: 51wjac6wma7n1mb5kox9eckf7xpep3jd X-HE-Tag: 1621354188-305968 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Miles, On Tue, May 18, 2021 at 05:24:44PM +0800, Miles Chen wrote: > This patches is created to fix the __pa() warning messages when > CONFIG_DEBUG_VIRTUAL=y by unifying the allocation of pglist_data > instances. > > In current implementation of node_data, if CONFIG_NEED_MULTIPLE_NODES=y, > pglist_data is allocated by a memblock API. If CONFIG_NEED_MULTIPLE_NODES=n, > we use a global variable named "contig_page_data". > > If CONFIG_DEBUG_VIRTUAL is not enabled. __pa() can handle both > allocation and symbol cases. But if CONFIG_DEBUG_VIRTUAL is set, > we will have the "virt_to_phys used for non-linear address" warning > when booting. > > To fix the warning, always allocate pglist_data by memblock APIs and > remove the usage of contig_page_data. Somehow I was sure that we can allocate pglist_data before it is accessed in sparse_init() somewhere outside mm/sparse.c. It's really not the case and having two places that may allocated this structure is surely worth than your previous suggestion. Sorry about that. > Warning message: > [ 0.000000] ------------[ cut here ]------------ > [ 0.000000] virt_to_phys used for non-linear address: (____ptrval____) (contig_page_data+0x0/0x1c00) > [ 0.000000] WARNING: CPU: 0 PID: 0 at arch/arm64/mm/physaddr.c:15 __virt_to_phys+0x58/0x68 > [ 0.000000] Modules linked in: > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Tainted: G W 5.13.0-rc1-00074-g1140ab592e2e #3 > [ 0.000000] Hardware name: linux,dummy-virt (DT) > [ 0.000000] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO BTYPE=--) > [ 0.000000] pc : __virt_to_phys+0x58/0x68 > [ 0.000000] lr : __virt_to_phys+0x54/0x68 > [ 0.000000] sp : ffff800011833e70 > [ 0.000000] x29: ffff800011833e70 x28: 00000000418a0018 x27: 0000000000000000 > [ 0.000000] x26: 000000000000000a x25: ffff800011b70000 x24: ffff800011b70000 > [ 0.000000] x23: fffffc0001c00000 x22: ffff800011b70000 x21: 0000000047ffffb0 > [ 0.000000] x20: 0000000000000008 x19: ffff800011b082c0 x18: ffffffffffffffff > [ 0.000000] x17: 0000000000000000 x16: ffff800011833bf9 x15: 0000000000000004 > [ 0.000000] x14: 0000000000000fff x13: ffff80001186a548 x12: 0000000000000000 > [ 0.000000] x11: 0000000000000000 x10: 00000000ffffffff x9 : 0000000000000000 > [ 0.000000] x8 : ffff8000115c9000 x7 : 737520737968705f x6 : ffff800011b62ef8 > [ 0.000000] x5 : 0000000000000000 x4 : 0000000000000001 x3 : 0000000000000000 > [ 0.000000] x2 : 0000000000000000 x1 : ffff80001159585e x0 : 0000000000000058 > [ 0.000000] Call trace: > [ 0.000000] __virt_to_phys+0x58/0x68 > [ 0.000000] check_usemap_section_nr+0x50/0xfc > [ 0.000000] sparse_init_nid+0x1ac/0x28c > [ 0.000000] sparse_init+0x1c4/0x1e0 > [ 0.000000] bootmem_init+0x60/0x90 > [ 0.000000] setup_arch+0x184/0x1f0 > [ 0.000000] start_kernel+0x78/0x488 > [ 0.000000] ---[ end trace f68728a0d3053b60 ]--- > > [1] https://lore.kernel.org/patchwork/patch/1425110/ > > Change since v1: > - use memblock_alloc() to create pglist_data when CONFIG_NUMA=n > > Miles Chen (2): > mm: introduce prepare_node_data > mm: replace contig_page_data with node_data > > Documentation/admin-guide/kdump/vmcoreinfo.rst | 13 ------------- > arch/powerpc/kexec/core.c | 5 ----- > include/linux/gfp.h | 3 --- > include/linux/mm.h | 2 ++ > include/linux/mmzone.h | 4 ++-- > kernel/crash_core.c | 1 - > mm/memblock.c | 3 +-- > mm/page_alloc.c | 16 ++++++++++++++++ > mm/sparse.c | 2 ++ > 9 files changed, 23 insertions(+), 26 deletions(-) > > > base-commit: 8ac91e6c6033ebc12c5c1e4aa171b81a662bd70f > -- > 2.18.0 > -- Sincerely yours, Mike.