From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22994C433ED for ; Wed, 19 May 2021 13:25:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 85D4D6135F for ; Wed, 19 May 2021 13:25:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85D4D6135F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E8FC86B0036; Wed, 19 May 2021 09:25:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3F116B006E; Wed, 19 May 2021 09:25:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE05A6B0070; Wed, 19 May 2021 09:25:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id 984D16B0036 for ; Wed, 19 May 2021 09:25:16 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 296D1A764 for ; Wed, 19 May 2021 13:25:16 +0000 (UTC) X-FDA: 78158051832.25.720ECA8 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf17.hostedemail.com (Postfix) with ESMTP id B4BB440B8CE7 for ; Wed, 19 May 2021 13:25:14 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 5269460FDA; Wed, 19 May 2021 13:25:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621430713; bh=EVzzh57rehbOK39R2k9GukpiN4HMiF1r3EbBJxvEg3Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eamEd3MBrSqKDC0vuk6Vdp4/tNPGkq3i4Y3ObKZl3uv35f4rF1LfNY1h11Aeph45O 8HtTwpHiv0xX0od/gf8xL+Io19t9xlWZzG5q/9kh4XdZFAcL8XrvbzOBdKuGHwxWit xiF10XNATvffhIDuD6N1Is4k19sqZSXppf5q+TCtQq7sNGAHe5Uwq4aQ6vQeai30x4 g8uyCdOQm6Dr3LVb63hb+q7d+Ke32hsjJlTmt5quBu1RerTzoH/fN67ZD//Iw25BW1 VyiAfUTQhvdueyHtdwdU6MDY0kG781rxPQ7TJuwEwpf5Q5msQPeVTePLpT+DC/NrWi LXVntDoYnFSIw== Date: Wed, 19 May 2021 16:25:06 +0300 From: Mike Rapoport To: Kefeng Wang Cc: linux-arm-kernel@lists.infradead.org, Andrew Morton , Mike Rapoport , Russell King , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/3] arm: extend pfn_valid to take into accound freed memory map alignment Message-ID: References: <20210518090613.21519-1-rppt@kernel.org> <20210518090613.21519-4-rppt@kernel.org> <2d34f990-c609-88aa-1dc0-f8e9e9623fc3@huawei.com> <779d890b-6983-6138-4f74-eef7be0bbd4c@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <779d890b-6983-6138-4f74-eef7be0bbd4c@huawei.com> Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=eamEd3MB; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B4BB440B8CE7 X-Stat-Signature: h8wecfc5jemrhu7r7d9tyd177aasm5gi X-HE-Tag: 1621430714-344083 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 19, 2021 at 09:50:46AM +0800, Kefeng Wang wrote: > > On 2021/5/18 23:52, Mike Rapoport wrote: > > On Tue, May 18, 2021 at 08:49:43PM +0800, Kefeng Wang wrote: > > > > > > > > > On 2021/5/18 17:06, Mike Rapoport wrote: > > > > From: Mike Rapoport > > > > > > > > When unused memory map is freed the preserved part of the memory map is > > > > extended to match pageblock boundaries because lots of core mm > > > > functionality relies on homogeneity of the memory map within pageblock > > > > boundaries. > > > > > > > > Since pfn_valid() is used to check whether there is a valid memory map > > > > entry for a PFN, make it return true also for PFNs that have memory map > > > > entries even if there is no actual memory populated there. > > > > > > > > Signed-off-by: Mike Rapoport > > > > --- > > > > arch/arm/mm/init.c | 15 ++++++++++++++- > > > > 1 file changed, 14 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c > > > > index 9d4744a632c6..bb678c0ba143 100644 > > > > --- a/arch/arm/mm/init.c > > > > +++ b/arch/arm/mm/init.c > > > > @@ -125,11 +125,24 @@ static void __init zone_sizes_init(unsigned long min, unsigned long max_low, > > > > int pfn_valid(unsigned long pfn) > > > > { > > > > phys_addr_t addr = __pfn_to_phys(pfn); > > > > + unsigned long pageblock_size = PAGE_SIZE * pageblock_nr_pages; > > > > if (__phys_to_pfn(addr) != pfn) > > > > return 0; > > > > - return memblock_is_map_memory(addr); > > > > + if (memblock_is_map_memory(addr)) > > > > + return 1; > > > > + > > > > + /* > > > > + * If address less than pageblock_size bytes away from a present > > > > + * memory chunk there still will be a memory map entry for it > > > > + * because we round freed memory map to the pageblock boundaries > > > > + */ > > > > + if (memblock_is_map_memory(ALIGN(addr + 1, pageblock_size)) || > > > > + memblock_is_map_memory(ALIGN_DOWN(addr, pageblock_size))) > > > > + return 1; > > > > > > Hi Mike, with patch3, the system won't boot. > > > > Hmm, apparently I've miscalculated the ranges... > > > > Can you please check with the below patch on top of this series: > > Yes, it works, > > On node 0 totalpages: 311551 > Normal zone: 1230 pages used for memmap > Normal zone: 0 pages reserved > Normal zone: 157440 pages, LIFO batch:31 > Normal zone: 17152 pages in unavailable ranges > HighMem zone: 154111 pages, LIFO batch:31 > HighMem zone: 513 pages in unavailable ranges > > and the oom testcase could pass. > > Tested-by: Kefeng Wang > > > There is memblock_is_region_reserved(check if a region intersects reserved > memory), it also checks the size, should we add a similar func? We already have memblock_is_region_memory() that checks if the entire region is a subset of memory. :( Let's deal with this mess afterwards. > > > > diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c > > index bb678c0ba143..2fafbbc8e73b 100644 > > --- a/arch/arm/mm/init.c > > +++ b/arch/arm/mm/init.c > > @@ -138,8 +138,9 @@ int pfn_valid(unsigned long pfn) > > * memory chunk there still will be a memory map entry for it > > * because we round freed memory map to the pageblock boundaries > > */ > > - if (memblock_is_map_memory(ALIGN(addr + 1, pageblock_size)) || > > - memblock_is_map_memory(ALIGN_DOWN(addr, pageblock_size))) > > + if (memblock_overlaps_region(&memblock.memory, > > + ALIGN_DOWN(addr, pageblock_size), > > + pageblock_size); > > return 1; > > return 0; > > -- Sincerely yours, Mike.