From: Matthew Wilcox <willy@infradead.org>
To: Aaron Tomlin <atomlin@redhat.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, vbabka@suse.cz,
mhocko@suse.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/page_alloc: bail out on fatal signal during reclaim/compaction retry attempt
Date: Wed, 19 May 2021 20:32:59 +0100 [thread overview]
Message-ID: <YKVn69o1UizH0kJD@casper.infradead.org> (raw)
In-Reply-To: <20210519192321.3247175-1-atomlin@redhat.com>
On Wed, May 19, 2021 at 08:23:21PM +0100, Aaron Tomlin wrote:
> +++ b/mm/page_alloc.c
> @@ -4252,6 +4252,9 @@ should_compact_retry(struct alloc_context *ac, int order, int alloc_flags,
> if (!order)
> return false;
>
> + if (fatal_signal_pending(current))
> + goto out;
I think 'goto out' will be confusing. It'll output a tracepoint, which
isn't going to record that a fatal signal is pending, so it'll cause
some head scratching for someone looking through the traces. I
think we should just return false here and skip the tracepoint.
But I'd defer to someone like Vlastimil or Michal who know this code far
better than I do.
next prev parent reply other threads:[~2021-05-19 19:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 19:23 [PATCH v2] mm/page_alloc: bail out on fatal signal during reclaim/compaction retry attempt Aaron Tomlin
2021-05-19 19:32 ` Matthew Wilcox [this message]
2021-05-19 19:48 ` Aaron Tomlin
2021-05-19 20:17 ` [PATCH v3] " Aaron Tomlin
2021-05-20 4:34 ` Andrew Morton
2021-05-20 10:20 ` Vlastimil Babka
2021-05-20 11:42 ` Aaron Tomlin
2021-05-20 11:56 ` Matthew Wilcox
2021-05-20 13:30 ` Aaron Tomlin
2021-05-20 14:29 ` [PATCH v4] " Aaron Tomlin
2021-05-28 12:53 ` Vlastimil Babka
2021-05-31 11:33 ` Michal Hocko
2021-05-31 11:35 ` Vlastimil Babka
2021-05-31 13:21 ` Michal Hocko
2021-05-20 11:09 ` [PATCH v3] " Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKVn69o1UizH0kJD@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=atomlin@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).