From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FFCAC433B4 for ; Thu, 20 May 2021 17:40:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DD45A6109F for ; Thu, 20 May 2021 17:40:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD45A6109F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 262968D000E; Thu, 20 May 2021 13:40:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 239A28D0001; Thu, 20 May 2021 13:40:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DC488D000E; Thu, 20 May 2021 13:40:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id D145C8D0001 for ; Thu, 20 May 2021 13:40:11 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 54400809F4D1 for ; Thu, 20 May 2021 17:40:11 +0000 (UTC) X-FDA: 78162323022.27.FDC2ACE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 63E672C9 for ; Thu, 20 May 2021 17:40:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xAcCCkyhMBeA+FlHmzfzPiZtaAE/GIh+EEGr21kJE5o=; b=kec7QH+yYYLs8HscTdTqy33p4w T1gIXianzT7SRzE025+ho+dKtGojV6O7fz0WY6U02d1x4R0w6PPXeJ/0ok0XpA3cCDarg4tRh5GBr cthpgpsvrbhclUIffjijQrwOuFz6Jhhn39KVk7EGobhoXyhp4oEE22AFmbWERlukwx+6DUgvukwhb VJeYu8TQ85UA7x3vk76JRlQurkYo+nTmE1VZ7SQYXwFnrKIqlXm2tl3VGZJX7A8kPV+mJRiE4LaaU B8FFRD//81AgcAtZ0j7d2nJKVjXQNe+Pbvpw4CuLPs6qV6GOKVYGeWT0lmIbvS1PxHfVczpbYlPnj PGGtKssQ==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1ljmdO-00GG3I-8E; Thu, 20 May 2021 17:39:03 +0000 Date: Thu, 20 May 2021 18:38:58 +0100 From: Matthew Wilcox To: "Yu, Yu-cheng" Cc: Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang , Mark Brown , Catalin Marinas Subject: Re: [PATCH v26 26/30] ELF: Introduce arch_setup_elf_property() Message-ID: References: <20210427204315.24153-1-yu-cheng.yu@intel.com> <20210427204315.24153-27-yu-cheng.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 63E672C9 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kec7QH+y; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam04 X-Stat-Signature: jao76h5ahj9p94wrzx51gbwcyghbhw9x X-HE-Tag: 1621532408-578828 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 19, 2021 at 03:14:58PM -0700, Yu, Yu-cheng wrote: > > > +++ b/include/uapi/linux/elf.h > > > @@ -455,4 +455,13 @@ typedef struct elf64_note { > > > /* Bits for GNU_PROPERTY_AARCH64_FEATURE_1_BTI */ > > > #define GNU_PROPERTY_AARCH64_FEATURE_1_BTI (1U << 0) > > > +/* .note.gnu.property types for x86: */ > > > +#define GNU_PROPERTY_X86_FEATURE_1_AND 0xc0000002 > > > > Why not 0xc0000001? ARM64 is 0xc0000000... > > > > I just looked at the ABI document. > > ARM has GNU_PROPERTY_AARCH64_FEATURE_1_AND 0xc0000000 > > X86 has: > GNU_PROPERTY_X86_ISA_1_USED 0xc0000000 > GNU_PROPERTY_X86_ISA_1_NEEDED 0xc0000001 > GNU_PROPERTY_X86_FEATURE_1_AND 0xc0000002 Please add all three, not just the last one.