From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48BC1C2B9F7 for ; Tue, 25 May 2021 00:01:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C6C31610FC for ; Tue, 25 May 2021 00:01:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6C31610FC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A91156B0070; Mon, 24 May 2021 20:01:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A126E6B0071; Mon, 24 May 2021 20:01:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50B6B6B0072; Mon, 24 May 2021 20:01:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id 0D6746B0070 for ; Mon, 24 May 2021 20:01:03 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8D277181AEF31 for ; Tue, 25 May 2021 00:01:03 +0000 (UTC) X-FDA: 78177798006.04.21A0D00 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf05.hostedemail.com (Postfix) with ESMTP id 02937E005F25 for ; Tue, 25 May 2021 00:00:55 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id 6so21288339pgk.5 for ; Mon, 24 May 2021 17:01:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1oIG+9BASGpsf3Bf/dJPV1Xs0ktBXU7PyErfIXd1OBU=; b=XhDYLFBSj77yLVK2AEnggOwigL5hVenSiwlLh7FS77nesW0zcpqk3g/75KJaRn1WnE KHxilb8GkQrRO29jTTK8XQVvjNuddAR9c+W2bRXqAjGoNxayvIR/RydJv5jYZNC9MP2U ocMJ0j9Umd9AHls+vzSLNt4svGMDqo8q6dJy7PlCWO64kXkV88eQYro4MBxe4yzKvYru kQ64hORTTt+RBhPgfURON+3EiZhwJ0Clqf/teSS6FJVZGfmeA1nzB8Qauzz5/xQiFWly F45VzoIJ2rBPmdB1FdSFl5PKvwxDEI6KDkpzR++nMoSGuC/l5lb7ONUYK/P6sFjMCeKN Bt7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1oIG+9BASGpsf3Bf/dJPV1Xs0ktBXU7PyErfIXd1OBU=; b=h9nnwT+8djdTrP77INiIWUBzASaJdlM0TxzUDz1FuJ8nDH/eW2d8F/vGXZ7xO5+VLW LJ6YJdwW6zZzcnMEnvkXgbydx8jd7POHh4pIXN3tcH27rCBhHNwDmU5/Kg+wQZ56qfsJ HdHl+kgS7BHvCTtDa5I52ddGd472tTJnWMzsQYIjjY5Yi3xMLFYHa0rCGi4NQ7bA+xYu VQi7latroZlxxWqlUyeEx3WOmVMq+S2iZ2EwLn+OL0OWjmI9rddFY1/yt5bozvc2ScQJ WFJAN0H8WnSHJRTJTGQ4rr3EmSNhOfOtLzcoYVprZGfLJF9MLDPLf4GDcEhFt+yh9rSY ivzA== X-Gm-Message-State: AOAM531yncGt58oySw8NKex4BmgpIQ2Ulw8QzOZi8mH6xhpJGTYJog29 BYooImScQ1h20LlmdwSJ2sSwtg== X-Google-Smtp-Source: ABdhPJzwVmNSVpudD1GEVWwFUKdQSqbt6qSZwM5S8ejlHDA4eAgaLxQEEkFIzBsmXYbPXSEsRN+saw== X-Received: by 2002:aa7:9533:0:b029:2de:3b90:57a7 with SMTP id c19-20020aa795330000b02902de3b9057a7mr27227236pfp.15.1621900862027; Mon, 24 May 2021 17:01:02 -0700 (PDT) Received: from google.com (240.111.247.35.bc.googleusercontent.com. [35.247.111.240]) by smtp.gmail.com with ESMTPSA id a26sm11843722pff.149.2021.05.24.17.01.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 May 2021 17:01:01 -0700 (PDT) Date: Tue, 25 May 2021 00:00:57 +0000 From: Sean Christopherson To: Jim Mattson Cc: Paolo Bonzini , Marc Orr , kvm list , David Rientjes , Konrad Rzeszutek Wilk , linux-mm , Andrew Morton , Radim =?utf-8?B?S3LEjW3DocWZ?= , Matthew Wilcox , Dave Hansen , Wanpeng Li Subject: Re: [kvm PATCH v6 0/2] shrink vcpu_vmx down to order 2 Message-ID: References: <20181031234928.144206-1-marcorr@google.com> <34bf7026-4f83-067e-f3d8-aad76f9cf624@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 02937E005F25 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=XhDYLFBS; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of seanjc@google.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=seanjc@google.com X-Rspamd-Server: rspam03 X-Stat-Signature: dzb5kbrbah1bpbtwh6c49sqyjs5r33rg X-HE-Tag: 1621900855-543046 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 24, 2021, Jim Mattson wrote: > On Mon, May 24, 2021 at 3:44 PM Sean Christopherson wrote: > > > > On Mon, May 24, 2021, Paolo Bonzini wrote: > > > On 21/05/21 22:58, Jim Mattson wrote: > > > > On Wed, Oct 31, 2018 at 4:49 PM Marc Orr wrote: > > > > > > > > > > Compared to the last version, I've: > > > > > (1) dropped the vmalloc patches > > > > > (2) updated the kmem cache for the guest_fpu field in the kvm_vcpu_arch > > > > > struct to be sized according to fpu_kernel_xstate_size > > > > > (3) Added minimum FPU checks in KVM's x86 init logic to avoid memory > > > > > corruption issues. > > > > > > > > > > Marc Orr (2): > > > > > kvm: x86: Use task structs fpu field for user > > > > > kvm: x86: Dynamically allocate guest_fpu > > > > > > > > > > arch/x86/include/asm/kvm_host.h | 10 +++--- > > > > > arch/x86/kvm/svm.c | 10 ++++++ > > > > > arch/x86/kvm/vmx.c | 10 ++++++ > > > > > arch/x86/kvm/x86.c | 55 ++++++++++++++++++++++++--------- > > > > > 4 files changed, 65 insertions(+), 20 deletions(-) > > > > > > > > > > -- > > > > > > > > Whatever happened to this series? > > > > > > There was a question about the usage of kmem_cache_create_usercopy, and a v7 > > > was never sent. > > > > What's that go to do with anything? :-D > > > > b666a4b69739 ("kvm: x86: Dynamically allocate guest_fpu") > > 240c35a3783a ("kvm: x86: Use task structs fpu field for user") > > So, that's what the series was trimmed down to. Thanks! > > Did we still manage to get down to order 2? Yep, almost made it to order-1! Current size (without 8 bytes from CONFIG_HYPERV=y) is 9728.