From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84930C47095 for ; Mon, 7 Jun 2021 14:54:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EF6EA61107 for ; Mon, 7 Jun 2021 14:54:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF6EA61107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 892DC6B0036; Mon, 7 Jun 2021 10:54:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8422D6B006E; Mon, 7 Jun 2021 10:54:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BC936B0070; Mon, 7 Jun 2021 10:54:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0069.hostedemail.com [216.40.44.69]) by kanga.kvack.org (Postfix) with ESMTP id 3630A6B0036 for ; Mon, 7 Jun 2021 10:54:41 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C65C282499A8 for ; Mon, 7 Jun 2021 14:54:40 +0000 (UTC) X-FDA: 78227224320.37.67A2B95 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf19.hostedemail.com (Postfix) with ESMTP id 5FBB19001460 for ; Mon, 7 Jun 2021 14:54:33 +0000 (UTC) Received: from zn.tnic (p200300ec2f0b4f0010db370b6947fb68.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:4f00:10db:370b:6947:fb68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 54EC81EC04CC; Mon, 7 Jun 2021 16:54:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1623077674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=DkskgYhv3CpcRt1UBQdVga8YOE910b/AK0zkqCeMk5Q=; b=B2WSbbvqp4seSrpi84QxtYgx7pE62m2aoNK9Z7GTfQ7mrnKEVj/yNCeFXxev9C2iGtC/O9 hPxvkFgHhKZVdFwdXW1vGsA7BRlvbo32+Yj4opf1oUGwt9PiLczI17X425rx4GrGI5RqqL W1IWDPcZ1ymoTrJQao4ERgbBhxDRfYg= Date: Mon, 7 Jun 2021 16:54:29 +0200 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , tony.luck@intel.com, npmccallum@redhat.com Subject: Re: [PATCH Part1 RFC v3 06/22] x86/sev: check SEV-SNP features support Message-ID: References: <20210602140416.23573-1-brijesh.singh@amd.com> <20210602140416.23573-7-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210602140416.23573-7-brijesh.singh@amd.com> Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=B2WSbbvq; spf=pass (imf19.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=temperror reason="server fail" header.from=alien8.de (policy=temperror) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5FBB19001460 X-Stat-Signature: r8sz4swh9b8gbuhxgj47zfmt17xei14g X-HE-Tag: 1623077673-874223 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 02, 2021 at 09:04:00AM -0500, Brijesh Singh wrote: > static bool early_setup_sev_es(void) This function is doing SNP init now too, so it should be called something generic like do_early_sev_setup() or so. > #define GHCB_SEV_ES_GEN_REQ 0 > #define GHCB_SEV_ES_PROT_UNSUPPORTED 1 > +#define GHCB_SEV_ES_SNP_UNSUPPORTED 2 GHCB_SNP_UNSUPPORTED > +static bool __init sev_snp_check_hypervisor_features(void) check_hv_features() is nice and short. > diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c > index 77a754365ba9..9b70b7332614 100644 > --- a/arch/x86/kernel/sev.c > +++ b/arch/x86/kernel/sev.c > @@ -609,6 +609,10 @@ static bool __init sev_es_setup_ghcb(void) Ditto for this one: setup_ghcb() Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette