From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD110C47087 for ; Fri, 28 May 2021 05:13:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E9DB3613B5 for ; Fri, 28 May 2021 05:13:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9DB3613B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5B3926B006C; Fri, 28 May 2021 01:13:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 562FE6B006E; Fri, 28 May 2021 01:13:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38E3B6B0070; Fri, 28 May 2021 01:13:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0227.hostedemail.com [216.40.44.227]) by kanga.kvack.org (Postfix) with ESMTP id 078696B006C for ; Fri, 28 May 2021 01:13:51 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 83C406C3A for ; Fri, 28 May 2021 05:13:51 +0000 (UTC) X-FDA: 78189472662.30.109B29A Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf29.hostedemail.com (Postfix) with ESMTP id 1D6FE375B for ; Fri, 28 May 2021 05:13:39 +0000 (UTC) Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14S52qFd140317; Fri, 28 May 2021 01:13:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pp1; bh=UiKekC5zenLEC0oiLXbWNjq2YAV5vKtNk4ruw7i2o/E=; b=ooQumS1ThFz0Tk4i41h0UNMuB0iLSZYz3A769Ej0GS1qlvElmA8vQTDuA0iJ6OfLelso kyomktDQXaagyBDLDRyQtAsHPVdausRjQiRQrEFdPbNC38APg6R8U9Ox/H7/5dnvpsye gTc3VSILgM1aKmzYJ0KTSYxViEXzArffuqeGrls0pmm/5lfPmrufGPEV+3mRSjkKKd3J Bozd4sUufGiUC0dPBkBL69fvgcw3VIF3o+H4kpPUloilcK0gPVmU6e8G+m5dr5913WfM TdXhcOlj93JE1WFIHsa/LzWTLGvueDPmNKTH61DSezg9MfCXWQrATOLYSlCde2NFRUoD XA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 38ts251e67-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 May 2021 01:13:46 -0400 Received: from m0098414.ppops.net (m0098414.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 14S53UY3143128; Fri, 28 May 2021 01:13:46 -0400 Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 38ts251e5q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 May 2021 01:13:46 -0400 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 14S59iHe003612; Fri, 28 May 2021 05:13:44 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma04ams.nl.ibm.com with ESMTP id 38s1r49j1n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 May 2021 05:13:44 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 14S5DC1m36569548 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 28 May 2021 05:13:12 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1C059A4054; Fri, 28 May 2021 05:13:42 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9E8B1A405B; Fri, 28 May 2021 05:13:40 +0000 (GMT) Received: from linux.ibm.com (unknown [9.145.39.77]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Fri, 28 May 2021 05:13:40 +0000 (GMT) Date: Fri, 28 May 2021 08:13:38 +0300 From: Mike Rapoport To: Andrew Morton Cc: Catalin Marinas , Qian Cai , David Hildenbrand , Anshuman Khandual , Ard Biesheuvel , Linux Memory Management List , Will Deacon , Marc Zyngier , Linux Kernel Mailing List , Linux ARM Subject: Re: Arm64 crash while reading memory sysfs Message-ID: References: <20210527175047.GK8661@arm.com> <20210527155644.7792b4eaa16ec56645e1080c@linux-foundation.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210527155644.7792b4eaa16ec56645e1080c@linux-foundation.org> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: _CCvDuIOOIv9xCKh0MxlB1QK02SSnVij X-Proofpoint-GUID: xKj0ytwkT9eL06qp4cBrTpqhJfi10oKo X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-05-28_02:2021-05-27,2021-05-28 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 mlxlogscore=744 malwarescore=0 spamscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105280032 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=ooQumS1T; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf29.hostedemail.com: domain of rppt@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1D6FE375B X-Stat-Signature: cky8xmad1tiekh6epo3gm1axuqacxzj4 X-HE-Tag: 1622178819-174494 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 27, 2021 at 03:56:44PM -0700, Andrew Morton wrote: > On Thu, 27 May 2021 18:50:48 +0100 Catalin Marinas wrote: > > > > Can you please try Anshuman's patch "arm64/mm: Drop HAVE_ARCH_PFN_VALID": > > > > > > https://lore.kernel.org/lkml/1621947349-25421-1-git-send-email-anshuman.khandual@arm.com > > > > > > It seems to me that the check for memblock_is_memory() in > > > arm64::pfn_valid() is what makes init_unavailable_range() to bail out for > > > section parts that are not actually populated and then we have > > > VM_BUG_ON_PAGE(PagePoisoned(p)) for these pages. > > > > I acked Anshuman's patch, I think they all need to go in together. > > That's neat. Specifically which patches are we referring to here? arm64: drop pfn_valid_within() and simplify pfn_valid(): https://lore.kernel.org/lkml/20210511100550.28178-5-rppt@kernel.org arm64/mm: Drop HAVE_ARCH_PFN_VALID: https://lore.kernel.org/lkml/1621947349-25421-1-git-send-email-anshuman.khandual@arm.com -- Sincerely yours, Mike.