From: Petr Mladek <pmladek@suse.com>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-mm@kvack.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH v2 4/4] slub: Force on no_hash_pointers when slub_debug is enabled
Date: Mon, 31 May 2021 11:28:07 +0200 [thread overview]
Message-ID: <YLSsJ/QRuHXLEMQ4@alley> (raw)
In-Reply-To: <CAE-0n50PogTpc8G9DR23DnX2K2pkvz-1vrO+iNAFOkhrzAOong@mail.gmail.com>
On Wed 2021-05-26 15:27:37, Stephen Boyd wrote:
> Quoting Petr Mladek (2021-05-26 06:47:23)
> > On Wed 2021-05-26 12:48:47, Vlastimil Babka wrote:
> > > On 5/26/21 4:56 AM, Stephen Boyd wrote:
> > > > Obscuring the pointers that slub shows when debugging makes for some
> > > > confusing slub debug messages:
> > > >
> > > > Padding overwritten. 0x0000000079f0674a-0x000000000d4dce17
> > > >
> > > > I opted for extern because I guess we don't want to advertise
> > > > no_hash_pointers_enable() in some sort of header file? It can be put in
> > > > a header file
> > >
> > > Hm looks like the bots disagree. I suppose a declaration right above definition
> > > in lib/vsprintf.c would silence them, but I'll leave it to printk maintainers if
> > > they would prefer that way or traditionally
> > > include/linux/kernel.h
> >
> > I slightly prefer to put it into kernel.h. I expect that some more
> > debugging facilities would want to enable this in the future.
> > But I would accept even the "ugly" declaration in vsprintf.c.
>
> Ok no problem. Would printk.h be more appropriate?
kernel.h looks more appropriate to me. vsprintf-related are there and
no_hash_pointers is implemented and handled in vsprintf.c.
Best Regards,
Petr
prev parent reply other threads:[~2021-05-31 9:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 2:56 [PATCH v2 0/4] slub: Print non-hashed pointers in slub debugging Stephen Boyd
2021-05-26 2:56 ` [PATCH v2 1/4] slub: Restore slub_debug=- behavior Stephen Boyd
2021-05-26 4:04 ` [External] " Muchun Song
2021-05-26 10:39 ` Vlastimil Babka
2021-05-26 20:20 ` Stephen Boyd
2021-05-27 2:51 ` Muchun Song
2021-05-26 2:56 ` [PATCH v2 2/4] slub: Actually use 'message' in restore_bytes() Stephen Boyd
2021-05-26 3:29 ` [External] " Muchun Song
2021-05-26 2:56 ` [PATCH v2 3/4] slub: Indicate slab_fix() uses printf formats Stephen Boyd
2021-05-26 10:40 ` Vlastimil Babka
2021-05-26 2:56 ` [PATCH v2 4/4] slub: Force on no_hash_pointers when slub_debug is enabled Stephen Boyd
2021-05-26 5:40 ` kernel test robot
2021-05-26 7:54 ` kernel test robot
2021-05-26 10:48 ` Vlastimil Babka
2021-05-26 13:47 ` Petr Mladek
2021-05-26 19:27 ` Stephen Boyd
2021-05-31 9:28 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLSsJ/QRuHXLEMQ4@alley \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=swboyd@chromium.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).