From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D034C4743D for ; Sat, 5 Jun 2021 21:02:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D4363613DF for ; Sat, 5 Jun 2021 21:02:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4363613DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0FF5A6B006C; Sat, 5 Jun 2021 17:02:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 089956B006E; Sat, 5 Jun 2021 17:02:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E56D96B0070; Sat, 5 Jun 2021 17:02:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0063.hostedemail.com [216.40.44.63]) by kanga.kvack.org (Postfix) with ESMTP id B0C626B006C for ; Sat, 5 Jun 2021 17:02:28 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 42845181AC9CC for ; Sat, 5 Jun 2021 21:02:28 +0000 (UTC) X-FDA: 78220893576.24.DDB41BD Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by imf03.hostedemail.com (Postfix) with ESMTP id D8654C00CBE0 for ; Sat, 5 Jun 2021 21:02:26 +0000 (UTC) Received: by mail-io1-f50.google.com with SMTP id b25so14191268iot.5 for ; Sat, 05 Jun 2021 14:02:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NIy5STFt8B/kR9D8BVeg93HRdwmMgucQuLC6yJOK6dk=; b=Q315pp1gIlnMk9UoRrke2c6bkaiMug8IMQObLkWwc/qvJEnL3jQWSx8hPstkZcczOW xREwez89d62c5/Usug8Vp/1jbOmf7/cyQM+K2M7uqZ9vgdBItGY1xetxmVuuL61eqXj7 Kham9hF6c/Ymk1ZjcNycUjzyL8r/r15njSWSfpXwWzqYKyLxkfqroRqkqYzD87VjT2VA kl5iHQDWT4OvvT7YwnNyjQLKkUwPUOD0pkR5WY4M3bocPWN1CSx6BvzOZOlW2XWiUR2U MkG+xzf42SDu3F+J6J/cPZ1LCf0LfmgFtFm4jK8OcSLFP4id7FKm7yrHZatQVzpLQSbi 4sNw== X-Gm-Message-State: AOAM532XYb9kn/w/IVTraKLPXU49ObUx31sA3whTm3/heQ2XfY/4OSr2 QeojrWx4F96s8rJwQRYf0Gc= X-Google-Smtp-Source: ABdhPJyWWrUSoYvQZHAGvmkQ8w2hjt/hHWfQs8X8zS6sFu5SF5NTFTWssaEfAwrwAJu3P4xyBg+cIQ== X-Received: by 2002:a6b:a01:: with SMTP id z1mr1006458ioi.178.1622926947323; Sat, 05 Jun 2021 14:02:27 -0700 (PDT) Received: from google.com (243.199.238.35.bc.googleusercontent.com. [35.238.199.243]) by smtp.gmail.com with ESMTPSA id b8sm1567326iln.72.2021.06.05.14.02.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Jun 2021 14:02:26 -0700 (PDT) Date: Sat, 5 Jun 2021 21:02:25 +0000 From: Dennis Zhou To: Roman Gushchin Cc: Tejun Heo , Christoph Lameter , Andrew Morton , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] percpu: memcg memory accounting rework Message-ID: References: <20210603010931.1472512-1-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210603010931.1472512-1-guro@fb.com> Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.166.50 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D8654C00CBE0 X-Stat-Signature: fhoec94tab9cztmph4o9gjjid69xdnnk X-HE-Tag: 1622926946-267083 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, On Wed, Jun 02, 2021 at 06:09:28PM -0700, Roman Gushchin wrote: > This patchset reworks memcg-based accounting of the percpu memory: > instead of using two types of chunks (memcg-aware and non-memcg-aware) > it treats all chunks as memcg-aware. An extra memory used for objcg > arrays will is compensated by a better chunks utilization, so the > total memory footprint should be the same or smaller. > > First two patches are preparational changes and cleanups on the memcg side. > The third one is percpu accounting rework. > > v2: > - make all chunks memcg-aware instead of on-demand objcg allocation, by Dennis > > v1: > https://lkml.org/lkml/2021/5/11/1343 > > > Roman Gushchin (3): > mm, memcg: mark cgroup_memory_nosocket, nokmem and noswap as > __ro_after_init > mm, memcg: introduce mem_cgroup_kmem_disabled() > percpu: rework memcg accounting > > include/linux/memcontrol.h | 5 ++ > mm/memcontrol.c | 11 ++- > mm/percpu-internal.h | 52 +-------------- > mm/percpu-km.c | 5 +- > mm/percpu-stats.c | 46 +++++-------- > mm/percpu-vm.c | 11 ++- > mm/percpu.c | 133 +++++++++++++++---------------------- > 7 files changed, 88 insertions(+), 175 deletions(-) > > -- > 2.31.1 > Thanks for this! It greatly simplifies the chunk maintenance. I've applied this to for-5.14. There is a trivial merge conflict though due to my for-5.14 being based on torvalds#v5.12-rc7, but that's fine. Thanks, Dennis