From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C972C48BE6 for ; Mon, 14 Jun 2021 08:26:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E62C96138C for ; Mon, 14 Jun 2021 08:26:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E62C96138C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 50C166B0070; Mon, 14 Jun 2021 04:26:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BC456B0071; Mon, 14 Jun 2021 04:26:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 336B26B0072; Mon, 14 Jun 2021 04:26:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id 04CFD6B0070 for ; Mon, 14 Jun 2021 04:26:09 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 86437443F for ; Mon, 14 Jun 2021 08:26:09 +0000 (UTC) X-FDA: 78251646858.17.838F1F4 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf07.hostedemail.com (Postfix) with ESMTP id 4AA18A000241 for ; Mon, 14 Jun 2021 08:26:00 +0000 (UTC) Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15E83sMK185918; Mon, 14 Jun 2021 04:26:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pp1; bh=V4snhQx1PZPcpA3xshDX0Y0qMosYGU9NJNTOmzv5Afo=; b=Jk+Wfbslm10B2P8nA2QaDW/0kuPpWrGpMeU6ClwiuGTisazNQbx3C1qzRdu6KVbq5Fxf S+Nu0WBRpM9j0pqhcl1/jJ8L+oqZVFqTjqbrCZITOwBJo/CqLxYAixhCOY9rCCymLJ1D YI9hwlTivolnfZr7eBTXJdXrrQYfYAhkKDg5mjuBZ0iNItjNAQxhA+Bdj66x9cH4+A5c vg1Qa4Fu5bd0kHv8GEvoouwwsq68jVNoROPk1mMbRMW7z/xZEXdyE6Qe75XeD0tAl82D /fQ7p7cgMmjojNrQBFUs8obZcM8x58dauPejq5KTgwFIHPcfvoaOIai2CZU3wYWM0DKK gg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3962m09k08-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Jun 2021 04:26:03 -0400 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 15E84LpQ189355; Mon, 14 Jun 2021 04:26:03 -0400 Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 3962m09jwd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Jun 2021 04:26:02 -0400 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 15E8ESAJ020759; Mon, 14 Jun 2021 08:26:00 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma05fra.de.ibm.com with ESMTP id 394mj8geky-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Jun 2021 08:26:00 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 15E8PvBG32506338 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Jun 2021 08:25:58 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BA8A2A4055; Mon, 14 Jun 2021 08:25:57 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9D624A4051; Mon, 14 Jun 2021 08:25:56 +0000 (GMT) Received: from linux.ibm.com (unknown [9.145.184.40]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Mon, 14 Jun 2021 08:25:56 +0000 (GMT) Date: Mon, 14 Jun 2021 11:25:54 +0300 From: Mike Rapoport To: Anshuman Khandual , Andrew Morton Cc: Catalin Marinas , Qian Cai , David Hildenbrand , Ard Biesheuvel , Linux Memory Management List , Will Deacon , Marc Zyngier , Linux Kernel Mailing List , Linux ARM Subject: Re: Arm64 crash while reading memory sysfs Message-ID: References: <20210527175047.GK8661@arm.com> <20210527155644.7792b4eaa16ec56645e1080c@linux-foundation.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 3C0z_IZB8lFnb7edX8JX7iWqshvOOXYY X-Proofpoint-GUID: ZCmJ0fybogtg16WYfB7grkWEHCV0Z2hM X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-06-14_01:2021-06-11,2021-06-14 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 adultscore=0 impostorscore=0 mlxscore=0 mlxlogscore=879 clxscore=1011 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106140059 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Jk+Wfbsl; spf=pass (imf07.hostedemail.com: domain of rppt@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com X-Stat-Signature: tgnr8by5tazput66sdoimq3xjqpf4o17 X-Rspamd-Queue-Id: 4AA18A000241 X-Rspamd-Server: rspam06 X-HE-Tag: 1623659160-345283 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 08, 2021 at 12:36:21PM +0530, Anshuman Khandual wrote: > > > On 5/28/21 10:43 AM, Mike Rapoport wrote: > > On Thu, May 27, 2021 at 03:56:44PM -0700, Andrew Morton wrote: > >> On Thu, 27 May 2021 18:50:48 +0100 Catalin Marinas wrote: > >> > >>>> Can you please try Anshuman's patch "arm64/mm: Drop HAVE_ARCH_PFN_VALID": > >>>> > >>>> https://lore.kernel.org/lkml/1621947349-25421-1-git-send-email-anshuman.khandual@arm.com > >>>> > >>>> It seems to me that the check for memblock_is_memory() in > >>>> arm64::pfn_valid() is what makes init_unavailable_range() to bail out for > >>>> section parts that are not actually populated and then we have > >>>> VM_BUG_ON_PAGE(PagePoisoned(p)) for these pages. > >>> > >>> I acked Anshuman's patch, I think they all need to go in together. > >> > >> That's neat. Specifically which patches are we referring to here? > > > > arm64: drop pfn_valid_within() and simplify pfn_valid(): > > https://lore.kernel.org/lkml/20210511100550.28178-5-rppt@kernel.org > > > > arm64/mm: Drop HAVE_ARCH_PFN_VALID: > > https://lore.kernel.org/lkml/1621947349-25421-1-git-send-email-anshuman.khandual@arm.com > > I dont see the above patch (which drops HAVE_ARCH_PFN_VALID on arm64) on linux-next > i.e. next-20210607. I might have missed some earlier context here but do not we want > to fallback on generic pfn_valid() after Mike's series ? Andrew, Can you please pick the two patches above? -- Sincerely yours, Mike.