From: Greg KH <greg@kroah.com>
To: sieberf@amazon.com
Cc: sj38.park@gmail.com, Jonathan.Cameron@huawei.com,
acme@kernel.org, akpm@linux-foundation.org,
alexander.shishkin@linux.intel.com, amit@kernel.org,
benh@kernel.crashing.org, brendanhiggins@google.com,
corbet@lwn.net, david@redhat.com, dwmw@amazon.com,
elver@google.com, fan.du@intel.com, foersleo@amazon.de,
gthelen@google.com, guoju.fgj@alibaba-inc.com,
linux-damon@amazon.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
mgorman@suse.de, minchan@kernel.org, mingo@redhat.com,
namhyung@kernel.org, peterz@infradead.org, riel@surriel.com,
rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org,
shakeelb@google.com, shuah@kernel.org, sjpark@amazon.de,
snu@amazon.de, vbabka@suse.cz, vdavydov.dev@gmail.com,
zgf574564920@gmail.com
Subject: Re: [PATCH v29 09/13] mm/damon/dbgfs: Support multiple contexts
Date: Mon, 14 Jun 2021 11:44:14 +0200 [thread overview]
Message-ID: <YMck7uUlSvqFqJZH@kroah.com> (raw)
In-Reply-To: <98a75d0c-2d1a-807e-050b-fb8e7d92f447@amazon.com>
On Mon, Jun 14, 2021 at 11:30:12AM +0200, sieberf@amazon.com wrote:
> + new_dir = debugfs_create_dir(name, root);
> + dbgfs_dirs[dbgfs_nr_ctxs] = new_dir;
>
> debugfs_create_dir might return ERR_PTR, should this be checked?
No. Why do you care, the logic will keep on working afterward even if
that were to happen.
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-14 9:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 7:56 [PATCH v29 00/13] Introduce Data Access MONitor (DAMON) SeongJae Park
2021-05-20 7:56 ` [PATCH v29 01/13] mm: " SeongJae Park
2021-05-20 7:56 ` [PATCH v29 02/13] mm/damon/core: Implement region-based sampling SeongJae Park
2021-05-20 7:56 ` [PATCH v29 03/13] mm/damon: Adaptively adjust regions SeongJae Park
2021-05-25 15:17 ` sieberf
2021-05-25 15:39 ` SeongJae Park
2021-05-20 7:56 ` [PATCH v29 04/13] mm/idle_page_tracking: Make PG_idle reusable SeongJae Park
2021-05-20 7:56 ` [PATCH v29 05/13] mm/damon: Implement primitives for the virtual memory address spaces SeongJae Park
2021-05-25 15:19 ` sieberf
2021-05-25 15:44 ` SeongJae Park
2021-05-20 7:56 ` [PATCH v29 06/13] mm/damon: Add a tracepoint SeongJae Park
2021-05-20 7:56 ` [PATCH v29 07/13] mm/damon: Implement a debugfs-based user space interface SeongJae Park
2021-06-11 18:59 ` sieberf
2021-06-14 6:48 ` SeongJae Park
2021-05-20 7:56 ` [PATCH v29 08/13] mm/damon/dbgfs: Export kdamond pid to the user space SeongJae Park
2021-06-14 7:54 ` sieberf
2021-05-20 7:56 ` [PATCH v29 09/13] mm/damon/dbgfs: Support multiple contexts SeongJae Park
2021-06-14 9:30 ` sieberf
2021-06-14 9:35 ` SeongJae Park
2021-06-14 9:44 ` Greg KH [this message]
2021-05-20 7:56 ` [PATCH v29 10/13] Documentation: Add documents for DAMON SeongJae Park
2021-06-09 7:03 ` SeongJae Park
2021-06-11 17:44 ` Boehme, Markus
2021-06-11 18:53 ` SeongJae Park
2021-05-20 7:56 ` [PATCH v29 11/13] mm/damon: Add kunit tests SeongJae Park
2021-05-20 7:56 ` [PATCH v29 12/13] mm/damon: Add user space selftests SeongJae Park
2021-06-11 13:57 ` Maximilian Heyne
2021-06-11 14:04 ` SeongJae Park
2021-05-20 7:56 ` [PATCH v29 13/13] MAINTAINERS: Update for DAMON SeongJae Park
2021-05-20 22:34 ` [PATCH v29 00/13] Introduce Data Access MONitor (DAMON) Andrew Morton
2021-05-21 2:53 ` Shakeel Butt
2021-05-21 8:55 ` Shah, Amit
2021-06-14 8:09 ` sieberf
2021-06-15 16:30 ` sieberf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMck7uUlSvqFqJZH@kroah.com \
--to=greg@kroah.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=amit@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=dwmw@amazon.com \
--cc=elver@google.com \
--cc=fan.du@intel.com \
--cc=foersleo@amazon.de \
--cc=gthelen@google.com \
--cc=guoju.fgj@alibaba-inc.com \
--cc=linux-damon@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=sieberf@amazon.com \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.de \
--cc=snu@amazon.de \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=zgf574564920@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).