From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31DCBC2B9F4 for ; Mon, 14 Jun 2021 16:18:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DB11161004 for ; Mon, 14 Jun 2021 16:17:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB11161004 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6F2216B006C; Mon, 14 Jun 2021 12:17:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A1B66B006E; Mon, 14 Jun 2021 12:17:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51B006B0070; Mon, 14 Jun 2021 12:17:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id 1D9076B006C for ; Mon, 14 Jun 2021 12:17:59 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B2122181AEF09 for ; Mon, 14 Jun 2021 16:17:58 +0000 (UTC) X-FDA: 78252835836.18.B81B180 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 2092FC005A20 for ; Mon, 14 Jun 2021 16:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5vWKwcu5zXbIS0gqk+gmRAwRmyT4qPUE/hpJYzofpcg=; b=jD8PC2c4jAqYP3BBYSnpaO0JFY FkpdHb8tru56FNbInWWf7nQCM6f/s+sl5xm9SvPduA6+Zn99Ia9kMiYa7Ap/sSiZzc7FrqQKsgird JMVaPlutN5bfhuqP2tGqQRAUdTHhdtEJi1wWMimTsjtMZQULcK7qWmtSdIFJq0UJaX610LWJEQptx tUqkHgSDI7oEZLWLfYq3NAflpVGhL0Z6VHIIxblppLbUDxSNpM6Nm728luSLDLWFbiqoPtYHzUxG5 H1Q+K+AgRQw7Ht8HDyzptEMNGD1HjknRQHmO/prS5fT5FeY4BY6iBnga1SHHblvzAS5c7EWG87HVK iIrEk0/A==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lspHG-005blJ-Dp; Mon, 14 Jun 2021 16:17:36 +0000 Date: Mon, 14 Jun 2021 17:17:30 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: Andrew Morton , Jan Kara , Al Viro , Greg Kroah-Hartman , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: remove the implicit .set_page_dirty default Message-ID: References: <20210614061512.3966143-1-hch@lst.de> <20210614155333.GB2413@lst.de> <20210614155530.GA2563@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210614155530.GA2563@lst.de> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2092FC005A20 X-Stat-Signature: 9hdf36g3nbhoraj98ijfj5oor5k6jm5z Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jD8PC2c4; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1623687468-632692 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 14, 2021 at 05:55:30PM +0200, Christoph Hellwig wrote: > On Mon, Jun 14, 2021 at 05:53:33PM +0200, Christoph Hellwig wrote: > > On Mon, Jun 14, 2021 at 01:23:22PM +0100, Matthew Wilcox wrote: > > > i have a somewhat similar series in the works ... > > > > > > https://git.infradead.org/users/willy/pagecache.git/commitdiff/1e7e8c2d82666b55690705d5bbe908e31d437edb > > > https://git.infradead.org/users/willy/pagecache.git/commitdiff/bf767a4969c0bc6735275ff7457a8082eef4c3fd > > > > > > ... the other patches rather depend on the folio work. > > > > Yes, these looks useful to me as well. > > > And in fact I suspect the code in __set_page_dirty_no_writeback should > really be the default if no ->set_page_dirty is set up. It is the > same code as the no-mapping case and really makes sense as the default > case.. yes; i was even wondering if that should be conditional on one of the "no writeback" bits in mapping ...