From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFC0BC48BDF for ; Tue, 15 Jun 2021 06:25:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8DC6A61410 for ; Tue, 15 Jun 2021 06:25:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DC6A61410 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B4F036B0036; Tue, 15 Jun 2021 02:25:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AFEED6B006E; Tue, 15 Jun 2021 02:25:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C6DB6B0070; Tue, 15 Jun 2021 02:25:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0048.hostedemail.com [216.40.44.48]) by kanga.kvack.org (Postfix) with ESMTP id 6D46F6B0036 for ; Tue, 15 Jun 2021 02:25:36 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 812B9824999B for ; Tue, 15 Jun 2021 06:25:34 +0000 (UTC) X-FDA: 78254971788.07.7EF4C57 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id 8125AC001C7C for ; Tue, 15 Jun 2021 06:25:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UOHRIpBkAkDRl0BGWB4kuvFPTUP08G/68bWuq+ypS88=; b=qZDwlyU8MooRSro57jBu9fs1Du YivK/XasX1eB0MJ+WL3m+HtuGw0tzVTzzDwj9hqsmSz/XgLogcS1fvYBCog3zUGPtpaRuqF33QxO6 eXKnpLCIOzrUrEcJ1izalLoaGrVaxmb0jJLY3emSMV8BWyZHfI4UdCbP8/0IFHyqLG9Nj1B84897v h15tyPPRspPeadmjaPX0suHbLbdC6sV/8MIDsczYwBa6xe8ylcWJxXUlGXXb/+KuiqHhSDCNQtZZy ZSao2e7RtG6CK40nDU+sG/EYEPT6LJ02LSTCzKSGoS/qkYVRNBGVlOUNB4VmxipFQjAvGTPSEgzk+ I1WE9JqA==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lt2VK-006AB2-Uv; Tue, 15 Jun 2021 06:25:01 +0000 Date: Tue, 15 Jun 2021 07:24:54 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 01/33] mm: Convert get_page_unless_zero() to return bool Message-ID: References: <20210614201435.1379188-1-willy@infradead.org> <20210614201435.1379188-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210614201435.1379188-2-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qZDwlyU8; spf=none (imf03.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8125AC001C7C X-Stat-Signature: ui1qie14r7bu36x53i7gd36seyauncuc X-HE-Tag: 1623738322-782408 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 14, 2021 at 09:14:03PM +0100, Matthew Wilcox (Oracle) wrote: > atomic_add_unless() returns bool, so remove the widening casts to int > in page_ref_add_unless() and get_page_unless_zero(). This causes gcc > to produce slightly larger code in isolate_migratepages_block(), but > it's not clear that it's worse code. Net +19 bytes of text. Strange. Anyway, this looks like the right type, so: Reviewed-by: Christoph Hellwig