From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EC7EC48BE5 for ; Tue, 15 Jun 2021 06:32:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D85706124B for ; Tue, 15 Jun 2021 06:31:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D85706124B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 701CC6B0036; Tue, 15 Jun 2021 02:31:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B1D06B006E; Tue, 15 Jun 2021 02:31:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52AC66B0070; Tue, 15 Jun 2021 02:31:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id 2213C6B0036 for ; Tue, 15 Jun 2021 02:31:59 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B918B180AD806 for ; Tue, 15 Jun 2021 06:31:58 +0000 (UTC) X-FDA: 78254987916.08.E512674 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id C78F3E000264 for ; Tue, 15 Jun 2021 06:31:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=l4ap9K14HzLuNaS/BB93x9SBcqR5Jq194sFXikh1T1c=; b=SQOeAsZve6bYiSpkDqA1s4BGBb cdHNM8jiOeoQE5l8DZwdGi7q7WCAtrtYhSiIQtItVydKqfTwUcf3858Up+9zRGBig449sqq8XIUM9 v/6MK6fZrAEeG07nsJxyC4SIPh3c7OelDCZAgyMI1WTUuB82SW5CeYS4uiPi62JxY0LHKIw6kb48b /tdFsAGDCVBVRZKoi+V4kw6i3yGfnwxLwJB/Fk5sEc8vpho6eVzrqGqu1jXw7RpM182+Y+qEy9Oz6 FG4tXCB1pIEtKySnSQGbDDSHYcDfLe+oqom1cVsFL9BM+K8ftMGY+O/PwwJsRrFTemAJ9/h6K39Yl 4tRhj3Ng==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lt2bq-006AUI-HK; Tue, 15 Jun 2021 06:31:40 +0000 Date: Tue, 15 Jun 2021 07:31:38 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , William Kucharski Subject: Re: [PATCH v11 33/33] mm: Add folio_mapped() Message-ID: References: <20210614201435.1379188-1-willy@infradead.org> <20210614201435.1379188-34-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210614201435.1379188-34-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=SQOeAsZv; spf=none (imf13.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C78F3E000264 X-Stat-Signature: e7ag4odjf9syt6xeoaiyo1d5r615ydju X-HE-Tag: 1623738709-784349 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 14, 2021 at 09:14:35PM +0100, Matthew Wilcox (Oracle) wrote: > This function is the equivalent of page_mapped(). It is slightly > shorter as we do not need to handle the PageTail() case. Reimplement > page_mapped() as a wrapper around folio_mapped(). folio_mapped() > is 13 bytes smaller than page_mapped(), but the page_mapped() wrapper > is 30 bytes, for a net increase of 17 bytes of text. I'd still prefer the code flow I suggested last time, but that really is just style and nothing substantial, so: Reviewed-by: Christoph Hellwig