From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE172C48BE5 for ; Wed, 16 Jun 2021 05:39:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 756326128C for ; Wed, 16 Jun 2021 05:39:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 756326128C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 182616B006C; Wed, 16 Jun 2021 01:39:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15A046B006E; Wed, 16 Jun 2021 01:39:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0211A6B0070; Wed, 16 Jun 2021 01:39:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id C61E26B006C for ; Wed, 16 Jun 2021 01:39:12 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5A8A1181AC9BF for ; Wed, 16 Jun 2021 05:39:12 +0000 (UTC) X-FDA: 78258483744.07.22236B2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 90F2880192EE for ; Wed, 16 Jun 2021 05:39:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=i6Te121nsbASjm5MP8RDzAtp9SFu5KeY0UqFquXM9wo=; b=rbOxO1z7VyYAhtsj0d8YPyVLvX 2b8Vyz7JNNOwBXWgCtSk3tgrMbQ/QC6cxA5fq7aQjdllRezVEGC+SDDNNXGeT3M+Gwx9D4oG/9XHy neZSiCMSbujw7lF2Fruj6EygGNzeK2Bd67SXBjir21DbZhpfx+xvP+r6gaomB7iJpgN0qQLLzawb3 qzKWxtm6Wb1ppZxg00KKTx6FAfwV/m5QKO/Q5FdlgGZEyj08Hs8K/yP7+SUCt8KP4ewHUEW4DzW21 RKi7y8jkyMOCZ+YwWFHK03dfDmwzKqFTWKwoKH1VJoE4E3zgQ7hE8m0NK0zkgq3je86CxD41eol8e iEnX/FOA==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltOFt-007e1r-NG; Wed, 16 Jun 2021 05:38:28 +0000 Date: Wed, 16 Jun 2021 06:38:25 +0100 From: Christoph Hellwig To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Dave Chinner , ceph-devel@vger.kernel.org, Chao Yu , Damien Le Moal , "Darrick J. Wong" , Jaegeuk Kim , Jeff Layton , Johannes Thumshirn , linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-xfs@vger.kernel.org, Miklos Szeredi , Steve French , Ted Tso , Matthew Wilcox , "Darrick J. Wong" Subject: Re: [PATCH 09/14] xfs: Convert double locking of MMAPLOCK to use VFS helpers Message-ID: References: <20210615090844.6045-1-jack@suse.cz> <20210615091814.28626-9-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210615091814.28626-9-jack@suse.cz> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rbOxO1z7; dmarc=none; spf=none (imf16.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org X-Rspamd-Server: rspam02 X-Stat-Signature: uz78zt3y9y51sjg8qbm7to67id3589dd X-Rspamd-Queue-Id: 90F2880192EE X-HE-Tag: 1623821942-526536 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 15, 2021 at 11:17:59AM +0200, Jan Kara wrote: > Convert places in XFS that take MMAPLOCK for two inodes to use helper > VFS provides for it (filemap_invalidate_down_write_two()). Note that > this changes lock ordering for MMAPLOCK from inode number based ordering > to pointer based ordering VFS generally uses. Looks good, Reviewed-by: Christoph Hellwig