From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7724C11F67 for ; Thu, 1 Jul 2021 06:58:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 950CD61490 for ; Thu, 1 Jul 2021 06:58:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 950CD61490 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C528B8D0296; Thu, 1 Jul 2021 02:58:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C02D76B00B6; Thu, 1 Jul 2021 02:58:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC9F88D0296; Thu, 1 Jul 2021 02:58:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id 8B5D16B00B5 for ; Thu, 1 Jul 2021 02:58:50 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5582F1647F for ; Thu, 1 Jul 2021 06:58:50 +0000 (UTC) X-FDA: 78313116420.01.3F44901 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 725C3400208B for ; Thu, 1 Jul 2021 06:58:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BSVgnYAxe2R8PoaegIcaOoM7XZhNbeX1pTTSxEBVoac=; b=t2TBq0380ll/0c0dnlNJtyZH4Q pZ3uqtk2mYqILxxYvHtGcznBcCHp0665VeItnTBAzfFHNF3MBv7Fbg6qF+X0RZJGPqitmulCAESR8 +yUfMbKqkpwCHAT+t5yQJ764GhUa5eoV2iO2rybbGnSK4BAEQOnfJOxKpoewRHjXSqbOZ7A30wLzb VK2FDWW602qB1Pnp7QK6g/y7oJd18Dj9OgPOUDt2VvOoCqFrbK3sYJg3wGpmotD5Em8lCMvht0Axu LQlBP8UbAZPT5raIsKeXxztu6i8DFuVQWh6y1F6TL4T475qRkSW0oCA5c9XTVG+JHdpVNsySgfvCw Uu9os80Q==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyqdr-006GrK-EC; Thu, 01 Jul 2021 06:58:00 +0000 Date: Thu, 1 Jul 2021 07:57:43 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, Johannes Weiner , Michal Hocko , Vladimir Davydov Subject: Re: [PATCH v3 03/18] mm/memcg: Use the node id in mem_cgroup_update_tree() Message-ID: References: <20210630040034.1155892-1-willy@infradead.org> <20210630040034.1155892-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210630040034.1155892-4-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 725C3400208B Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=t2TBq038; spf=none (imf18.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Stat-Signature: u1fdr45f4u89rc19taa466s4fq7141gg X-HE-Tag: 1625122729-555482 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 30, 2021 at 05:00:19AM +0100, Matthew Wilcox (Oracle) wrote: > By using the node id in mem_cgroup_update_tree(), we can delete > soft_limit_tree_from_page() and mem_cgroup_page_nodeinfo(). Saves 42 > bytes of kernel text on my config. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig