From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAD16C11F64 for ; Thu, 1 Jul 2021 07:18:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9B24761450 for ; Thu, 1 Jul 2021 07:18:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B24761450 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 163848D029C; Thu, 1 Jul 2021 03:18:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13B758D0297; Thu, 1 Jul 2021 03:18:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1E568D029C; Thu, 1 Jul 2021 03:18:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id CEB298D0297 for ; Thu, 1 Jul 2021 03:18:42 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9685B1807AD2F for ; Thu, 1 Jul 2021 07:18:42 +0000 (UTC) X-FDA: 78313166484.10.83F7F89 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 07503D0000A4 for ; Thu, 1 Jul 2021 07:18:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AO10H4pBYDXfj/GCG8I7YNtdmQX0P/FBy3uAzevfrYY=; b=YHVMxe4+ZCiCB/P9GLSQuCArCA ej7RrWbCiOh8iBi+p5GSYbUhnBrGn6VyP7cFQwsZ/OmwSJsUGpeyJp9Ow+QpkAHtsjZgi8llNPn22 Tv3Vhnv4ABQ/UR86yx5Ve/ZZPENgDBoHlW1glJQzXXuVriXDl95x6jRyvjUa0QYcjnSNH39k+JsPb yBcDaOUY87BKEcGL9XrsFfHTB36viWHYrIQIcdfT59ELinCYH+cR1NMA6YQGYWZcHcijIPkMa3eZ9 /REH3vSN4d0GcqfnrynhoPB251+k2wpzaOZ1oc4Kt+JCq7Okaouzs9s+9E/hrW9SAnDh2uNiro36r FB6Phk7Q==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyqxI-006Hst-NI; Thu, 01 Jul 2021 07:17:53 +0000 Date: Thu, 1 Jul 2021 08:17:48 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, Johannes Weiner , Michal Hocko , Vladimir Davydov Subject: Re: [PATCH v3 10/18] mm/memcg: Convert mem_cgroup_uncharge() to take a folio Message-ID: References: <20210630040034.1155892-1-willy@infradead.org> <20210630040034.1155892-11-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210630040034.1155892-11-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 07503D0000A4 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YHVMxe4+; spf=none (imf20.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Stat-Signature: iipiw8h8q3ipw7ny95nmr567j7eadhmo X-HE-Tag: 1625123921-15656 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 30, 2021 at 05:00:26AM +0100, Matthew Wilcox (Oracle) wrote: > Convert all the callers to call page_folio(). > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/memcontrol.h | 4 ++-- > mm/filemap.c | 2 +- > mm/khugepaged.c | 4 ++-- > mm/memcontrol.c | 14 +++++++------- > mm/memory-failure.c | 2 +- > mm/memremap.c | 2 +- > mm/page_alloc.c | 2 +- > mm/swap.c | 2 +- > 8 files changed, 16 insertions(+), 16 deletions(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 90d48b0e3191..d6386a2b9d7a 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -710,7 +710,7 @@ int mem_cgroup_swapin_charge_page(struct page *page, struct mm_struct *mm, > gfp_t gfp, swp_entry_t entry); > void mem_cgroup_swapin_uncharge_swap(swp_entry_t entry); > > -void mem_cgroup_uncharge(struct page *page); > +void mem_cgroup_uncharge(struct folio *); why do you drop the parameter name? Otherwise looks good: Reviewed-by: Christoph Hellwig