From: Matthew Wilcox <willy@infradead.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: mgorman@techsingularity.net, linux-nfs@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v2] mm/page_alloc: Return nr_populated when the array is full
Date: Mon, 28 Jun 2021 19:17:23 +0100 [thread overview]
Message-ID: <YNoSM1A/tS4SEMHE@casper.infradead.org> (raw)
In-Reply-To: <162490397938.1485.7782934829743772831.stgit@klimt.1015granger.net>
On Mon, Jun 28, 2021 at 02:12:59PM -0400, Chuck Lever wrote:
> The SUNRPC consumer of __alloc_bulk_pages() legitimately calls it
> with a full array sometimes. In that case, the correct return code,
> according to the API contract, is to return the number of pages
> already in the array/list.
>
> Let's clean up the return logic to make it clear that the returned
> value is always the total number of pages in the array/list, not the
> number of pages that were allocated during this call.
This is more complicated than either v1 or the version that Mel sent
earlier today. Is it worth it?
next prev parent reply other threads:[~2021-06-28 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 18:12 [PATCH v2] mm/page_alloc: Return nr_populated when the array is full Chuck Lever
2021-06-28 18:17 ` Matthew Wilcox [this message]
2021-06-28 20:06 ` Chuck Lever III
2021-06-29 8:14 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNoSM1A/tS4SEMHE@casper.infradead.org \
--to=willy@infradead.org \
--cc=chuck.lever@oracle.com \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mgorman@techsingularity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).