From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFAA9C11F65 for ; Wed, 30 Jun 2021 12:31:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7FE3D61584 for ; Wed, 30 Jun 2021 12:31:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FE3D61584 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E1F0B8D01A6; Wed, 30 Jun 2021 08:31:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCF4C8D01A2; Wed, 30 Jun 2021 08:31:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C970A8D01A6; Wed, 30 Jun 2021 08:31:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id A5A7A8D01A2 for ; Wed, 30 Jun 2021 08:31:46 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6D7D1822FC2B for ; Wed, 30 Jun 2021 12:31:46 +0000 (UTC) X-FDA: 78310326612.04.DC68B98 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id C196910004CE for ; Wed, 30 Jun 2021 12:31:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UBd7x8oOESyXHL0o+sRYkr8wI6RsNQA59DUwMSupoB0=; b=jP+5gMkb2FqkWqcLcLCf3XpWoh 5QgJSig4Hu9XHjCVUAgIVenQkEoLza5dGOKEq0m/nAO7Wv1ynntYUsaC2Mf7EI9nFROFb6lWvXJ6E ncM1tlURSqZmGILjzMUoC41gU+rXWMiOeCIaw501eSJFmWdOhqTYD4zKbw8+TZcR8bGzXFe+A3QK7 XqTpIc+LBlGc5FtnmFkMyxgePwIqrwXcuANAbl7LHtY8KzlJsUbQ/SX9aFlk548MbUQhdq9XRc4u8 f1iSuo4eAkhQNnDZuVodgOv4lTWkgDiLrhiVPuOu+XLhbCjWZf45LTN7QrLLEW2nZ5Rq3Eq4ZV+zM sYx45zEw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyZN7-005Kj2-EV; Wed, 30 Jun 2021 12:31:24 +0000 Date: Wed, 30 Jun 2021 13:31:17 +0100 From: Matthew Wilcox To: Michal Hocko Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, Johannes Weiner , Vladimir Davydov Subject: Re: [PATCH v3 14/18] mm/memcg: Convert mem_cgroup_move_account() to use a folio Message-ID: References: <20210630040034.1155892-1-willy@infradead.org> <20210630040034.1155892-15-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C196910004CE X-Stat-Signature: s4zpnbijhq7pxrdzbeg7hf44fbn9tobw Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jP+5gMkb; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1625056305-711722 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 30, 2021 at 02:20:38PM +0200, Michal Hocko wrote: > On Wed 30-06-21 12:22:48, Matthew Wilcox wrote: > > We need to decide what 'NR_ANON_THPS' means in a folio-based world where > > we have folios of all orders. Does it count only the number of pages > > in folios >= HPAGE_PMD_SIZE? Or does it count the number of pages in > > folios > PAGE_SIZE? > > At this stage we only have PMD based, right? I believe it would be > simpler to stick with that at the moment and change that to a more > generic way along with other places which need updating. > > Wrt. counters they do count pages so in this case this shouldn't be a > problem. But we do have counters for pmd mappings and that might need > some care. Looking at how these are reported: show_val_kb(m, "AnonHugePages: ", global_node_page_state(NR_ANON_THPS)); show_val_kb(m, "ShmemHugePages: ", global_node_page_state(NR_SHMEM_THPS)); show_val_kb(m, "ShmemPmdMapped: ", global_node_page_state(NR_SHMEM_PMDMAPPED)); show_val_kb(m, "FileHugePages: ", global_node_page_state(NR_FILE_THPS)); show_val_kb(m, "FilePmdMapped: ", global_node_page_state(NR_FILE_PMDMAPPED)); it specifically refers to 'HugePages', so I think we need to only count folios with order >= PMD_ORDER. I'll make that change to folio_transhuge() and use folio_transhuge() here.