From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 629ADC11F68 for ; Wed, 30 Jun 2021 12:32:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1745161625 for ; Wed, 30 Jun 2021 12:32:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1745161625 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2D30E8D01A7; Wed, 30 Jun 2021 08:32:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AA218D01A2; Wed, 30 Jun 2021 08:32:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14B578D01A7; Wed, 30 Jun 2021 08:32:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id E70778D01A2 for ; Wed, 30 Jun 2021 08:32:55 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id ABC4F82B7700 for ; Wed, 30 Jun 2021 12:32:55 +0000 (UTC) X-FDA: 78310329510.23.FABDBA6 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by imf26.hostedemail.com (Postfix) with ESMTP id 59839200170B for ; Wed, 30 Jun 2021 12:32:55 +0000 (UTC) Received: by mail-wr1-f53.google.com with SMTP id i8so3499360wrc.0 for ; Wed, 30 Jun 2021 05:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HUJtWNPJiBHCYwporvv4J+zIbXCE4pbnBbFi48C+38E=; b=jZMFEqHO9CNCmPa5FW5Q7xZIzLc/Zqmscfzxwqe5+MUEpfZYPNcp74CfU+fZHg5Bvp CjkLVdh9YEVGWaZViQCNJDQqFRuu0dFr0zFINCOtbwOwQYM7Ka6t/hH2mC7D+xc/IgOF 6ErkqnvmDe6COuHc5HmXmmM9PgUQXqf7UcWyA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HUJtWNPJiBHCYwporvv4J+zIbXCE4pbnBbFi48C+38E=; b=ieMUJlNL+N0wdI+1vz59evCfXvNldcn82becT4BHcasNd9XiPoXoCTwWCuE+nNI+Eh A/53oJZeGEfPL0ROIO4ZuFE7fTmvbaU84SikHsrDOtAkDQCS4WTeLSzfG+PX4cW++hQZ MHr+70BiKqXrj7qKlXd2LiBw86Vyo5JrS1IhBPpql0nPtWSz6qwSWGuA4eC20kfcn6fF 2Lw81nzXZxeZ0VPuQQ48t4UH51o0yIC7yJ6s0GhZMmKo+Luv8DUj5MboCgWvguUZ+tVC LpiZVb3p46wQgxyosvGpzmOsdS2pPqut8X1+SNteKagdcN0dRPgHFal/lUZRiZF6zC1n Q4DA== X-Gm-Message-State: AOAM532/x2tlqv5fPLkVak7yqZIpJHWE1BQxfUgWFhq/6FfiPF0dfBS+ w3X7lUaa2eexaACOSJS+XF07ow== X-Google-Smtp-Source: ABdhPJzubKpTl3fcp+LJcNdajbAh2dVoRapE0348qQ2NU3BYZBxvZ4uk95AgWX5+1MTJB0hBYdIWMQ== X-Received: by 2002:a5d:6a0d:: with SMTP id m13mr38405453wru.318.1625056374034; Wed, 30 Jun 2021 05:32:54 -0700 (PDT) Received: from localhost ([2620:10d:c093:400::5:8572]) by smtp.gmail.com with ESMTPSA id q5sm7997791wrx.57.2021.06.30.05.32.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Jun 2021 05:32:53 -0700 (PDT) Date: Wed, 30 Jun 2021 13:32:52 +0100 From: Chris Down To: Hui Su Cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/vmpressure: replace vmpressure_to_css() with vmpressure_to_memcg() Message-ID: References: <20210630112146.455103-1-suhui@zeku.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210630112146.455103-1-suhui@zeku.com> User-Agent: Mutt/2.1 (4b100969) (2021-06-12) X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 59839200170B Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=chrisdown.name header.s=google header.b=jZMFEqHO; spf=pass (imf26.hostedemail.com: domain of chris@chrisdown.name designates 209.85.221.53 as permitted sender) smtp.mailfrom=chris@chrisdown.name; dmarc=pass (policy=none) header.from=chrisdown.name X-Stat-Signature: r9o4jgutbfds1wxypwmp5pbgodhi9qnm X-HE-Tag: 1625056375-621022 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks! This looks like a reasonable cleanup. Hui Su writes: >We can get memcg directly form vmpr instead of vmpr->memcg->css->memcg, >so add a new func helper vmpressure_to_memcg(). >And no code will use vmpressure_to_css(), so delete it. > >Signed-off-by: Hui Su Acked-by: Chris Down >--- > include/linux/vmpressure.h | 2 +- > mm/memcontrol.c | 4 ++-- > mm/vmpressure.c | 3 +-- > 3 files changed, 4 insertions(+), 5 deletions(-) > >diff --git a/include/linux/vmpressure.h b/include/linux/vmpressure.h >index 6d28bc433c1c..6a2f51ebbfd3 100644 >--- a/include/linux/vmpressure.h >+++ b/include/linux/vmpressure.h >@@ -37,7 +37,7 @@ extern void vmpressure_prio(gfp_t gfp, struct mem_cgroup *memcg, int prio); > extern void vmpressure_init(struct vmpressure *vmpr); > extern void vmpressure_cleanup(struct vmpressure *vmpr); > extern struct vmpressure *memcg_to_vmpressure(struct mem_cgroup *memcg); >-extern struct cgroup_subsys_state *vmpressure_to_css(struct vmpressure *vmpr); >+extern struct mem_cgroup *vmpressure_to_memcg(struct vmpressure *vmpr); > extern int vmpressure_register_event(struct mem_cgroup *memcg, > struct eventfd_ctx *eventfd, > const char *args); >diff --git a/mm/memcontrol.c b/mm/memcontrol.c >index 64ada9e650a5..62163a9cee63 100644 >--- a/mm/memcontrol.c >+++ b/mm/memcontrol.c >@@ -247,9 +247,9 @@ struct vmpressure *memcg_to_vmpressure(struct mem_cgroup *memcg) > return &memcg->vmpressure; > } > >-struct cgroup_subsys_state *vmpressure_to_css(struct vmpressure *vmpr) >+struct mem_cgroup *vmpressure_to_memcg(struct vmpressure *vmpr) > { >- return &container_of(vmpr, struct mem_cgroup, vmpressure)->css; >+ return container_of(vmpr, struct mem_cgroup, vmpressure); > } > > #ifdef CONFIG_MEMCG_KMEM >diff --git a/mm/vmpressure.c b/mm/vmpressure.c >index d69019fc3789..04e81ac6d5d8 100644 >--- a/mm/vmpressure.c >+++ b/mm/vmpressure.c >@@ -74,8 +74,7 @@ static struct vmpressure *work_to_vmpressure(struct work_struct *work) > > static struct vmpressure *vmpressure_parent(struct vmpressure *vmpr) > { >- struct cgroup_subsys_state *css = vmpressure_to_css(vmpr); >- struct mem_cgroup *memcg = mem_cgroup_from_css(css); >+ struct mem_cgroup *memcg = vmpressure_to_memcg(vmpr); > > memcg = parent_mem_cgroup(memcg); > if (!memcg) >-- >2.25.1 > >