From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63FADC11F66 for ; Wed, 30 Jun 2021 19:19:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1232A6146D for ; Wed, 30 Jun 2021 19:19:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1232A6146D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7567A8D01C4; Wed, 30 Jun 2021 15:19:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 706F38D01A2; Wed, 30 Jun 2021 15:19:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A6F68D01C4; Wed, 30 Jun 2021 15:19:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id 31B818D01A2 for ; Wed, 30 Jun 2021 15:19:09 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id ECF21181A8DB9 for ; Wed, 30 Jun 2021 19:19:08 +0000 (UTC) X-FDA: 78311353176.37.6B9B4E2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 883E3700009B for ; Wed, 30 Jun 2021 19:19:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MsrlUX4klm+FZH6y60kQ4JaEGGQ1KiVKPX9RLosVC/A=; b=oWqhqkrj/cGxMBXJ0t4A7GnsgF tzd1jjKb5Jh73NmQgh8pGHPiFZfe1ypWOP3t77n30a3B9TKgK2UvmUt2RSOAx1AHlzGe7nRmtyykH 1mCpYJSItTlWNiXMPthvzGh4/cMCYhngz0QBrOp4JICQve+BsCJUJeBtGbV52/IbMT7LwvTcvaRaO LNguFtTihlOOpYTb0S8/CA9UlGW5FXWFFmna8CdF/4Kmh9+Nk6rDDqiIifK3TN7yCeETVTyFvDEER CcjWHjwdytU2FhuibAsB9XVx9yfygHaiby4NRz3EZzziZYsTi21MFe5X7JnvsLBmU+vxnSD6MiJ4J HwC/C3CQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyfjF-005hO6-Rc; Wed, 30 Jun 2021 19:18:45 +0000 Date: Wed, 30 Jun 2021 20:18:33 +0100 From: Matthew Wilcox To: linux-mm@kvack.org, cgroups@vger.kernel.org Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov Subject: Re: [PATCH v3 15/18] mm/memcg: Add mem_cgroup_folio_lruvec() Message-ID: References: <20210630040034.1155892-1-willy@infradead.org> <20210630040034.1155892-16-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210630040034.1155892-16-willy@infradead.org> Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oWqhqkrj; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam02 X-Stat-Signature: u6z9c4sfhzeyw51d59yrsu6j49r93wut X-Rspamd-Queue-Id: 883E3700009B X-HE-Tag: 1625080747-227871 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 30, 2021 at 05:00:31AM +0100, Matthew Wilcox (Oracle) wrote: > This is the folio equivalent of mem_cgroup_page_lruvec(). I'm just going through and removing the wrappers. Why is this function called this? There's an odd mix of lock_page_memcg() page_memcg() count_memcg_page_event() split_page_memcg() vs mem_cgroup_charge() mem_cgroup_swapin_charge_page() mem_cgroup_lruvec() mem_cgroup_from_task() I'd really like to call this function folio_lruvec(). It happens to behave differently if the folio is part of a memcg, but conceptually, lruvecs aren't particularly tied to memcgs. ... are there any other functions you'd like to rename while I'm changing pages to folios?