From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06603C07E95 for ; Wed, 7 Jul 2021 12:09:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 91B9161C5B for ; Wed, 7 Jul 2021 12:09:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91B9161C5B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F22146B0036; Wed, 7 Jul 2021 08:09:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF8C86B005D; Wed, 7 Jul 2021 08:09:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9B116B006C; Wed, 7 Jul 2021 08:09:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0168.hostedemail.com [216.40.44.168]) by kanga.kvack.org (Postfix) with ESMTP id B66646B0036 for ; Wed, 7 Jul 2021 08:09:25 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 19A3D181C1926 for ; Wed, 7 Jul 2021 12:09:25 +0000 (UTC) X-FDA: 78335671890.35.894DCB8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 78EB9D0000A7 for ; Wed, 7 Jul 2021 12:09:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RXoWcuIuDvfEGN36dlaWaQFgjdyKKyiHEIwv1084Sds=; b=dOeQ1dmEFArkaUwQG0GlkB/Y9C bDVBYDR1vEAJslZf/p4DKECDxKXSGnbscuT9ClyULCkJ2Rof48rCeXy1uSNem1vVUJvcv7E2nLenF mHcqmGHR9eKBEr/xTP+AP5UwpJXg+F0gQXCP16t2mL8kzKlXvhqCjfTv7FhxqxE5tD5fX0mwXQST2 5tlVl62OZunHsjopsZIKCqD16RmPYahjVUp0Q0WYsvD8HYq0t2FZl75ji3mfzl7o/54P0B/7+vHot KAGJcsUvbdap0kQ/RYVZqMTAXE5x5CobSi6YidZGE77tj2o094yBmFmr4HgbFhqltTD4tQspCmKQH ZYk/LzLw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m16MT-00CNOB-G0; Wed, 07 Jul 2021 12:09:08 +0000 Date: Wed, 7 Jul 2021 13:09:05 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, Johannes Weiner , Michal Hocko , Vladimir Davydov Subject: Re: [PATCH v3 10/18] mm/memcg: Convert mem_cgroup_uncharge() to take a folio Message-ID: References: <20210630040034.1155892-1-willy@infradead.org> <20210630040034.1155892-11-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=dOeQ1dmE; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: nr6c45yjnsas37org6uzeifiut847pk6 X-Rspamd-Queue-Id: 78EB9D0000A7 X-Rspamd-Server: rspam06 X-HE-Tag: 1625659764-708801 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 01, 2021 at 08:17:48AM +0100, Christoph Hellwig wrote: > On Wed, Jun 30, 2021 at 05:00:26AM +0100, Matthew Wilcox (Oracle) wrote: > > -void mem_cgroup_uncharge(struct page *page); > > +void mem_cgroup_uncharge(struct folio *); > > why do you drop the parameter name? I usually do where it's 'struct foo *foo' or 'foo_t foo'. If the best you can do is say "it's a page", well, yes, I knew that from the type. But since you've complained, I've added the pointless 'folio' to it. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig